[ofbiz-framework] branch trunk updated: Improved: Reducing scope of variables in org.apache.ofbiz.catalina package (OFBIZ-10479)

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new c2d9ba656d Improved: Reducing scope of variables in 
org.apache.ofbiz.catalina package (OFBIZ-10479)
c2d9ba656d is described below

commit c2d9ba656d6b919c889f6d5e78b894bc001a3329
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Sun Sep 25 12:03:09 2022 +0200

    Improved: Reducing scope of variables in org.apache.ofbiz.catalina package 
(OFBIZ-10479)
    
    Applied with some fuzz
    
    -    protected Integer sslAcceleratorPort = null;
    +    private Integer sslAcceleratorPort = null;
    
    was already done, rest by hand in SslAcceleratorValve
    
    Thanks: Pradhan Yash Sharma
---
 .../apache/ofbiz/catalina/container/CrossSubdomainSessionValve.java   | 4 ++--
 .../java/org/apache/ofbiz/catalina/container/SslAcceleratorValve.java | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CrossSubdomainSessionValve.java
 
b/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CrossSubdomainSessionValve.java
index ac569867c7..6a05583c8b 100644
--- 
a/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CrossSubdomainSessionValve.java
+++ 
b/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CrossSubdomainSessionValve.java
@@ -38,7 +38,7 @@ public class CrossSubdomainSessionValve extends ValveBase {
 
     private static final String MODULE = 
CrossSubdomainSessionValve.class.getName();
 
-    public CrossSubdomainSessionValve() {
+    CrossSubdomainSessionValve() {
         super();
     }
 
@@ -68,7 +68,7 @@ public class CrossSubdomainSessionValve extends ValveBase {
      * @param response the response
      * @param cookie the cookie
      */
-    protected void replaceCookie(Request request, Response response, Cookie 
cookie) {
+    private void replaceCookie(Request request, Response response, Cookie 
cookie) {
 
         Delegator delegator = (Delegator) request.getAttribute("delegator");
         // copy the existing session cookie, but use a different domain (only 
if domain is valid)
diff --git 
a/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/SslAcceleratorValve.java
 
b/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/SslAcceleratorValve.java
index 6e5905f25a..b65bc482f2 100644
--- 
a/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/SslAcceleratorValve.java
+++ 
b/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/SslAcceleratorValve.java
@@ -43,7 +43,7 @@ public class SslAcceleratorValve extends ValveBase {
      * Sets ssl accelerator port.
      * @param sslAcceleratorPort the ssl accelerator port
      */
-    public void setSslAcceleratorPort(Integer sslAcceleratorPort) {
+    void setSslAcceleratorPort(Integer sslAcceleratorPort) {
         this.sslAcceleratorPort = sslAcceleratorPort;
     }