This is an automated email from the ASF dual-hosted git repository. jleroux pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push: new 1514824b7d Fixed: no functional changes, fixes chekstyle issues 1514824b7d is described below commit 1514824b7d1a59c3d86927c7a2401fe103c25059 Author: Jacques Le Roux <jacques.le.r...@les7arts.com> AuthorDate: Fri Apr 22 18:33:57 2022 +0200 Fixed: no functional changes, fixes chekstyle issues Also adds javadoc task to GH actions, let's see if it works there. --- .github/workflows/gradle.yaml | 4 ++-- .../org/apache/ofbiz/webapp/event/ServiceMultiEventHandler.java | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/gradle.yaml b/.github/workflows/gradle.yaml index 51f35a957d..395a179941 100644 --- a/.github/workflows/gradle.yaml +++ b/.github/workflows/gradle.yaml @@ -39,7 +39,7 @@ jobs: - name: Grant execute permission for gradlew run: chmod +x gradlew - name: Build with Gradle - run: ./gradlew pullAllPluginsSource check + run: ./gradlew pullAllPluginsSource check javadoc # Below does not work, see see https://lists.apache.org/thread/80wzf4kclfk5nh2fss56jd6otf7y4n2f # - name: Builds with Gradle, checks style and run integration tests (just to know if they pass) -# run: ./gradlew pullAllPluginsSource check loadAll testIntegration +# run: ./gradlew pullAllPluginsSource check javadoc loadAll testIntegration diff --git a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/ServiceMultiEventHandler.java b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/ServiceMultiEventHandler.java index 439c3631c2..ca0298a39c 100644 --- a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/ServiceMultiEventHandler.java +++ b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/ServiceMultiEventHandler.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Licensed to the Apache Software Foundation (ASF) under one +* Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file @@ -47,11 +47,8 @@ import org.apache.ofbiz.service.ModelService; import org.apache.ofbiz.service.ServiceAuthException; import org.apache.ofbiz.service.ServiceUtil; import org.apache.ofbiz.service.ServiceValidationException; -import org.apache.ofbiz.webapp.control.ConfigXMLReader; import org.apache.ofbiz.webapp.control.ConfigXMLReader.Event; import org.apache.ofbiz.webapp.control.ConfigXMLReader.RequestMap; -import org.apache.ofbiz.webapp.control.RequestHandler; -import org.apache.ofbiz.webapp.control.WebAppConfigurationException; /** * ServiceMultiEventHandler - Event handler for running a service multiple times; for bulk forms @@ -63,6 +60,7 @@ public class ServiceMultiEventHandler implements EventHandler { public static final String SYNC = "sync"; public static final String ASYNC = "async"; + @SuppressWarnings("unused") private ServletContext servletContext; @Override