[ofbiz-framework] branch trunk updated: Fixed: Prevent Freemarker interpolation in fields (OFBIZ-12594)

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new b5370cbf51 Fixed: Prevent Freemarker interpolation in fields 
(OFBIZ-12594)
b5370cbf51 is described below

commit b5370cbf51f9442b70ff61ed288fd442ff657ef9
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Wed Apr 6 13:36:21 2022 +0200

    Fixed: Prevent Freemarker interpolation in fields (OFBIZ-12594)
    
    I did not catch an issue put in by this feature because BuildBot is not 
running
    for few days (see INFRA-23076) and i don't always run tests locally 
(relying on
    BuildBot and GH actions don't run tests).
    
    This is the error Solr tests throw else:
    <<Unfortunately, the stream was empty / not available. This may be caused by
    another servlet filter calling ServletRequest.getParameter*() before
    SolrDispatchFilter>>
    
    Got an issue with previous commit (I guess confusion with 22.01)
---
 .../src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java
 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java
index 31c6fc78e1..e87a538eed 100644
--- 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java
+++ 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java
@@ -150,7 +150,8 @@ public class ControlFilter extends HttpFilter {
             String uri = uriWithContext.substring(context.length());
 
             if 
(!GenericValue.getStackTraceAsString().contains("ControlFilterTests")
-                    && !System.getProperty("java.class.path").contains("--test 
component=solr") // Allows Solr tests
+                    && 
!(System.getProperty("java.class.path").contains("--test component=solr") // 
Allows Solr tests
+                            || 
System.getProperty("java.class.path").contains("ofbiz --test_ManifestJar.jar")) 
// Allows Solr tests in testIntegration
                     && SecurityUtil.containsFreemarkerInterpolation(req, resp, 
uri)) {
                 return;
             }