This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 455bfbe  Fixed: NullPointerException in plugin 'projectMgr' when 
listing TimeSheets (OFBIZ-12593)
455bfbe is described below

commit 455bfbe8b8b648b90fe062cc1da0bc0e35384ae2
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Sat Apr 2 11:37:32 2022 +0200

    Fixed: NullPointerException in plugin 'projectMgr' when listing TimeSheets 
(OFBIZ-12593)
    
    The empty string causes a NullPointerException, because in the WidgetWorker
    returns only an anchorElement  if the description of the hyperlink is not 
empty.
    
    Solution:  If the anchorElement is null, the line is simply not executed:
    
    Thanks: Tom Pietsch
---
 .../org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java     | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git 
a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
 
b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
index 9f33bee..b64d2ab 100644
--- 
a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
+++ 
b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
@@ -2915,7 +2915,9 @@ public final class MacroFormRenderer implements 
FormStringRenderer {
                 writer.append(hiddenFormElement.outerHtml());
                 final Element anchorElement = 
WidgetWorker.makeHiddenFormLinkAnchorElement(linkStyle,
                         encodedDescription, confirmation, modelFormField, 
request, context);
-                writer.append(anchorElement.outerHtml());
+                if (anchorElement != null) {
+                    writer.append(anchorElement.outerHtml());
+                }
             }
         } else {
             if ("layered-modal".equals(realLinkType)) {

Reply via email to