This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new b52091d Documented: Continue the common-theme upload (OFBIZ-9138
Create a common theme)
b52091d is described below
commit b52091d4b993ce74bce55faefe108198df1554a4
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Fri Feb 11 19:42:49 2022 +0100
Documented: Continue the common-theme upload (OFBIZ-9138 Create a common
theme)
Removes 2 FIXMEs about locations for image.server.path and
image.management.path
properties
This follows a message I sent to the user ML
https://lists.apache.org/thread/syysbhl99h0753h77hzd5frb50foclsq
that is:
<<Actually I was wrong when I said that "a feature was lost when
common-theme was
put in". The rest is right. This feature is the possibility, through
image.server.path property in catalog.properties file, to place the images,
and
other the static files as well, in a location that fits with you for
any reason. Notably following the NSA recommendation to place it in "a
non-web
accessible area". This to prevent webshell uploads and all kind of
other malicious files uploads. The same is true for the other property
image.management.path.
So the fact that before common-theme was put in, with the folder for images
/themes/common/images/webapp/images/, this folder was
/framework/images/webapp/images/ has nothing to do with "a non-web
accessible
area". That's you to decide...
There is also a ${tenantId} var used in image.server.path property that is
used
in case of multi-tenant, that's another thing.
So I finally don't think it's necessary to put the images and
image.management
in runtime. This would add nothing. I'll remove the FIXMEs>>
Thanks: APL+Win to help me format the message to 80 chars in a breeze :)
---
applications/product/config/catalog.properties | 2 --
1 file changed, 2 deletions(-)
diff --git a/applications/product/config/catalog.properties
b/applications/product/config/catalog.properties
index f43ddc6..4d5c232 100644
--- a/applications/product/config/catalog.properties
+++ b/applications/product/config/catalog.properties
@@ -21,7 +21,6 @@
# -- Image upload path on the server
-#FIXME the image server path need to be moved on runtime
image.server.path=${sys:getProperty('ofbiz.home')}/themes/common/images/webapp/images/${tenantId}
# -- The prefix to put on auto-generated image urls (can be relative or
absolute, whatever you want)
@@ -37,7 +36,6 @@ all.product.category=CATALOG1
reactivate.product.from.receipt=Y
# Image upload path on the image management
-#FIXME the image management path need to be moved on runtime
image.management.path=${sys:getProperty('ofbiz.home')}/themes/common/webapp/images/products/management
image.management.url=/images/products/management
image.management.nameofthumbnail=-100
