This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new 7df6899 Fixed: Wrong Field Name Definition in RequirementForms
(OFBIZ-12505)
7df6899 is described below
commit 7df68996a7b45d89d8c5664012b67e58427a87e5
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Mon Jan 31 12:21:37 2022 +0100
Fixed: Wrong Field Name Definition in RequirementForms (OFBIZ-12505)
The issue exists also in the older version.
The field "requirementByDate" form "FindApprovedProductRequirements" in
RequirementForms.xml has been set wrongly and it should be "requiredByDate".
This causes the result could not be queried out properly as indicated as
below:
The result is governed by the service "getRequirementsForSupplier",
where reads the list from the view "RequirementAndRole".
In the view entity definition, the field is defined as
<alias entity-alias="RQ" name="requiredByDate"/>,
but it is not the case in the form "FindApprovedProductRequirements" above.
After changing it to the correct name, the bug is solved.
jleroux: Same exists in OrderEntryForms::FindRequirements
Thanks: Schumann Ye for report Pierre Smits for creating the initial PR494
---
applications/order/widget/ordermgr/OrderEntryForms.xml | 2 +-
applications/order/widget/ordermgr/RequirementForms.xml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/applications/order/widget/ordermgr/OrderEntryForms.xml
b/applications/order/widget/ordermgr/OrderEntryForms.xml
index f46badd..90d60a5 100644
--- a/applications/order/widget/ordermgr/OrderEntryForms.xml
+++ b/applications/order/widget/ordermgr/OrderEntryForms.xml
@@ -24,7 +24,7 @@ under the License.
<field name="requirementId"><text-find/></field>
<field name="partyId" title="${uiLabelMap.PartySupplier}"><lookup
target-form-name="LookupPartyName"/></field>
<field name="productId" title="${uiLabelMap.ProductProductId}"><lookup
target-form-name="LookupProduct"/></field>
- <field name="requirementByDate"><date-find type="date"/></field>
+ <field name="requiredByDate"><date-find type="date"/></field>
<field name="submitButton" title="${uiLabelMap.CommonFind}"
widget-style="smallSubmit"><submit button-type="button"/></field>
</form>
<form name="RequirementsList" type="multi" use-row-submit="true"
target="addRequirementsToCart" title="" list-name="requirementsForSupplier"
diff --git a/applications/order/widget/ordermgr/RequirementForms.xml
b/applications/order/widget/ordermgr/RequirementForms.xml
index 45f4235..8210020 100644
--- a/applications/order/widget/ordermgr/RequirementForms.xml
+++ b/applications/order/widget/ordermgr/RequirementForms.xml
@@ -282,7 +282,7 @@ under the License.
</drop-down>
</field>
<field name="productId" title="${uiLabelMap.ProductProductId}"><lookup
target-form-name="LookupProduct"/></field>
- <field name="requirementByDate"><date-find type="date"/></field>
+ <field name="requiredByDate"><date-find type="date"/></field>
<field name="submitButton" title="${uiLabelMap.CommonFind}"
widget-style="smallSubmit"><submit button-type="button"/></field>
</form>
<form name="ApprovedProductRequirementsList" type="list" title=""
list-name="requirementsForSupplier" paginate-target="RequirementsForSupplier"
