This is an automated email from the ASF dual-hosted git repository. jleroux pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
The following commit(s) were added to refs/heads/trunk by this push: new efb1132 Improved: Fix some bugs Spotbugs reports (OFBIZ-12386) efb1132 is described below commit efb113250db20c8dd250d11ee47ef650a67b1a6b Author: Jacques Le Roux <jacques.le.r...@les7arts.com> AuthorDate: Sun Dec 26 13:23:49 2021 +0100 Improved: Fix some bugs Spotbugs reports (OFBIZ-12386) In ReportEncoder::createString == should not be used but equals should --- .../src/main/java/org/apache/ofbiz/htmlreport/util/ReportEncoder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pricat/src/main/java/org/apache/ofbiz/htmlreport/util/ReportEncoder.java b/pricat/src/main/java/org/apache/ofbiz/htmlreport/util/ReportEncoder.java index 2efe6ba..ba91068 100644 --- a/pricat/src/main/java/org/apache/ofbiz/htmlreport/util/ReportEncoder.java +++ b/pricat/src/main/java/org/apache/ofbiz/htmlreport/util/ReportEncoder.java @@ -127,7 +127,7 @@ public final class ReportEncoder { public static String createString(byte[] bytes, String encoding) { String enc = encoding.intern(); - if (enc != ENCODING_UTF_8) { + if (enc.equals(ENCODING_UTF_8)) { enc = lookupEncoding(enc, null); } if (enc != null) {