[ofbiz-framework] 02/05: Fixed: Fix some bugs Spotbugs reports (OFBIZ-12386)

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch release18.12
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git

commit 5866e2dbdf37d04e39ae62777743c27724575477
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Tue Nov 16 16:02:51 2021 +0100

    Fixed: Fix some bugs Spotbugs reports (OFBIZ-12386)
    
    Char arrays can't use toString()
    
    Thanks: Spotbugs :)
    
    Conflicts handled by hand
    EntitySaxReader.java
    ControlServlet.java (no changes to do)
    VisitHandler.java
---
 .../src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java  | 2 +-
 .../src/main/java/org/apache/ofbiz/webapp/stats/VisitHandler.java    | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git 
a/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java
 
b/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java
index b709412..104dc66 100644
--- 
a/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java
+++ 
b/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java
@@ -374,7 +374,7 @@ public class EntitySaxReader extends DefaultHandler {
                         }
                     } else {
                         Debug.logWarning("Ignoring invalid field name [" + 
currentFieldName + "] found for the entity: "
-                                + currentValue.getEntityName() + " with 
value=" + currentFieldValue.toString(), module);
+                                + currentValue.getEntityName() + " with 
value=" + new String(currentFieldValue), module);
                     }
                     currentFieldValue = null;
                 }
diff --git 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/stats/VisitHandler.java
 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/stats/VisitHandler.java
index 8bd7dc4..03475a4 100644
--- 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/stats/VisitHandler.java
+++ 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/stats/VisitHandler.java
@@ -20,6 +20,7 @@ package org.apache.ofbiz.webapp.stats;
 
 import java.net.InetAddress;
 import java.sql.Timestamp;
+import java.util.Arrays;
 import java.util.Locale;
 
 import javax.servlet.http.Cookie;
@@ -226,7 +227,9 @@ public class VisitHandler {
                             // first try to get the current ID from the 
visitor cookie
                             String cookieVisitorId = null;
                             Cookie[] cookies = request.getCookies();
-                            if (Debug.verboseOn()) Debug.logVerbose("Cookies:" 
+ cookies, module);
+                            if (Debug.verboseOn()) {
+                                Debug.logVerbose("Cookies:" + String.join(",", 
Arrays.stream(cookies).toArray(String[]::new)), MODULE);
+                            }
                             if (cookies != null) {
                                 for (int i = 0; i < cookies.length; i++) {
                                     if 
(cookies[i].getName().equals(visitorCookieName)) {