[ofbiz-framework] branch trunk updated: Fixed: Fix some bugs Spotbugs reports (OFBIZ-12386)

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new f126bae  Fixed: Fix some bugs Spotbugs reports (OFBIZ-12386)
f126bae is described below

commit f126bae89c99b2de5ecac2e0ed0abea5bdb5b415
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Tue Nov 16 16:02:51 2021 +0100

    Fixed: Fix some bugs Spotbugs reports (OFBIZ-12386)
    
    Char arrays can't use toString()
    
    Thanks: Spotbugs :)
---
 .../src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java    | 2 +-
 .../src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java  | 2 +-
 .../src/main/java/org/apache/ofbiz/webapp/stats/VisitHandler.java      | 3 ++-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java
 
b/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java
index 37ef2f1..c428a6a 100644
--- 
a/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java
+++ 
b/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java
@@ -442,7 +442,7 @@ public class EntitySaxReader extends DefaultHandler {
                         }
                     } else {
                         Debug.logWarning("Ignoring invalid field name [" + 
currentFieldName + "] found for the entity: "
-                                + currentValue.getEntityName() + " with 
value=" + currentFieldValue.toString(), MODULE);
+                                + currentValue.getEntityName() + " with 
value=" + new String(currentFieldValue), MODULE);
                     }
                     currentFieldValue = null;
                 }
diff --git 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java
 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java
index 326acbe..aca43e3 100644
--- 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java
+++ 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java
@@ -396,7 +396,7 @@ public class ControlServlet extends HttpServlet {
         Debug.logVerbose("--- End Request Headers: ---", MODULE);
         Debug.logVerbose("--- Start Request Parameters: ---", MODULE);
         request.getParameterMap().forEach((name, values) -> {
-            Debug.logVerbose(name + ":" + values, MODULE);
+            Debug.logVerbose(name + ":" + String.join(",", values), MODULE);
         });
         Debug.logVerbose("--- End Request Parameters: ---", MODULE);
         Debug.logVerbose("--- Start Request Attributes: ---", MODULE);
diff --git 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/stats/VisitHandler.java
 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/stats/VisitHandler.java
index d5a1c0d..5df4bfd 100644
--- 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/stats/VisitHandler.java
+++ 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/stats/VisitHandler.java
@@ -20,6 +20,7 @@ package org.apache.ofbiz.webapp.stats;
 
 import java.net.InetAddress;
 import java.sql.Timestamp;
+import java.util.Arrays;
 import java.util.Locale;
 
 import javax.servlet.http.Cookie;
@@ -227,7 +228,7 @@ public class VisitHandler {
                             String cookieVisitorId = null;
                             Cookie[] cookies = request.getCookies();
                             if (Debug.verboseOn()) {
-                                Debug.logVerbose("Cookies:" + cookies, MODULE);
+                                Debug.logVerbose("Cookies:" + String.join(",", 
Arrays.stream(cookies).toArray(String[]::new)), MODULE);
                             }
                             if (cookies != null) {
                                 for (int i = 0; i < cookies.length; i++) {