This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 97fe005  Fixed: Use NPM with gradle to get external JS dependencies 
(OFBIZ-11960)
97fe005 is described below

commit 97fe0058a89188eb9dadce92b270df220a53e515
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Thu Nov 11 11:26:02 2021 +0100

    Fixed: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
    
    additional-methods.min.js was missing, forgot previously
    
    Unrelated to plugins, but I also tried to use jquery-ui-dist from node
    https://www.npmjs.com/package/jquery-ui-dist despite I knew it was less 
secure
    
https://www.cvedetails.com/vulnerability-list/vendor_id-6538/product_id-31126/Jquery-Jquery-Ui.html
    But it missed at least the lookup icon in Helveticus.
    
    I'll check later when https://www.npmjs.com/package/jquery-ui-dist will 
provide
    a more secure version.
    
    Also in ecommerceI found this error in js console: : "$.timepicker is 
undefined"
    I did not find the reason. Anyway it seems not used in ecommerce.
---
 ecommerce/widget/Theme.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ecommerce/widget/Theme.xml b/ecommerce/widget/Theme.xml
index a1ea2cf..d14fc76 100644
--- a/ecommerce/widget/Theme.xml
+++ b/ecommerce/widget/Theme.xml
@@ -32,7 +32,7 @@ under the License.
 
     <theme-properties>
 
-        <property name="VT_HDR_JAVASCRIPT['add']" 
value="/common/js/jquery/plugins/validate/additional-methods.min.js"/>
+        <property name="VT_HDR_JAVASCRIPT['add']" 
value="/common/js/node_modules/jquery-validation/dist/additional-methods.min.js"/>
         <property name="VT_HDR_JAVASCRIPT['add']" 
value="/common/js/jquery/plugins/Readmore.js-master/readmore.js"/>
         <property name="VT_HDR_JAVASCRIPT['add']" 
value="/common/js/jquery/plugins/jquery-jgrowl/jquery.jgrowl-1.4.6.min.js"/>
         <property name="VT_HDR_JAVASCRIPT['add']" 
value="/ecommerce/js/bootstrap/js/bootstrap.bundle-4.3.1.min.js"/>

Reply via email to