This is an automated email from the ASF dual-hosted git repository. jleroux pushed a commit to branch release17.12 in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
commit 7933fef9f2eafc91f3fe78c1e86579d5958e8d2b Author: Jacques Le Roux <jacques.le.r...@les7arts.com> AuthorDate: Thu Mar 18 09:55:22 2021 +0100 Fixed: EditFinAccountReconciliations does not work (OFBIZ-12198) Like for createGlReconciliation at OFBIZ-10675 it must be that this has never been tested nor used by anybody. In relation with OFBIZ-10675, took me hours to understand that it was only missing an INOUT instead of a simple IN :/ --- applications/accounting/servicedef/services_ledger.xml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/applications/accounting/servicedef/services_ledger.xml b/applications/accounting/servicedef/services_ledger.xml index f60032a..db202a1 100644 --- a/applications/accounting/servicedef/services_ledger.xml +++ b/applications/accounting/servicedef/services_ledger.xml @@ -137,7 +137,7 @@ under the License. location="component://accounting/minilang/ledger/GeneralLedgerServices.xml" invoke="updateGlReconciliation" auth="true"> <description>Update a GlReconciliation record</description> <permission-service service-name="basicGeneralLedgerPermissionCheck" main-action="UPDATE"/> - <auto-attributes include="pk" mode="IN" optional="false"/> + <auto-attributes include="pk" mode="INOUT" optional="false"/> <auto-attributes include="nonpk" mode="IN" optional="true"> <exclude field-name="createdByUserLogin"/> <exclude field-name="lastModifiedByUserLogin"/> @@ -556,7 +556,7 @@ under the License. <attribute name="customTimePeriodId" mode="IN" type="String"/> <attribute name="previousTimePeriod" mode="OUT" type="Map" optional="true"/> </service> - <service name="getAcctgTransEntriesAndTransTotal" engine="simple" invoke="getAcctgTransEntriesAndTransTotal" + <service name="getAcctgTransEntriesAndTransTotal" engine="simple" invoke="getAcctgTransEntriesAndTransTotal" location="component://accounting/minilang/ledger/AcctgTransServices.xml" auth="true"> <description>Given AcctgTransAndEntire and Calculate acctg trans total for specific time period.</description> <attribute name="customTimePeriodStartDate" mode="IN" type="Timestamp"/> @@ -581,7 +581,7 @@ under the License. <attribute name="debitCreditDifference" type="BigDecimal" mode="OUT"/> </service> - <service name="revertAcctgTransOnCancelInvoice" engine="simple" + <service name="revertAcctgTransOnCancelInvoice" engine="simple" location="component://accounting/minilang/ledger/AcctgTransServices.xml" invoke="revertAcctgTransOnCancelInvoice" auth="true"> <description>Reverting Accounting Transaction And Entries on Canceling an Invoice</description> <attribute name="invoiceId" mode="IN" type="String" optional="false"/> @@ -589,7 +589,7 @@ under the License. <service name="revertAcctgTransOnRemovePaymentApplications" engine="simple" location="component://accounting/minilang/ledger/AcctgTransServices.xml" invoke="revertAcctgTransOnRemovePaymentApplications" auth="true"> <description>Create Reverse Accounting Transaction and Entries on removing PaymentApplication records.</description> - <attribute name="paymentApplicationId" mode="IN" type="String" optional="false"/> + <attribute name="paymentApplicationId" mode="IN" type="String" optional="false"/> </service> <service name="createGlAccountCategory" engine="entity-auto" default-entity-name="GlAccountCategory" invoke="create" auth="true"> @@ -656,7 +656,7 @@ under the License. <attribute name="oldStatusId" type="String" mode="OUT" optional="true"/> </service> - <service name="createUpdateCostCenter" engine="java" auth="true" invoke="createUpdateCostCenter" + <service name="createUpdateCostCenter" engine="java" auth="true" invoke="createUpdateCostCenter" location="org.apache.ofbiz.accounting.ledger.GeneralLedgerServices"> <description>Create Update CostCenters</description> <attribute name="glAccountId" mode="IN" type="String"/>