This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git

commit a234f8e2016bcd8e5d334421d57a61dfeca7d28d
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Fri Feb 5 11:26:34 2021 +0100

    Improved: fixes a Java doc issue reported by checkstyle
    
    Also removes unused ModelEntity::toXmlElement and 
ModelEntity::toGroupXmlElement
    
    tasks.checkstyleMain.maxErrors from 278 to 277
---
 build.gradle                                                  |  2 +-
 .../main/java/org/apache/ofbiz/entity/model/ModelEntity.java  | 11 ++---------
 2 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/build.gradle b/build.gradle
index f962f0a..f40f89a 100644
--- a/build.gradle
+++ b/build.gradle
@@ -310,7 +310,7 @@ checkstyle {
     // the sum of errors found last time it was changed after using the
     // ‘checkstyle’ tool present in the framework and in the official
     // plugins.
-    tasks.checkstyleMain.maxErrors = 278
+    tasks.checkstyleMain.maxErrors = 277
     // Currently there are a lot of errors so we need to temporarily
     // hide them to avoid polluting the terminal output.
     showViolations = false
diff --git 
a/framework/entity/src/main/java/org/apache/ofbiz/entity/model/ModelEntity.java 
b/framework/entity/src/main/java/org/apache/ofbiz/entity/model/ModelEntity.java
index 72bea12..83e44e7 100644
--- 
a/framework/entity/src/main/java/org/apache/ofbiz/entity/model/ModelEntity.java
+++ 
b/framework/entity/src/main/java/org/apache/ofbiz/entity/model/ModelEntity.java
@@ -2165,18 +2165,11 @@ public class ModelEntity implements 
Comparable<ModelEntity>, Serializable {
     }
 
     /**
-     * To xml element element.
+     * To Group elements of a document in a package
      * @param document the document
+     * @param packageName the name of the package where to group the elements 
of the document
      * @return the element
      */
-    public Element toXmlElement(Document document) {
-        return this.toXmlElement(document, this.getPackageName());
-    }
-
-    public Element toGroupXmlElement(Document document) {
-        return this.toGroupXmlElement(document, this.getPackageName());
-    }
-
     public Element toGroupXmlElement(Document document, String packageName) {
         if (UtilValidate.isNotEmpty(this.getPackageName()) && 
!packageName.equals(this.getPackageName())) {
             Debug.logWarning(

Reply via email to