Author: surajk
Date: Sat May 25 08:26:33 2019
New Revision: 1859915

URL: http://svn.apache.org/viewvc?rev=1859915&view=rev
Log:
Fixed: Enable entity timestamp fields.
(OFBIZ-10959)
While working on a Production environment, it is found that for some reason 
entity timestamp fields are disabled at Search Results screen in Trunk and the 
previous release branch.

Thanks Pawan Verma for reporting the issue and providing the patch, Jacques, 
Gil, Mathieu for reviewing it.

Modified:
    
ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/entity/FindGeneric.groovy
    ofbiz/ofbiz-framework/trunk/framework/widget/dtd/widget-form.xsd
    
ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java

Modified: 
ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/entity/FindGeneric.groovy
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/entity/FindGeneric.groovy?rev=1859915&r1=1859914&r2=1859915&view=diff
==============================================================================
--- 
ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/entity/FindGeneric.groovy
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/webtools/groovyScripts/entity/FindGeneric.groovy
 Sat May 25 08:26:33 2019
@@ -86,7 +86,7 @@ if (modelEntity) {
             '<field-map field-name="inputFields" from-field="parameters"/>' +
             '<field-map field-name="entityName" value="' + entityName + '"/>' +
             '</service></actions>' +
-            '<auto-fields-entity entity-name="' + entityName + '" 
default-field-type="display"/>' +
+            '<auto-fields-entity entity-name="' + entityName + '" 
default-field-type="display" include-internal="true"/>' +
             '<field name="entityName"><hidden value="' + entityName + 
'"/></field>' +
             '<field name="viewGeneric" title=" "><hyperlink 
target="ViewGeneric" description="view">' +
             '    <auto-parameters-entity entity-name="' + entityName + '"/>' +

Modified: ofbiz/ofbiz-framework/trunk/framework/widget/dtd/widget-form.xsd
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/dtd/widget-form.xsd?rev=1859915&r1=1859914&r2=1859915&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/framework/widget/dtd/widget-form.xsd (original)
+++ ofbiz/ofbiz-framework/trunk/framework/widget/dtd/widget-form.xsd Sat May 25 
08:26:33 2019
@@ -496,6 +496,11 @@ under the License.
                 </xs:simpleType>
             </xs:attribute>
             <xs:attribute type="xs:positiveInteger" name="default-position" 
default="1" />
+            <xs:attribute name="include-internal" type="xs:boolean" 
default="false">
+                <xs:annotation>
+                    <xs:documentation>This field will let the user enable 
internal fields of entity</xs:documentation>
+                </xs:annotation>
+            </xs:attribute>
         </xs:complexType>
     </xs:element>
     <xs:element name="sort-order">

Modified: 
ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java?rev=1859915&r1=1859914&r2=1859915&view=diff
==============================================================================
--- 
ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java
 Sat May 25 08:26:33 2019
@@ -758,7 +758,8 @@ public abstract class ModelForm extends
         Iterator<ModelField> modelFieldIter = modelEntity.getFieldsIterator();
         while (modelFieldIter.hasNext()) {
             ModelField modelField = modelFieldIter.next();
-            if (modelField.getIsAutoCreatedInternal()) {
+            // auto-add only if field was generated automatically by the 
entity engine or including internally
+            if (modelField.getIsAutoCreatedInternal() && 
!autoFieldsEntity.includeInternal) {
                 // don't ever auto-add these, should only be added if 
explicitly referenced
                 continue;
             }
@@ -1446,11 +1447,13 @@ public abstract class ModelForm extends
         public final String mapName;
         public final String defaultFieldType;
         public final int defaultPosition;
+        public final boolean includeInternal;
 
         public AutoFieldsEntity(Element element) {
             this.entityName = element.getAttribute("entity-name");
             this.mapName = element.getAttribute("map-name");
             this.defaultFieldType = element.getAttribute("default-field-type");
+            this.includeInternal = 
!"false".equals(element.getAttribute("include-internal"));
             String positionStr = element.getAttribute("default-position");
             int position = 1;
             try {


Reply via email to