Author: pgil
Date: Thu Sep 20 14:08:23 2018
New Revision: 1841477

URL: http://svn.apache.org/viewvc?rev=1841477&view=rev
Log:
Implemented : Deprecate shoppingCart.makeItemShipGroupAndAssoc with 
newShipGroup boolean parameter
(OFBIZ-10576)

Deprecates ShoppingCart.makeItemShipGroupAndAssoc with newShipGroup boolean 
parameter, since this parameters is not used.
Impact method usage

Modified:
    
ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java

Modified: 
ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java?rev=1841477&r1=1841476&r2=1841477&view=diff
==============================================================================
--- 
ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java
 Thu Sep 20 14:08:23 2018
@@ -4023,7 +4023,7 @@ public class ShoppingCart implements Ite
             if (shipGroupSeqId != null) {
                 groups.addAll(csi.makeItemShipGroupAndAssoc(dispatcher, 
this.getDelegator(), this, shipGroupSeqId));
             } else {
-                groups.addAll(csi.makeItemShipGroupAndAssoc(dispatcher, 
this.getDelegator(), this, UtilFormatOut.formatPaddedNumber(seqId, 5), true));
+                groups.addAll(csi.makeItemShipGroupAndAssoc(dispatcher, 
this.getDelegator(), this, UtilFormatOut.formatPaddedNumber(seqId, 5)));
             }
             seqId++;
         }
@@ -4747,11 +4747,12 @@ public class ShoppingCart implements Ite
             }
         }
 
-        public List<GenericValue> makeItemShipGroupAndAssoc(LocalDispatcher 
dispatcher, Delegator delegator, ShoppingCart cart, String shipGroupSeqId) {
-            return makeItemShipGroupAndAssoc(dispatcher, delegator, cart, 
shipGroupSeqId, false);
+        @Deprecated
+        public List<GenericValue> makeItemShipGroupAndAssoc(LocalDispatcher 
dispatcher, Delegator delegator, ShoppingCart cart, String shipGroupSeqId, 
boolean newShipGroup) {
+            return makeItemShipGroupAndAssoc(dispatcher, delegator, cart, 
shipGroupSeqId);
         }
 
-        public List<GenericValue> makeItemShipGroupAndAssoc(LocalDispatcher 
dispatcher, Delegator delegator, ShoppingCart cart, String shipGroupSeqId, 
boolean newShipGroup) {
+        public List<GenericValue> makeItemShipGroupAndAssoc(LocalDispatcher 
dispatcher, Delegator delegator, ShoppingCart cart, String shipGroupSeqId) {
             List<GenericValue> values = new LinkedList<>();
 
             // create order contact mech for shipping address


Reply via email to