svn commit: r1815342 - /ofbiz/ofbiz-framework/trunk/applications/marketing/src/main/java/org/apache/ofbiz/marketing/tracking/TrackingCodeEvents.java

[jleroux]

Author: jleroux
Date: Wed Nov 15 17:20:52 2017
New Revision: 1815342

URL: http://svn.apache.org/viewvc?rev=1815342&view=rev
Log:
Improved: Fixing defects reported by FindBugs, package 
org.apache.ofbiz.securityext.login.
(OFBIZ-9637)

I missed that siteId could be null due to the try/catch

Modified:
    
ofbiz/ofbiz-framework/trunk/applications/marketing/src/main/java/org/apache/ofbiz/marketing/tracking/TrackingCodeEvents.java

Modified: 
ofbiz/ofbiz-framework/trunk/applications/marketing/src/main/java/org/apache/ofbiz/marketing/tracking/TrackingCodeEvents.java
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/marketing/src/main/java/org/apache/ofbiz/marketing/tracking/TrackingCodeEvents.java?rev=1815342&r1=1815341&r2=1815342&view=diff
==============================================================================
--- 
ofbiz/ofbiz-framework/trunk/applications/marketing/src/main/java/org/apache/ofbiz/marketing/tracking/TrackingCodeEvents.java
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/applications/marketing/src/main/java/org/apache/ofbiz/marketing/tracking/TrackingCodeEvents.java
 Wed Nov 15 17:20:52 2017
@@ -269,7 +269,7 @@ public class TrackingCodeEvents {
                 }
             }
 
-            if (visitorSiteId == null || (visitorSiteId != null && 
!visitorSiteId.equals(siteId))) {
+            if (visitorSiteId == null || (visitorSiteId != null && 
!visitorSiteId.equals(siteId) && siteId != null)) {
                 // if trackingCode.siteId is  not null  write a trackable 
cookie with name in the form: Ofbiz.TKCSiteId and timeout will be 60 * 60 * 24 
* 365
                 Cookie siteIdCookie = new Cookie("Ofbiz.TKCD.SiteId", siteId);
                 siteIdCookie.setMaxAge(siteIdCookieAge);