Author: jleroux Date: Sun Jul 7 07:43:31 2013 New Revision: 1500382 URL: http://svn.apache.org/r1500382 Log: A patch from Deepak Dixit for "Application Menu items should be link not hidden form." https://issues.apache.org/jira/browse/OFBIZ-4913
Application menu item should be link not hidden form. As if its hidden form then you can not open it in new tab. Default menu item link type auto, and its create an hidden for for link if controller request call an event, but in menu item this should be link. Modified: ofbiz/trunk/framework/common/widget/CommonMenus.xml ofbiz/trunk/specialpurpose/example/widget/example/ExampleMenus.xml ofbiz/trunk/specialpurpose/myportal/widget/MyPortalMenus.xml Modified: ofbiz/trunk/framework/common/widget/CommonMenus.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonMenus.xml?rev=1500382&r1=1500381&r2=1500382&view=diff ============================================================================== --- ofbiz/trunk/framework/common/widget/CommonMenus.xml (original) +++ ofbiz/trunk/framework/common/widget/CommonMenus.xml Sun Jul 7 07:43:31 2013 @@ -23,7 +23,7 @@ under the License. default-selected-style="selected" menu-container-style="button-bar tab-bar" selected-menuitem-context-field-name="headerItem"> <menu-item name="main" title="${uiLabelMap.CommonMain}"> <condition><not><if-empty field="userLogin"/></not></condition> - <link target="main"/> + <link target="main" link-type="anchor"/> </menu-item> </menu> Modified: ofbiz/trunk/specialpurpose/example/widget/example/ExampleMenus.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/example/widget/example/ExampleMenus.xml?rev=1500382&r1=1500381&r2=1500382&view=diff ============================================================================== --- ofbiz/trunk/specialpurpose/example/widget/example/ExampleMenus.xml (original) +++ ofbiz/trunk/specialpurpose/example/widget/example/ExampleMenus.xml Sun Jul 7 07:43:31 2013 @@ -35,7 +35,7 @@ under the License. </menu-item> <menu-item name="portalPage" parent-portal-page-value="EXAMPLE"/> <menu-item name="Dashboard" title="${uiLabelMap.ExampleDashboard}" align-style="opposed"> - <link target="ManagePortalPages"> + <link target="ManagePortalPages" link-type="anchor"> <parameter param-name="parentPortalPageId" value="EXAMPLE"/> </link> </menu-item> Modified: ofbiz/trunk/specialpurpose/myportal/widget/MyPortalMenus.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/myportal/widget/MyPortalMenus.xml?rev=1500382&r1=1500381&r2=1500382&view=diff ============================================================================== --- ofbiz/trunk/specialpurpose/myportal/widget/MyPortalMenus.xml (original) +++ ofbiz/trunk/specialpurpose/myportal/widget/MyPortalMenus.xml Sun Jul 7 07:43:31 2013 @@ -24,7 +24,7 @@ under the License. extends="CommonAppBarMenu" extends-resource="component://common/widget/CommonMenus.xml"> <menu-item name="main" parent-portal-page-value="${parameters.parentPortalPageId}"/> <menu-item name="Dashboard" title="${uiLabelMap.CommonPreferences}" align-style="opposed"> - <link target="ManagePortalPages"> + <link target="ManagePortalPages" link-type="anchor"> <parameter param-name="parentPortalPageId" from-field="parameters.parentPortalPageId"/> </link> </menu-item>