This is an automated email from the ASF dual-hosted git repository. sjanc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-newtmgr.git
commit bddb2684dc840b94984d9c9b683124cc8aee4ba2 Author: Szymon Janc <[email protected]> AuthorDate: Thu Oct 22 00:14:10 2026 +0200 newtmgr/config: Fix formatting of connstring error messages The einval*ConnString() helpers forwarded their variadic arguments to fmt.Sprintf() as a single slice instead of spreading them, so error messages were printed as e.g. "Invalid baud: [abc]" or ended with "%!s(MISSING)". This also makes go vet's printf check fail, which prevents adding unit tests to this package. Assisted-by: Claude:claude-opus-5-5 --- newtmgr/config/ble_config.go | 2 +- newtmgr/config/bll_config.go | 2 +- newtmgr/config/bll_config_windows.go | 2 +- newtmgr/config/serial_config.go | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/newtmgr/config/ble_config.go b/newtmgr/config/ble_config.go index 142b177..5ce0286 100644 --- a/newtmgr/config/ble_config.go +++ b/newtmgr/config/ble_config.go @@ -58,7 +58,7 @@ func NewBleConfig() *BleConfig { } func einvalBleConnString(f string, args ...interface{}) error { - suffix := fmt.Sprintf(f, args) + suffix := fmt.Sprintf(f, args...) return util.FmtNewtError("Invalid BLE connstring; %s", suffix) } diff --git a/newtmgr/config/bll_config.go b/newtmgr/config/bll_config.go index ac94087..fe39a09 100644 --- a/newtmgr/config/bll_config.go +++ b/newtmgr/config/bll_config.go @@ -54,7 +54,7 @@ func NewBllConfig() *BllConfig { } func einvalBllConnString(f string, args ...interface{}) error { - suffix := fmt.Sprintf(f, args) + suffix := fmt.Sprintf(f, args...) return util.FmtNewtError("Invalid BLE connstring; %s", suffix) } diff --git a/newtmgr/config/bll_config_windows.go b/newtmgr/config/bll_config_windows.go index 277bcc9..e5e0e9c 100644 --- a/newtmgr/config/bll_config_windows.go +++ b/newtmgr/config/bll_config_windows.go @@ -42,7 +42,7 @@ func NewBllConfig() *BllConfig { } func einvalBllConnString(f string, args ...interface{}) error { - suffix := fmt.Sprintf(f, args) + suffix := fmt.Sprintf(f, args...) return util.FmtNewtError("Invalid BLE connstring; %s", suffix) } diff --git a/newtmgr/config/serial_config.go b/newtmgr/config/serial_config.go index 41b5af1..a5288ec 100644 --- a/newtmgr/config/serial_config.go +++ b/newtmgr/config/serial_config.go @@ -30,7 +30,7 @@ import ( ) func einvalSerialConnString(f string, args ...interface{}) error { - suffix := fmt.Sprintf(f, args) + suffix := fmt.Sprintf(f, args...) return util.FmtNewtError("Invalid serial connstring; %s", suffix) }
