This is an automated email from the ASF dual-hosted git repository.
sjanc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new 1640ebe57 ci: Report style issues even with skip-style-check label
1640ebe57 is described below
commit 1640ebe575fa73f9d3161df59a5d53a7ea372301
Author: Szymon Janc <[email protected]>
AuthorDate: Thu Oct 22 14:23:12 2026 +0200
ci: Report style issues even with skip-style-check label
The skip-style-check label used to skip the formatting step entirely,
so style violations were not visible in the logs. Always run the check
and print the clang-format diff, but when the label is present only
emit a warning and do not fail the job.
Assisted-by: Claude:claude-opus-5-5
---
.github/workflows/check_compliance.yml | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/.github/workflows/check_compliance.yml
b/.github/workflows/check_compliance.yml
index 8cad72ba1..d7fedb489 100644
--- a/.github/workflows/check_compliance.yml
+++ b/.github/workflows/check_compliance.yml
@@ -67,8 +67,9 @@ jobs:
core.setOutput('skip', hasLabel);
- name: Check formatting (diff only)
- if: steps.label_check.outputs.skip != 'true'
shell: bash
+ env:
+ SKIP_STYLE_CHECK: ${{ steps.label_check.outputs.skip }}
run: |
set +e
INFO_URL="https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md";
@@ -81,15 +82,16 @@ jobs:
echo ""
echo "For formatting guidelines, see:"
echo " $INFO_URL"
+ if [ "$SKIP_STYLE_CHECK" = "true" ]; then
+ echo "::warning::Ignoring formatting issues because" \
+ "'skip-style-check' label is present."
+ exit 0
+ fi
exit 1
else
echo "All good, no formatting issues."
fi
- - name: Skip style-check if label present
- if: steps.label_check.outputs.skip == 'true'
- run: echo "Skipping style check because 'skip-style-check' label is
present."
-
license_check:
name: Licensing
runs-on: ubuntu-slim
