This is an automated email from the ASF dual-hosted git repository. sjanc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git
commit a17c8aa9fb6a0996e6d032a1ae915ab9ff8156fa Author: Szymon Janc <[email protected]> AuthorDate: Wed Oct 21 10:32:06 2026 +0200 newt/toolchain: Fix missing section dumps in .lst file The .text, .rodata and .data section dumps were added to the .lst file only when objdump failed, so a successful dump was dropped and the error output of a failed one was written instead. The check got inverted in commit 0241d2f38 ("MYNEWT-365 newt can't handle files with spaces"), which replaced the shell redirection appending the output to the file. Originally the output was always appended and a failure, e.g. due to a missing section, was ignored. Write the dump on success and keep ignoring failures. Assisted-by: Claude:claude-opus-5-5 --- newt/toolchain/compiler.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/newt/toolchain/compiler.go b/newt/toolchain/compiler.go index e7953288..ab8aadd0 100644 --- a/newt/toolchain/compiler.go +++ b/newt/toolchain/compiler.go @@ -1367,7 +1367,7 @@ func (c *Compiler) generateExtras(elfFilename string, elfFilename, } o, err := util.ShellCommandLimitDbgOutput(cmd, nil, true, 0) - if err != nil { + if err == nil { if _, err := f.Write(o); err != nil { return util.NewNewtError(err.Error()) }
