This is an automated email from the ASF dual-hosted git repository.
mgorecki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new 03a69dc33 bsp/apollo3_evb: Fix blinky build
03a69dc33 is described below
commit 03a69dc333815386a868f356d9013084fa806a84
Author: Slawomir Kasenberg <[email protected]>
AuthorDate: Wed Jul 9 08:43:58 2025 +0200
bsp/apollo3_evb: Fix blinky build
LED_BLINK_PIN was defined as MYNEWT_VAL for this board
but now syscfg val LED_BLINK_PIN has default value LED_BLINK_PIN
This causes build error:
Error: In file included from apps/blinky/src/main.c:25:
apps/blinky/src/main.c: In function 'mynewt_main':
repos/apache-mynewt-core/hw/bsp/apollo3_evb/include/bsp/bsp.h:51:25: error:
implicit declaration of function 'MYNEWT_VAL' [-Wimplicit-function-declaration]
51 | #define LED_BLINK_PIN MYNEWT_VAL(LED_0_PIN)
| ^~~~~~~~~~
To fix this expression MYNEWT_VAL(LED_0_PIN)
is changed to MYNEWT_VAL_LED_0_PIN
Additionaly changed other LEDs and BUTTONs the same manner
---
hw/bsp/apollo3_evb/include/bsp/bsp.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/bsp/apollo3_evb/include/bsp/bsp.h
b/hw/bsp/apollo3_evb/include/bsp/bsp.h
index 884d063df..8ee1e2723 100644
--- a/hw/bsp/apollo3_evb/include/bsp/bsp.h
+++ b/hw/bsp/apollo3_evb/include/bsp/bsp.h
@@ -42,16 +42,16 @@ extern uint8_t _ram_start;
#define UART_CNT (2)
/* LED pins */
-#define LED_1 MYNEWT_VAL(LED_1_PIN)
-#define LED_2 MYNEWT_VAL(LED_2_PIN)
-#define LED_3 MYNEWT_VAL(LED_3_PIN)
-#define LED_4 MYNEWT_VAL(LED_4_PIN)
-#define LED_BLINK_PIN MYNEWT_VAL(LED_0_PIN)
+#define LED_1 MYNEWT_VAL_LED_1_PIN
+#define LED_2 MYNEWT_VAL_LED_2_PIN
+#define LED_3 MYNEWT_VAL_LED_3_PIN
+#define LED_4 MYNEWT_VAL_LED_4_PIN
+#define LED_BLINK_PIN MYNEWT_VAL_LED_0_PIN
/* Buttons */
-#define BUTTON_1 MYNEWT_VAL(BUTTON_0_PIN)
-#define BUTTON_2 MYNEWT_VAL(BUTTON_1_PIN)
-#define BUTTON_3 MYNEWT_VAL(BUTTON_2_PIN)
+#define BUTTON_1 MYNEWT_VAL_BUTTON_0_PIN
+#define BUTTON_2 MYNEWT_VAL_BUTTON_1_PIN
+#define BUTTON_3 MYNEWT_VAL_BUTTON_2_PIN
/* Arduino pins */
#define ARDUINO_PIN_D0 23
