sjanc commented on code in PR #1773:
URL: https://github.com/apache/mynewt-nimble/pull/1773#discussion_r1593967346


##########
nimble/host/src/ble_gap.c:
##########
@@ -924,6 +923,11 @@ ble_gap_adv_finished(uint8_t instance, int reason, 
uint16_t conn_handle,
     ble_gap_event_listener_call(&event);
 
     ble_gap_slave_extract_cb(instance, &cb, &cb_arg);
+
+    ble_hs_lock();

Review Comment:
   this means that cb extraction and state reset is not longer atomic opration, 
  wouldn't this introduce a race condition?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to