This is an automated email from the ASF dual-hosted git repository.
twolf pushed a commit to branch dev_3.0
in repository https://gitbox.apache.org/repos/asf/mina-sshd.git
commit ba8f228ed30d9bf87aef456aa576e3f27921dd97
Author: Thomas Wolf <tw...@apache.org>
AuthorDate: Wed Apr 23 20:52:10 2025 +0200
[test] Add a test for HttpParser
---
.../sshd/client/session/proxy/HttpParserTest.java | 110 +++++++++++++++++++++
1 file changed, 110 insertions(+)
diff --git
a/sshd-core/src/test/java/org/apache/sshd/client/session/proxy/HttpParserTest.java
b/sshd-core/src/test/java/org/apache/sshd/client/session/proxy/HttpParserTest.java
new file mode 100644
index 000000000..84305ec3a
--- /dev/null
+++
b/sshd-core/src/test/java/org/apache/sshd/client/session/proxy/HttpParserTest.java
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sshd.client.session.proxy;
+
+import java.util.Arrays;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+
+import org.apache.sshd.util.test.JUnitTestSupport;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Basic tests for {@link HttpParser}.
+ */
+class HttpParserTest extends JUnitTestSupport {
+
+ private static final String STATUS_LINE = "HTTP/1.1. 407 Authentication
required";
+
+ @Test
+ void testEmpty() throws Exception {
+ String[] lines = { STATUS_LINE };
+ List<AuthenticationChallenge> challenges =
HttpParser.getAuthenticationHeaders(Arrays.asList(lines),
+ "WWW-Authenticate:");
+ assertTrue(challenges.isEmpty(), "No challenges expected");
+ }
+
+ @Test
+ void testRFC7235Example() throws Exception {
+ // The example from RFC 7235, sec. 4.1, slightly modified ("kind"
argument with whitespace around '=')
+ String[] lines = {
+ STATUS_LINE, //
+ "WWW-Authenticate: Newauth realm=\"apps\", type=1 , kind =
\t2 ",
+ " \t title=\"Login to \\\"apps\\\"\", Basic
realm=\"simple\"" };
+ List<AuthenticationChallenge> challenges =
HttpParser.getAuthenticationHeaders(Arrays.asList(lines),
+ "WWW-Authenticate:");
+ assertEquals(2, challenges.size(), "Unexpected number of challenges");
+ assertNull(challenges.get(0).getToken(), "No token expected");
+ assertNull(challenges.get(1).getToken(), "No token expected");
+ assertEquals("Newauth", challenges.get(0).getMechanism(), "Unexpected
mechanism");
+ assertEquals("Basic", challenges.get(1).getMechanism(), "Unexpected
mechanism");
+ Map<String, String> expectedArguments = new LinkedHashMap<>();
+ expectedArguments.put("realm", "apps");
+ expectedArguments.put("type", "1");
+ expectedArguments.put("kind", "2");
+ expectedArguments.put("title", "Login to \"apps\"");
+ assertEquals(expectedArguments, challenges.get(0).getArguments(),
"Unexpected arguments");
+ expectedArguments.clear();
+ expectedArguments.put("realm", "simple");
+ assertEquals(expectedArguments, challenges.get(1).getArguments(),
"Unexpected arguments");
+ }
+
+ @Test
+ void testMultipleHeaders() {
+ String[] lines = {
+ STATUS_LINE, //
+ "Server: Apache", //
+ "WWW-Authenticate: Newauth realm=\"apps\", type=1 , kind =
\t2 ",
+ " \t title=\"Login to \\\"apps\\\"\", Basic
realm=\"simple\"", //
+ "Content-Type: text/plain", //
+ "WWW-Authenticate: Other 0123456789=== , YetAnother, ", //
+ "WWW-Authenticate: Negotiate ",
+ "WWW-Authenticate: Negotiate a87421000492aa874209af8bc028" };
+ List<AuthenticationChallenge> challenges =
HttpParser.getAuthenticationHeaders(Arrays.asList(lines),
+ "WWW-Authenticate:");
+ assertEquals(6, challenges.size(), "Unexpected number of challenges");
+ assertEquals("Other", challenges.get(2).getMechanism(), "Mismatched
challenge");
+ assertEquals("0123456789===", challenges.get(2).getToken(), "Token
expected");
+ assertEquals("YetAnother", challenges.get(3).getMechanism(),
"Mismatched challenge");
+ assertNull(challenges.get(3).getToken(), "No token expected");
+ assertTrue(challenges.get(3).getArguments().isEmpty(), "No arguments
expected");
+ assertEquals("Negotiate", challenges.get(4).getMechanism(),
"Mismatched challenge");
+ assertNull(challenges.get(4).getToken(), "No token expected");
+ assertEquals("Negotiate", challenges.get(5).getMechanism(),
"Mismatched challenge");
+ assertEquals("a87421000492aa874209af8bc028",
challenges.get(5).getToken(), "Token expected");
+ }
+
+ @Test
+ void testStopOnEmptyLine() {
+ String[] lines = {
+ STATUS_LINE, //
+ "Server: Apache", //
+ "WWW-Authenticate: Newauth realm=\"apps\", type=1 , kind =
\t2 ",
+ " \t title=\"Login to \\\"apps\\\"\", Basic
realm=\"simple\"", //
+ "Content-Type: text/plain",
+ "WWW-Authenticate: Other 0123456789===", "",
+ // Not headers anymore; this would be the body
+ "WWW-Authenticate: Negotiate ", //
+ "WWW-Authenticate: Negotiate a87421000492aa874209af8bc028" };
+ List<AuthenticationChallenge> challenges =
HttpParser.getAuthenticationHeaders(Arrays.asList(lines),
+ "WWW-Authenticate:");
+ assertEquals(3, challenges.size(), "Unexpected number of challenges");
+ }
+}
