This is an automated email from the ASF dual-hosted git repository. twolf pushed a change to branch dev_3.0 in repository https://gitbox.apache.org/repos/asf/mina-sshd.git
from c3d308d8d Fix images in docu and build name new 5296c7bef Massively reduce number of warnings from test code new e834655d7 Remove deprecated CoreModuleProperties new 7d75e1a3a Fix typos in documentation add 67768dcaf Bump io.netty:netty-bom from 4.1.119.Final to 4.2.0.Final (#719) new c6fe99d08 Merge branch 'master' into 3.0.0 The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.md | 2 +- docs/technical/filters.md | 2 +- .../password/PasswordIdentityProviderTest.java | 7 +- .../hosts/ConfigFileHostEntryResolverTest.java | 12 +-- .../client/config/hosts/HostConfigEntryTest.java | 8 +- .../config/hosts/KnownHostHashEntryTest.java | 37 ++----- .../config/hosts/KnownHostHashValueTest.java | 42 ++------ .../keys/BuiltinClientIdentitiesWatcherTest.java | 10 +- .../config/keys/ClientIdentityFileWatcherTest.java | 9 +- .../client/config/keys/ClientIdentityTest.java | 9 +- .../keys/LazyClientIdentityIteratorTest.java | 9 +- .../common/PropertyResolverCommonValuesTest.java | 7 +- .../common/PropertyResolverParseBooleanTest.java | 22 +--- .../java/org/apache/sshd/common/PropertyTest.java | 39 +++---- .../org/apache/sshd/common/SshConstantsTest.java | 8 +- .../apache/sshd/common/VersionPropertiesTest.java | 7 +- .../apache/sshd/common/channel/PtyModeTest.java | 8 +- .../sshd/common/channel/PtyModeValueTest.java | 34 ++---- .../sshd/common/channel/SttySupportTest.java | 19 +--- .../common/cipher/BaseAuthenticatedCipherTest.java | 6 +- .../sshd/common/cipher/BaseCipherResetTest.java | 26 ++--- .../apache/sshd/common/cipher/BaseCipherTest.java | 5 +- .../sshd/common/cipher/ChaCha20CipherTest.java | 5 +- .../apache/sshd/common/cipher/ECCurvesTest.java | 9 +- .../compression/BuiltinCompressionsTest.java | 13 +-- .../sshd/common/config/TimeValueConfigTest.java | 7 +- .../AuthorizedKeyEntryLoginOptionsParseTest.java | 31 +----- .../common/config/keys/BuiltinIdentitiesTest.java | 37 ++----- .../keys/EcdsaPublicKeyEntryDecoderTest.java | 24 ++--- .../sshd/common/config/keys/KeyRandomArtTest.java | 23 +--- .../sshd/common/config/keys/KeyUtilsCloneTest.java | 44 +++----- .../KeyUtilsFingerprintCaseSensitivityTest.java | 17 +-- .../keys/KeyUtilsFingerprintGenerationTest.java | 18 +--- .../sshd/common/config/keys/KeyUtilsTest.java | 10 +- .../config/keys/OpenSshCertificateValuesTest.java | 33 +++--- .../common/config/keys/PublicKeyEntryTest.java | 8 +- .../keys/loader/AESPrivateKeyObfuscatorTest.java | 25 +---- .../OpenSSHKeyPairResourceParserAEADTest.java | 17 +-- .../OpenSSHKeyPairResourceParserDecodingTest.java | 23 ++-- .../OpenSSHKeyPairResourceParserPasswordTest.java | 17 +-- .../OpenSSHKeyPairResourceParserTestSupport.java | 5 +- .../openssh/OpenSSHMaxBCryptRoundsSettingTest.java | 14 +-- .../pem/PKCS8PEMResourceKeyPairParserTest.java | 31 ++---- .../Ssh2PublicKeyEntryDecoderByKeyTypeTest.java | 62 +++-------- .../loader/ssh2/Ssh2PublicKeyEntryDecoderTest.java | 7 +- .../openssh/OpenSSHKeyPairResourceWriterTest.java | 102 ++++++++---------- .../sshd/common/digest/BuiltinDigestsTest.java | 9 +- .../file/nonefs/NoneFileSystemFactoryTest.java | 8 +- .../sshd/common/file/root/AssertableFile.java | 2 - .../file/root/RootedFileSystemProviderTest.java | 11 +- .../apache/sshd/common/file/util/BasePathTest.java | 55 ++++------ .../sshd/common/future/DefaultSshFutureTest.java | 8 +- .../sshd/common/kex/KexProposalOptionTest.java | 10 +- .../KeyIdentityProviderResolutionTest.java | 15 +-- .../common/keyprovider/KeyPairProviderTest.java | 9 +- .../keyprovider/MultiKeyIdentityProviderTest.java | 10 +- .../apache/sshd/common/mac/BuiltinMacsTest.java | 12 +-- .../org/apache/sshd/common/mac/MacVectorsTest.java | 11 +- .../sshd/common/random/RandomFactoryTest.java | 12 +-- .../common/signature/BuiltinSignaturesTest.java | 10 +- .../common/signature/RSASignatureVariantsTest.java | 4 +- .../sshd/common/signature/SignatureDSATest.java | 7 +- .../common/signature/SignatureRSASHA1Test.java | 10 +- .../common/signature/SignatureSkECDSATest.java | 6 +- .../common/signature/SignatureSkED25519Test.java | 6 +- .../signature/SignatureVariantTestSupport.java | 4 +- .../sshd/common/util/EventListenerUtilsTest.java | 10 +- .../common/util/ExceptionUtilsAndroidPeelTest.java | 18 +--- .../apache/sshd/common/util/GenericUtilsTest.java | 11 +- .../sshd/common/util/Int2IntFunctionTest.java | 9 +- .../apache/sshd/common/util/NumberUtilsTest.java | 11 +- .../org/apache/sshd/common/util/OsUtilsTest.java | 8 +- .../sshd/common/util/PathsConcatentionTest.java | 62 ++++------- .../apache/sshd/common/util/SelectorUtilsTest.java | 8 +- .../apache/sshd/common/util/ThreadUtilsTest.java | 11 +- .../apache/sshd/common/util/ValidateUtilsTest.java | 14 ++- .../apache/sshd/common/util/VersionInfoTest.java | 7 +- .../apache/sshd/common/util/buffer/BufferTest.java | 9 +- .../sshd/common/util/buffer/BufferUtilsTest.java | 9 +- .../common/util/closeable/CloseableUtilsTest.java | 9 +- .../util/helper/LazyIterablesConcatenatorTest.java | 5 +- .../util/helper/LazyMatchingTypeIteratorTest.java | 8 +- .../sshd/common/util/io/DirectoryScannerTest.java | 5 +- .../apache/sshd/common/util/io/IoUtilsTest.java | 15 +-- .../common/util/io/ModifiableFileWatcherTest.java | 12 +-- .../apache/sshd/common/util/io/PathUtilsTest.java | 8 +- .../sshd/common/util/io/der/ASN1ClassTest.java | 17 +-- .../sshd/common/util/io/der/ASN1TypeTest.java | 21 ++-- .../sshd/common/util/io/der/DERParserTest.java | 7 +- .../sshd/common/util/io/der/DERWriterTest.java | 7 +- .../common/util/io/input/EmptyInputStreamTest.java | 10 +- .../common/util/io/input/LimitInputStreamTest.java | 12 +-- .../util/io/input/NoCloseInputStreamTest.java | 7 +- .../common/util/io/input/NoCloseReaderTest.java | 8 +- .../common/util/io/input/NullInputStreamTest.java | 10 +- .../util/io/output/LineOutputStreamTest.java | 19 +--- .../util/io/output/NoCloseOutputStreamTest.java | 7 +- .../common/util/io/output/NoCloseWriterTest.java | 7 +- .../util/io/output/NullOutputStreamTest.java | 8 +- .../common/util/net/SshdSocketIpv6AddressTest.java | 24 +---- .../SecurityProviderRegistrarCipherNameTest.java | 12 +-- .../SecurityProviderRegistrarTestSupport.java | 3 +- .../SecurityUtilsDHGEXGroupKeySizeTest.java | 21 +--- .../common/util/security/SecurityUtilsTest.java | 11 +- .../BouncyCastleGeneratorHostKeyProviderTest.java | 22 +--- .../util/security/eddsa/EDDSAProviderTest.java | 9 +- .../util/security/eddsa/Ed25519VectorsTest.java | 21 ++-- .../eddsa/EdDSASecurityProviderRegistrarTest.java | 9 +- .../AbstractGeneratorHostKeyProviderTest.java | 12 +-- .../PEMGeneratorHostKeyProviderTest.java | 8 +- .../SimpleGeneratorHostKeyProviderTest.java | 6 +- .../server/shell/TtyFilterInputStreamTest.java | 27 +---- .../server/shell/TtyFilterOutputStreamTest.java | 21 +--- .../InteractivePasswordIdentityProviderTest.java | 9 +- .../ThrottlingChannelStreamWriterTest.java | 11 +- .../common/signature/LegacyDSASignerTest.java | 24 ++--- .../SimpleAccessControlScpEventListenerTest.java | 8 +- .../SimpleAccessControlSftpEventListenerTest.java | 10 +- .../client/config/SshClientConfigFileReader.java | 16 +-- .../client/session/ClientConnectionService.java | 39 +------ .../common/session/helpers/AbstractSession.java | 13 +-- .../org/apache/sshd/core/CoreModuleProperties.java | 19 ---- .../org/apache/sshd/DefaultSetupTestSupport.java | 4 - .../test/java/org/apache/sshd/KeepAliveTest.java | 14 ++- .../src/test/java/org/apache/sshd/LoadTest.java | 7 +- .../src/test/java/org/apache/sshd/ProxyTest.java | 12 +-- .../java/org/apache/sshd/WindowAdjustTest.java | 18 ++-- .../test/java/org/apache/sshd/agent/AgentTest.java | 20 ++-- .../java/org/apache/sshd/agent/AgentUnitTest.java | 19 +--- .../GenerateOpenSSHClientCertificateTest.java | 34 ++---- ...GenerateOpenSshClientCertificateOracleTest.java | 38 +++---- .../certificates/OpenSSHCertificateParserTest.java | 24 ++--- .../org/apache/sshd/client/ClientDeadlockTest.java | 7 +- .../sshd/client/ClientSessionListenerTest.java | 9 +- .../java/org/apache/sshd/client/ProxyTest.java | 9 +- .../client/auth/BuiltinUserAuthFactoriesTest.java | 21 +--- .../auth/pubkey/RSAVariantsAuthPublicKeyTest.java | 23 +--- .../sshd/client/channel/ChannelExecTest.java | 6 +- .../config/hosts/HostConfigEntryResolverTest.java | 8 +- .../java/org/apache/sshd/client/kex/KexTest.java | 18 +--- .../keyverifier/StaticServerKeyVerifierTest.java | 7 +- .../sshd/client/session/ClientSessionTest.java | 10 +- .../client/simple/SimpleSessionClientTest.java | 9 +- .../org/apache/sshd/common/AttributeStoreTest.java | 8 +- .../sshd/common/PropertyResolverUtilsTest.java | 64 ++++-------- .../org/apache/sshd/common/SshBuilderTest.java | 8 +- .../common/auth/AuthenticationTestSupport.java | 4 - .../common/auth/HostBasedAuthenticationTest.java | 8 +- .../KeyboardInteractiveAuthenticationTest.java | 8 +- .../common/auth/PasswordAuthenticationTest.java | 11 +- .../common/auth/PublicKeyAuthenticationTest.java | 5 +- .../sshd/common/auth/SinglePublicKeyAuthTest.java | 14 +-- .../channel/ChannelAsyncOutputStreamTest.java | 6 +- .../channel/ChannelPipedInputStreamTest.java | 9 +- .../channel/ChannelPipedOutputStreamTest.java | 10 +- .../apache/sshd/common/channel/WindowInitTest.java | 17 +-- .../org/apache/sshd/common/channel/WindowTest.java | 36 ++----- .../sshd/common/channel/WindowTimeoutTest.java | 13 +-- .../sshd/common/cipher/BuiltinCiphersTest.java | 14 +-- .../org/apache/sshd/common/cipher/CipherTest.java | 24 +---- .../sshd/common/cipher/OpenSshCipherTest.java | 25 ++--- .../common/config/SshConfigFileReaderTest.java | 13 +-- .../common/config/keys/AuthorizedKeyEntryTest.java | 10 +- .../forward/AbstractServerCloseTestSupport.java | 3 - .../forward/ApacheServerApacheClientTest.java | 6 +- .../common/forward/ApacheServerJSchClientTest.java | 4 +- .../common/forward/ConcurrentConnectionTest.java | 7 +- ...calForwardingEntryCombinedBoundAddressTest.java | 34 ++---- .../common/forward/LocalForwardingEntryTest.java | 9 +- .../sshd/common/forward/NoServerNoClientTest.java | 4 +- .../common/forward/PortForwardingLoadTest.java | 9 +- .../sshd/common/forward/PortForwardingTest.java | 13 +-- .../forward/PortForwardingWithOpenSshTest.java | 16 +-- .../apache/sshd/common/forward/Sshd1033Test.java | 9 +- .../common/global/OpenSshHostKeysHandlerTest.java | 4 +- .../io/BuiltinIoServiceFactoryFactoriesTest.java | 9 +- .../io/DefaultIoServiceFactoryFactoryTest.java | 7 +- .../sshd/common/io/nio2/Nio2ServiceTest.java | 7 +- .../org/apache/sshd/common/kex/AbstractDHTest.java | 9 +- .../sshd/common/kex/BuiltinDHFactoriesTest.java | 14 +-- .../sshd/common/kex/DHGroupDataParseTest.java | 24 +---- .../sshd/common/kex/KexFactoryManagerTest.java | 8 +- .../apache/sshd/common/kex/KeyExchangeTest.java | 8 +- .../kex/extension/KexExtensionHandlerTest.java | 8 +- .../extension/StrictKexInteroperabilityTest.java | 4 +- .../FileHostKeyCertificateProviderTest.java | 7 +- .../apache/sshd/common/mac/EncryptThenMacTest.java | 18 +--- .../sshd/common/mac/MacCompatibilityTest.java | 13 +-- .../sshd/common/session/GlobalRequestTest.java | 9 +- .../ReservedSessionMessagesHandlerTest.java | 19 ++-- .../common/signature/OpenSSHCertificateTest.java | 12 +-- .../common/signature/SignatureFactoriesTest.java | 11 +- .../sshd/server/PasswordAuthenticatorTest.java | 7 +- .../sshd/server/PublickeyAuthenticatorTest.java | 7 +- .../server/ServerAuthenticationManagerTest.java | 9 +- .../apache/sshd/server/ServerDefaultSetupTest.java | 5 +- .../sshd/server/ServerSessionListenerTest.java | 9 +- .../java/org/apache/sshd/server/ServerTest.java | 20 ++-- .../java/org/apache/sshd/server/SshServerTest.java | 9 +- .../sshd/server/StandardEnvironmentTest.java | 7 +- .../apache/sshd/server/auth/AsyncAuthTestBase.java | 4 - .../server/auth/BuiltinUserAuthFactoriesTest.java | 25 ++--- .../sshd/server/auth/WelcomeBannerPhaseTest.java | 20 +--- .../apache/sshd/server/auth/WelcomeBannerTest.java | 10 +- .../sshd/server/channel/ChannelSessionTest.java | 8 +- .../server/command/CommandFactorySplitterTest.java | 19 +--- .../keys/AuthorizedKeysAuthenticatorTest.java | 10 +- .../DefaultAuthorizedKeysAuthenticatorTest.java | 5 +- .../server/config/keys/ServerIdentityTest.java | 9 +- .../sshd/server/forward/ForwardingFilterTest.java | 8 +- .../server/jaas/JaasPasswordAuthenticatorTest.java | 10 +- .../org/apache/sshd/server/kex/ModuliTest.java | 9 +- .../server/shell/InvertedShellWrapperTest.java | 7 +- .../org/apache/sshd/spring/SpringConfigTest.java | 4 +- .../apache/sshd/git/pack/GitPackCommandTest.java | 9 +- .../org/apache/sshd/git/pgm/GitPgmCommandTest.java | 9 +- .../sshd/ldap/LdapPasswordAuthenticatorTest.java | 7 +- .../sshd/ldap/LdapPublickeyAuthenticatorTest.java | 7 +- sshd-netty/pom.xml | 2 +- .../sshd/openpgp/PGPKeyPairResourceParserTest.java | 16 +-- .../sshd/openpgp/PGPPublicRingWatcherTest.java | 7 +- .../sshd/openpgp/PGPUtilsKeyFingerprintTest.java | 26 ++--- .../sshd/putty/AbstractPuttyTestSupport.java | 5 +- .../org/apache/sshd/putty/PuttyKeyUtilsTest.java | 22 ++-- .../apache/sshd/putty/PuttySpecialKeysTest.java | 5 +- .../org/apache/sshd/scp/client/ScpCharsetTest.java | 7 +- .../client/ScpRemote2RemoteTransferHelperTest.java | 15 +-- .../java/org/apache/sshd/scp/client/ScpTest.java | 12 +-- .../sshd/scp/client/SimpleScpClientTest.java | 8 +- .../sshd/scp/common/ScpLocationParsingTest.java | 51 +++------ .../helpers/AbstractScpCommandDetailsTest.java | 45 +++----- .../sshd/scp/server/ScpCommandFactoryTest.java | 10 +- .../server/ScpReceiveDirCommandDetailsTest.java | 8 +- .../sftp/client/AbstractSftpClientTestSupport.java | 3 - .../org/apache/sshd/sftp/client/ClientTest.java | 19 ++-- .../sftp/client/DefaultCloseableHandleTest.java | 9 +- .../java/org/apache/sshd/sftp/client/SftpTest.java | 78 +++++++------- .../apache/sshd/sftp/client/SftpTransferTest.java | 24 ++--- .../sshd/sftp/client/SftpVersionResolverTest.java | 63 ++++------- .../sshd/sftp/client/SftpVersionSelectorTest.java | 8 +- .../apache/sshd/sftp/client/SftpVersionsTest.java | 116 ++++++++------------- .../sshd/sftp/client/SimpleSftpClientTest.java | 11 +- .../BuiltinSftpClientExtensionsTest.java | 9 +- .../sftp/client/extensions/SftpExtensionsTest.java | 8 +- .../sftp/client/extensions/VersionParserTest.java | 5 +- .../helpers/AbstractCheckFileExtensionTest.java | 39 ++----- .../helpers/AbstractMD5HashExtensionTest.java | 43 ++------ .../helpers/CopyDataExtensionImplTest.java | 23 +--- .../helpers/CopyFileExtensionImplTest.java | 10 +- .../helpers/SpaceAvailableExtensionImplTest.java | 7 +- .../openssh/helpers/OpenSSHExtensionsTest.java | 9 +- .../client/fs/AbstractSftpFilesSystemSupport.java | 10 +- .../sftp/client/fs/SftpDirectoryScannersTest.java | 11 +- .../sshd/sftp/client/fs/SftpFileSystemTest.java | 15 +-- .../sshd/sftp/client/fs/SftpFileSystemURITest.java | 35 +------ .../client/impl/SftpRemotePathChannelTest.java | 10 +- .../apache/sshd/sftp/common/SftpConstantsTest.java | 8 +- .../apache/sshd/sftp/common/SftpHelperTest.java | 6 +- .../common/SftpUniversalOwnerAndGroupTest.java | 11 +- .../apache/sshd/sftp/server/SftpServerTest.java | 8 +- .../sshd/sftp/server/SftpSubsystemFactoryTest.java | 9 +- .../ApacheSshdSftpSessionFactoryTest.java | 9 +- 262 files changed, 1133 insertions(+), 2777 deletions(-)