This is an automated email from the ASF dual-hosted git repository. twolf pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mina-sshd.git
from df83bf315 Update README and CHANGES add a9504ba8f Switch to JUnit 5 No new revisions were added by this update. Summary of changes: pom.xml | 38 +- sshd-benchmarks/pom.xml | 9 - .../sshd/benchmarks/sftp/upload/CatBenchmark.java | 4 +- sshd-checkstyle-suppressions.xml | 5 + sshd-cli/pom.xml | 11 +- .../CliSupportSplitCommandLineArgumentsTest.java | 38 +- sshd-common/pom.xml | 14 +- .../password/PasswordIdentityProviderTest.java | 19 +- .../hosts/ConfigFileHostEntryResolverTest.java | 45 +- .../client/config/hosts/HostConfigEntryTest.java | 139 ++--- .../config/hosts/KnownHostHashEntryTest.java | 58 ++- .../config/hosts/KnownHostHashValueTest.java | 66 +-- .../keys/BuiltinClientIdentitiesWatcherTest.java | 30 +- .../config/keys/ClientIdentityFileWatcherTest.java | 25 +- .../client/config/keys/ClientIdentityTest.java | 29 +- .../keys/LazyClientIdentityIteratorTest.java | 22 +- .../common/PropertyResolverCommonValuesTest.java | 19 +- .../common/PropertyResolverParseBooleanTest.java | 44 +- .../java/org/apache/sshd/common/PropertyTest.java | 72 +-- .../org/apache/sshd/common/SshConstantsTest.java | 41 +- .../apache/sshd/common/VersionPropertiesTest.java | 19 +- .../apache/sshd/common/channel/PtyModeTest.java | 24 +- .../sshd/common/channel/PtyModeValueTest.java | 60 ++- .../sshd/common/channel/SttySupportTest.java | 32 +- .../apache/sshd/common/cipher/AES128GCMTest.java | 4 +- .../apache/sshd/common/cipher/AES192CTRTest.java | 10 +- .../apache/sshd/common/cipher/AES256CBCTest.java | 10 +- .../apache/sshd/common/cipher/AES256GCMTest.java | 4 +- .../apache/sshd/common/cipher/ARCFOUR128Test.java | 10 +- .../apache/sshd/common/cipher/ARCFOUR256Test.java | 10 +- .../common/cipher/BaseAuthenticatedCipherTest.java | 4 + .../sshd/common/cipher/BaseCipherResetTest.java | 58 +-- .../apache/sshd/common/cipher/BaseCipherTest.java | 21 +- .../sshd/common/cipher/ChaCha20CipherTest.java | 6 +- .../apache/sshd/common/cipher/ECCurvesTest.java | 45 +- .../compression/BuiltinCompressionsTest.java | 75 +-- .../sshd/common/config/TimeValueConfigTest.java | 19 +- .../AuthorizedKeyEntryLoginOptionsParseTest.java | 60 +-- .../common/config/keys/BuiltinIdentitiesTest.java | 83 +-- .../keys/EcdsaPublicKeyEntryDecoderTest.java | 36 +- .../sshd/common/config/keys/KeyRandomArtTest.java | 55 +- .../sshd/common/config/keys/KeyUtilsCloneTest.java | 52 +- .../KeyUtilsFingerprintCaseSensitivityTest.java | 40 +- .../keys/KeyUtilsFingerprintGenerationTest.java | 50 +- .../sshd/common/config/keys/KeyUtilsTest.java | 94 ++-- .../config/keys/OpenSshCertificateValuesTest.java | 30 +- .../common/config/keys/PublicKeyEntryTest.java | 22 +- .../keys/loader/AESPrivateKeyObfuscatorTest.java | 51 +- .../OpenSSHKeyPairResourceParserAEADTest.java | 39 +- .../OpenSSHKeyPairResourceParserDecodingTest.java | 49 +- .../OpenSSHKeyPairResourceParserPasswordTest.java | 69 +-- .../OpenSSHKeyPairResourceParserTestSupport.java | 24 +- .../openssh/OpenSSHMaxBCryptRoundsSettingTest.java | 46 +- .../pem/PKCS8PEMResourceKeyPairParserTest.java | 77 +-- .../Ssh2PublicKeyEntryDecoderByKeyTypeTest.java | 36 +- .../loader/ssh2/Ssh2PublicKeyEntryDecoderTest.java | 23 +- .../openssh/OpenSSHKeyPairResourceWriterTest.java | 184 ++++--- .../sshd/common/digest/BuiltinDigestsTest.java | 27 +- .../file/nonefs/NoneFileSystemFactoryTest.java | 17 +- .../sshd/common/file/root/AssertableFile.java | 14 +- .../file/root/RootedFileSystemProviderTest.java | 205 ++++---- .../apache/sshd/common/file/util/BasePathTest.java | 112 ++-- .../sshd/common/future/DefaultSshFutureTest.java | 56 +- .../sshd/common/kex/KexProposalOptionTest.java | 46 +- .../KeyIdentityProviderResolutionTest.java | 39 +- .../common/keyprovider/KeyPairProviderTest.java | 29 +- .../keyprovider/MultiKeyIdentityProviderTest.java | 26 +- .../apache/sshd/common/mac/BuiltinMacsTest.java | 78 +-- .../org/apache/sshd/common/mac/MacVectorsTest.java | 45 +- .../sshd/common/random/RandomFactoryTest.java | 36 +- .../common/signature/BuiltinSignaturesTest.java | 70 +-- .../common/signature/RSASignatureVariantsTest.java | 42 +- .../sshd/common/signature/SignatureDSATest.java | 17 +- .../common/signature/SignatureRSASHA1Test.java | 51 +- .../common/signature/SignatureSkECDSATest.java | 23 +- .../common/signature/SignatureSkED25519Test.java | 23 +- .../signature/SignatureVariantTestSupport.java | 25 +- .../common/signature/SignaturesDevelopment.java | 4 +- .../sshd/common/util/EventListenerUtilsTest.java | 58 ++- .../common/util/ExceptionUtilsAndroidPeelTest.java | 34 +- .../apache/sshd/common/util/GenericUtilsTest.java | 91 ++-- .../sshd/common/util/Int2IntFunctionTest.java | 51 +- .../apache/sshd/common/util/NumberUtilsTest.java | 47 +- .../org/apache/sshd/common/util/OsUtilsTest.java | 36 +- .../sshd/common/util/PathsConcatentionTest.java | 38 +- .../apache/sshd/common/util/SelectorUtilsTest.java | 50 +- .../apache/sshd/common/util/ThreadUtilsTest.java | 39 +- .../apache/sshd/common/util/ValidateUtilsTest.java | 25 +- .../apache/sshd/common/util/VersionInfoTest.java | 23 +- .../apache/sshd/common/util/buffer/BufferTest.java | 49 +- .../sshd/common/util/buffer/BufferUtilsTest.java | 31 +- .../common/util/closeable/CloseableUtilsTest.java | 29 +- .../util/helper/LazyIterablesConcatenatorTest.java | 10 +- .../util/helper/LazyMatchingTypeIteratorTest.java | 17 +- .../sshd/common/util/io/DirectoryScannerTest.java | 17 +- .../apache/sshd/common/util/io/IoUtilsTest.java | 59 ++- .../common/util/io/ModifiableFileWatcherTest.java | 128 ++--- .../apache/sshd/common/util/io/PathUtilsTest.java | 24 +- .../sshd/common/util/io/der/ASN1ClassTest.java | 42 +- .../sshd/common/util/io/der/ASN1TypeTest.java | 42 +- .../sshd/common/util/io/der/DERParserTest.java | 17 +- .../sshd/common/util/io/der/DERWriterTest.java | 17 +- .../common/util/io/input/EmptyInputStreamTest.java | 60 ++- .../common/util/io/input/LimitInputStreamTest.java | 42 +- .../util/io/input/NoCloseInputStreamTest.java | 22 +- .../common/util/io/input/NoCloseReaderTest.java | 22 +- .../common/util/io/input/NullInputStreamTest.java | 34 +- .../util/io/output/LineOutputStreamTest.java | 32 +- .../util/io/output/NoCloseOutputStreamTest.java | 17 +- .../common/util/io/output/NoCloseWriterTest.java | 17 +- .../util/io/output/NullOutputStreamTest.java | 31 +- .../common/util/net/SshdSocketIpv6AddressTest.java | 34 +- .../SecurityProviderRegistrarCipherNameTest.java | 36 +- .../SecurityProviderRegistrarTestSupport.java | 4 +- .../SecurityUtilsDHGEXGroupKeySizeTest.java | 79 +-- .../common/util/security/SecurityUtilsTest.java | 64 +-- .../util/security/SecurityUtilsTestSupport.java | 8 +- .../BouncyCastleGeneratorHostKeyProviderTest.java | 41 +- .../util/security/eddsa/EDDSAProviderTest.java | 69 +-- .../util/security/eddsa/Ed25519VectorsTest.java | 88 ++-- .../eddsa/EdDSASecurityProviderRegistrarTest.java | 41 +- .../AbstractGeneratorHostKeyProviderTest.java | 21 +- .../PEMGeneratorHostKeyProviderTest.java | 56 +- .../SimpleGeneratorHostKeyProviderTest.java | 60 +-- .../server/shell/TtyFilterInputStreamTest.java | 61 +-- .../server/shell/TtyFilterOutputStreamTest.java | 54 +- .../util/test/JUnit4ClassRunnerWithParameters.java | 48 -- .../JUnit4ClassRunnerWithParametersFactory.java | 60 --- .../util/test/JUnit4SingleInstanceClassRunner.java | 54 -- .../apache/sshd/util/test/JUnitTestSupport.java | 112 ++-- ...txt => readGlobalHostsConfigEntries.config.txt} | 0 ...fig.txt => readMultipleHostPatterns.config.txt} | 0 ...txt => readSimpleHostsConfigEntries.config.txt} | 0 sshd-contrib/pom.xml | 14 +- .../InteractivePasswordIdentityProviderTest.java | 33 +- .../ThrottlingChannelStreamWriterTest.java | 87 ++-- .../common/signature/LegacyDSASignerTest.java | 62 +-- .../SimpleAccessControlScpEventListenerTest.java | 27 +- .../ProxyProtocolV2AcceptorTest.java | 44 +- .../SimpleAccessControlSftpEventListenerTest.java | 48 +- sshd-core/pom.xml | 17 +- .../org/apache/sshd/DefaultSetupTestSupport.java | 37 +- .../test/java/org/apache/sshd/KeepAliveTest.java | 76 +-- .../java/org/apache/sshd/KeyReExchangeTest.java | 90 ++-- .../src/test/java/org/apache/sshd/LoadTest.java | 33 +- .../src/test/java/org/apache/sshd/ProxyTest.java | 61 ++- .../java/org/apache/sshd/WindowAdjustTest.java | 33 +- .../test/java/org/apache/sshd/agent/AgentTest.java | 39 +- .../java/org/apache/sshd/agent/AgentUnitTest.java | 27 +- .../GenerateOpenSSHClientCertificateTest.java | 37 +- ...GenerateOpenSshClientCertificateOracleTest.java | 37 +- .../certificates/OpenSSHCertificateParserTest.java | 33 +- .../client/ClientAuthenticationManagerTest.java | 52 +- .../org/apache/sshd/client/ClientDeadlockTest.java | 29 +- .../apache/sshd/client/ClientDefaultSetupTest.java | 6 +- .../sshd/client/ClientSessionListenerTest.java | 43 +- .../java/org/apache/sshd/client/ClientTest.java | 504 +++++++++--------- .../java/org/apache/sshd/client/ProxyTest.java | 46 +- .../client/auth/BuiltinUserAuthFactoriesTest.java | 74 +-- .../auth/pubkey/HostBoundPubKeyAuthTest.java | 32 +- .../client/auth/pubkey/InvalidRsaKeyAuthTest.java | 16 +- .../sshd/client/auth/pubkey/MultiAuthTest.java | 24 +- .../auth/pubkey/RSAVariantsAuthPublicKeyTest.java | 49 +- .../sshd/client/channel/ChannelExecTest.java | 33 +- .../config/hosts/HostConfigEntryResolverTest.java | 42 +- .../java/org/apache/sshd/client/kex/KexTest.java | 50 +- .../KnownHostsServerKeyVerifierTest.java | 137 ++--- .../keyverifier/StaticServerKeyVerifierTest.java | 21 +- .../ClientOpenSSHCertificatesTest.java | 35 +- .../sshd/client/session/ClientSessionTest.java | 124 +++-- .../client/simple/SimpleSessionClientTest.java | 31 +- .../org/apache/sshd/common/AttributeStoreTest.java | 51 +- .../sshd/common/PropertyResolverUtilsTest.java | 93 ++-- .../org/apache/sshd/common/SshBuilderTest.java | 28 +- .../sshd/common/auth/AuthenticationTest.java | 50 +- .../common/auth/AuthenticationTestSupport.java | 20 +- .../common/auth/HostBasedAuthenticationTest.java | 27 +- .../KeyboardInteractiveAuthenticationTest.java | 74 +-- .../common/auth/PasswordAuthenticationTest.java | 105 ++-- .../common/auth/PublicKeyAuthenticationTest.java | 81 +-- .../sshd/common/auth/SinglePublicKeyAuthTest.java | 64 +-- .../channel/ChannelAsyncOutputStreamTest.java | 29 +- .../channel/ChannelPipedInputStreamTest.java | 35 +- .../channel/ChannelPipedOutputStreamTest.java | 36 +- .../apache/sshd/common/channel/WindowInitTest.java | 32 +- .../org/apache/sshd/common/channel/WindowTest.java | 53 +- .../sshd/common/channel/WindowTimeoutTest.java | 50 +- .../sshd/common/cipher/BuiltinCiphersTest.java | 99 ++-- .../org/apache/sshd/common/cipher/CipherTest.java | 71 +-- .../sshd/common/cipher/OpenSshCipherTest.java | 47 +- .../sshd/common/compression/CompressionTest.java | 101 ++-- .../common/config/SshConfigFileReaderTest.java | 174 ++++--- .../common/config/keys/AuthorizedKeyEntryTest.java | 43 +- .../config/keys/AuthorizedKeysTestSupport.java | 5 +- .../forward/AbstractServerCloseTestSupport.java | 42 +- .../forward/ApacheServerApacheClientTest.java | 34 +- .../common/forward/ApacheServerJSchClientTest.java | 34 +- .../common/forward/ConcurrentConnectionTest.java | 54 +- ...calForwardingEntryCombinedBoundAddressTest.java | 63 +-- .../common/forward/LocalForwardingEntryTest.java | 38 +- .../sshd/common/forward/NoServerNoClientTest.java | 6 +- .../common/forward/PortForwardingLoadTest.java | 53 +- .../sshd/common/forward/PortForwardingTest.java | 188 +++---- .../forward/PortForwardingWithOpenSshTest.java | 55 +- .../apache/sshd/common/forward/Sshd1033Test.java | 31 +- .../common/global/OpenSshHostKeysHandlerTest.java | 33 +- .../io/BuiltinIoServiceFactoryFactoriesTest.java | 26 +- .../io/DefaultIoServiceFactoryFactoryTest.java | 18 +- .../sshd/common/io/nio2/Nio2ServiceTest.java | 19 +- .../org/apache/sshd/common/kex/AbstractDHTest.java | 26 +- .../sshd/common/kex/BuiltinDHFactoriesTest.java | 86 ++-- .../sshd/common/kex/DHGroupDataParseTest.java | 50 +- .../sshd/common/kex/KexFactoryManagerTest.java | 56 +- .../apache/sshd/common/kex/KeyExchangeTest.java | 27 +- .../kex/extension/KexExtensionHandlerTest.java | 28 +- .../extension/StrictKexInteroperabilityTest.java | 37 +- .../sshd/common/kex/extension/StrictKexTest.java | 68 +-- .../FileHostKeyCertificateProviderTest.java | 13 +- .../apache/sshd/common/mac/EncryptThenMacTest.java | 52 +- .../sshd/common/mac/MacCompatibilityTest.java | 66 +-- .../sshd/common/session/GlobalRequestTest.java | 87 ++-- .../ReservedSessionMessagesHandlerTest.java | 45 +- .../session/helpers/AbstractSessionTest.java | 163 +++--- .../common/signature/OpenSSHCertificateTest.java | 85 +-- .../common/signature/SignatureFactoriesTest.java | 56 +- .../sshd/server/PasswordAuthenticatorTest.java | 21 +- .../sshd/server/PublickeyAuthenticatorTest.java | 21 +- .../server/ServerAuthenticationManagerTest.java | 30 +- .../apache/sshd/server/ServerDefaultSetupTest.java | 6 +- .../sshd/server/ServerProxyAcceptorTest.java | 39 +- .../sshd/server/ServerSessionListenerTest.java | 53 +- .../java/org/apache/sshd/server/ServerTest.java | 226 ++++---- .../java/org/apache/sshd/server/SshServerTest.java | 20 +- .../sshd/server/StandardEnvironmentTest.java | 19 +- .../sshd/server/auth/AsyncAuthInteractiveTest.java | 12 +- .../org/apache/sshd/server/auth/AsyncAuthTest.java | 12 +- .../apache/sshd/server/auth/AsyncAuthTestBase.java | 26 +- .../server/auth/BuiltinUserAuthFactoriesTest.java | 76 +-- .../sshd/server/auth/WelcomeBannerPhaseTest.java | 46 +- .../apache/sshd/server/auth/WelcomeBannerTest.java | 70 +-- .../sshd/server/channel/ChannelSessionTest.java | 69 +-- .../server/command/CommandFactorySplitterTest.java | 34 +- .../keys/AuthorizedKeysAuthenticatorTest.java | 43 +- .../DefaultAuthorizedKeysAuthenticatorTest.java | 10 +- .../server/config/keys/ServerIdentityTest.java | 29 +- .../sshd/server/forward/ForwardingFilterTest.java | 21 +- .../server/jaas/JaasPasswordAuthenticatorTest.java | 36 +- .../org/apache/sshd/server/kex/ModuliTest.java | 51 +- .../server/shell/InvertedShellWrapperTest.java | 43 +- .../org/apache/sshd/spring/SpringConfigTest.java | 28 +- .../org/apache/sshd/util/test/BaseTestSupport.java | 32 +- .../apache/sshd/util/test/TestChannelListener.java | 15 +- .../client/simple/BaseSimpleClientTestSupport.java | 8 +- sshd-git/pom.xml | 11 +- .../apache/sshd/git/pack/GitPackCommandTest.java | 37 +- .../org/apache/sshd/git/pgm/GitPgmCommandTest.java | 17 +- sshd-ldap/pom.xml | 26 +- .../apache/sshd/ldap/BaseAuthenticatorTest.java | 31 +- .../sshd/ldap/LdapPasswordAuthenticatorTest.java | 34 +- .../sshd/ldap/LdapPublickeyAuthenticatorTest.java | 31 +- sshd-mina/pom.xml | 7 +- .../java/org/apache/sshd/mina/MinaSessionTest.java | 20 +- sshd-netty/pom.xml | 12 +- .../test/java/org/apache/sshd/netty/NettyTest.java | 16 +- sshd-openpgp/pom.xml | 18 +- .../sshd/openpgp/PGPKeyPairResourceParserTest.java | 62 +-- .../sshd/openpgp/PGPPublicRingWatcherTest.java | 24 +- .../sshd/openpgp/PGPUtilsKeyFingerprintTest.java | 102 ++-- sshd-putty/pom.xml | 14 +- .../sshd/putty/AbstractPuttyTestSupport.java | 28 +- .../org/apache/sshd/putty/PuttyKeyUtilsTest.java | 102 ++-- .../apache/sshd/putty/PuttySpecialKeysTest.java | 22 +- sshd-scp/pom.xml | 19 +- .../sshd/scp/client/AbstractScpTestSupport.java | 8 +- .../org/apache/sshd/scp/client/ScpCharsetTest.java | 42 +- .../client/ScpRemote2RemoteTransferHelperTest.java | 70 +-- .../java/org/apache/sshd/scp/client/ScpTest.java | 159 +++--- .../sshd/scp/client/SimpleScpClientTest.java | 32 +- .../sshd/scp/common/ScpLocationParsingTest.java | 50 +- .../helpers/AbstractScpCommandDetailsTest.java | 46 +- .../sshd/scp/server/ScpCommandFactoryTest.java | 46 +- .../server/ScpReceiveDirCommandDetailsTest.java | 24 +- sshd-sftp/pom.xml | 17 +- .../sftp/client/AbstractSftpClientTestSupport.java | 17 +- .../org/apache/sshd/sftp/client/ClientTest.java | 80 +-- .../sftp/client/DefaultCloseableHandleTest.java | 31 +- .../sshd/sftp/client/SftpPerformanceTest.java | 10 +- .../java/org/apache/sshd/sftp/client/SftpTest.java | 573 ++++++++++++--------- .../apache/sshd/sftp/client/SftpTransferTest.java | 33 +- .../sshd/sftp/client/SftpVersionResolverTest.java | 53 +- .../sshd/sftp/client/SftpVersionSelectorTest.java | 47 +- .../apache/sshd/sftp/client/SftpVersionsTest.java | 140 ++--- .../sshd/sftp/client/SimpleSftpClientTest.java | 40 +- .../BuiltinSftpClientExtensionsTest.java | 37 +- .../sftp/client/extensions/SftpExtensionsTest.java | 29 +- .../sftp/client/extensions/VersionParserTest.java | 13 +- .../helpers/AbstractCheckFileExtensionTest.java | 52 +- .../helpers/AbstractMD5HashExtensionTest.java | 50 +- .../helpers/CopyDataExtensionImplTest.java | 38 +- .../helpers/CopyFileExtensionImplTest.java | 31 +- .../helpers/SpaceAvailableExtensionImplTest.java | 20 +- .../openssh/helpers/OpenSSHExtensionsTest.java | 39 +- .../client/fs/AbstractSftpFilesSystemSupport.java | 47 +- .../sftp/client/fs/SftpDirectoryScannersTest.java | 97 ++-- .../sshd/sftp/client/fs/SftpFileSystemTest.java | 259 +++++----- .../sshd/sftp/client/fs/SftpFileSystemURITest.java | 67 ++- .../client/impl/SftpRemotePathChannelTest.java | 97 ++-- .../sshd/sftp/client/impl/SftpStatusTest.java | 55 +- .../apache/sshd/sftp/common/SftpConstantsTest.java | 32 +- .../apache/sshd/sftp/common/SftpHelperTest.java | 41 +- .../common/SftpUniversalOwnerAndGroupTest.java | 31 +- .../org/apache/sshd/sftp/server/HandleTest.java | 17 +- .../apache/sshd/sftp/server/SftpServerTest.java | 72 +-- .../sshd/sftp/server/SftpSubsystemFactoryTest.java | 40 +- sshd-spring-sftp/pom.xml | 7 +- .../ApacheSshdSftpSessionFactoryTest.java | 62 ++- 316 files changed, 7988 insertions(+), 7167 deletions(-) delete mode 100644 sshd-common/src/test/java/org/apache/sshd/util/test/JUnit4ClassRunnerWithParameters.java delete mode 100644 sshd-common/src/test/java/org/apache/sshd/util/test/JUnit4ClassRunnerWithParametersFactory.java delete mode 100644 sshd-common/src/test/java/org/apache/sshd/util/test/JUnit4SingleInstanceClassRunner.java rename sshd-common/src/test/resources/org/apache/sshd/client/config/hosts/{testReadGlobalHostsConfigEntries.config.txt => readGlobalHostsConfigEntries.config.txt} (100%) rename sshd-common/src/test/resources/org/apache/sshd/client/config/hosts/{testReadMultipleHostPatterns.config.txt => readMultipleHostPatterns.config.txt} (100%) rename sshd-common/src/test/resources/org/apache/sshd/client/config/hosts/{testReadSimpleHostsConfigEntries.config.txt => readSimpleHostsConfigEntries.config.txt} (100%) copy sshd-common/src/main/java/org/apache/sshd/common/AlgorithmNameProvider.java => sshd-netty/src/test/java/org/apache/sshd/netty/NettyTest.java (81%)