This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mina-ftpserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 339c5cab Use String#isEmpty()
339c5cab is described below

commit 339c5cabe8cc09995fe9c722a446107ab0792dda
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Tue Nov 28 12:33:44 2023 -0500

    Use String#isEmpty()
---
 .../java/org/apache/ftpserver/command/impl/DefaultCommandFactory.java   | 2 +-
 core/src/main/java/org/apache/ftpserver/impl/DefaultFtpRequest.java     | 2 +-
 core/src/main/java/org/apache/ftpserver/util/FileRegularFilter.java     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/core/src/main/java/org/apache/ftpserver/command/impl/DefaultCommandFactory.java
 
b/core/src/main/java/org/apache/ftpserver/command/impl/DefaultCommandFactory.java
index b387e483..53cd01ef 100644
--- 
a/core/src/main/java/org/apache/ftpserver/command/impl/DefaultCommandFactory.java
+++ 
b/core/src/main/java/org/apache/ftpserver/command/impl/DefaultCommandFactory.java
@@ -55,7 +55,7 @@ public class DefaultCommandFactory implements CommandFactory {
      * Get command. Returns null if not found.
      */
     public Command getCommand(final String cmdName) {
-        if (cmdName == null || cmdName.equals("")) {
+        if (cmdName == null || cmdName.isEmpty()) {
             return null;
         }
         String upperCaseCmdName = cmdName.toUpperCase();
diff --git 
a/core/src/main/java/org/apache/ftpserver/impl/DefaultFtpRequest.java 
b/core/src/main/java/org/apache/ftpserver/impl/DefaultFtpRequest.java
index 6f8f9192..93777ccb 100644
--- a/core/src/main/java/org/apache/ftpserver/impl/DefaultFtpRequest.java
+++ b/core/src/main/java/org/apache/ftpserver/impl/DefaultFtpRequest.java
@@ -77,7 +77,7 @@ public class DefaultFtpRequest implements FtpRequest {
         String arg = null;
         if (spInd != -1) {
             arg = line.substring(spInd + 1);
-            if (arg.equals("")) {
+            if (arg.isEmpty()) {
                 arg = null;
             }
         }
diff --git 
a/core/src/main/java/org/apache/ftpserver/util/FileRegularFilter.java 
b/core/src/main/java/org/apache/ftpserver/util/FileRegularFilter.java
index 3a572d26..9fefdb4f 100644
--- a/core/src/main/java/org/apache/ftpserver/util/FileRegularFilter.java
+++ b/core/src/main/java/org/apache/ftpserver/util/FileRegularFilter.java
@@ -40,7 +40,7 @@ public class FileRegularFilter implements FilenameFilter {
      *            regular expression
      */
     public FileRegularFilter(String pattern) {
-        if ((pattern == null) || pattern.equals("") || pattern.equals("*")) {
+        if ((pattern == null) || pattern.isEmpty() || pattern.equals("*")) {
             regularExpr = null;
         } else {
             regularExpr = new RegularExpr(pattern);

Reply via email to