This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mina-asyncweb.git


The following commit(s) were added to refs/heads/master by this push:
     new a530d46  Use String#isEmpty()
a530d46 is described below

commit a530d46ec3ec0912c9c799f22174ab3eeb9905d8
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Tue Nov 28 12:29:56 2023 -0500

    Use String#isEmpty()
---
 client/src/main/java/org/apache/ahc/auth/AuthChallengeParser.java | 2 +-
 client/src/main/java/org/apache/ahc/auth/NTLM.java                | 2 +-
 client/src/main/java/org/apache/ahc/util/ParameterParser.java     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/client/src/main/java/org/apache/ahc/auth/AuthChallengeParser.java 
b/client/src/main/java/org/apache/ahc/auth/AuthChallengeParser.java
index c3269d1..eb29bb2 100644
--- a/client/src/main/java/org/apache/ahc/auth/AuthChallengeParser.java
+++ b/client/src/main/java/org/apache/ahc/auth/AuthChallengeParser.java
@@ -51,7 +51,7 @@ public class AuthChallengeParser {
         } else {
             s = challengeStr.substring(0, idx);
         }
-        if (s.equals("")) {
+        if (s.isEmpty()) {
             throw new MalformedChallengeException("Invalid challenge: " + 
challengeStr);
         }
         return s.toLowerCase();
diff --git a/client/src/main/java/org/apache/ahc/auth/NTLM.java 
b/client/src/main/java/org/apache/ahc/auth/NTLM.java
index 893752e..dd93847 100644
--- a/client/src/main/java/org/apache/ahc/auth/NTLM.java
+++ b/client/src/main/java/org/apache/ahc/auth/NTLM.java
@@ -78,7 +78,7 @@ final class NTLM {
             throws AuthenticationException {
 
         final String response;
-        if (message == null || message.trim().equals("")) {
+        if (message == null || message.trim().isEmpty()) {
             response = getType1Message(host, domain);
         } else {
             response = getType3Message(username, password, host, domain,
diff --git a/client/src/main/java/org/apache/ahc/util/ParameterParser.java 
b/client/src/main/java/org/apache/ahc/util/ParameterParser.java
index 4d46ce0..aa716ae 100644
--- a/client/src/main/java/org/apache/ahc/util/ParameterParser.java
+++ b/client/src/main/java/org/apache/ahc/util/ParameterParser.java
@@ -219,7 +219,7 @@ public class ParameterParser {
             if (hasChar() && (chars[pos] == separator)) {
                 pos++; // skip separator
             }
-            if (paramName != null && !(paramName.equals("") && paramValue == 
null)) {
+            if (paramName != null && !(paramName.isEmpty() && paramValue == 
null)) {
                 params.add(new NameValuePair(paramName, paramValue));
             }
         }

Reply via email to