This is an automated email from the ASF dual-hosted git repository. twolf pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mina-sshd.git
from de72f23cb Manual format fixes for column-aligned "+" operators new 4037290a0 Use ThreadLocal.remove() instead of ThreadLocal.set(null) new b19a3ed0b Fix some SonarLint findings The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../sshd/cli/client/SshClientCliSupport.java | 10 +- .../sshd/cli/server/SshServerCliSupport.java | 3 +- .../server/helper/ServerEventListenerHelper.java | 2 +- .../helper/ServerPortForwardingEventListener.java | 6 +- .../auth/hostbased/HostKeyIdentityProvider.java | 2 +- .../client/config/hosts/KnownHostHashValue.java | 5 +- .../config/keys/ClientIdentitiesWatcher.java | 2 +- .../config/keys/ClientIdentityFileWatcher.java | 4 +- .../client/config/keys/ClientIdentityProvider.java | 6 +- .../config/keys/LazyClientIdentityIterator.java | 23 ++- .../org/apache/sshd/common/channel/PtyMode.java | 13 +- .../sshd/common/config/VersionProperties.java | 4 +- .../apache/sshd/common/config/keys/KeyUtils.java | 2 +- .../keys/impl/AbstractPublicKeyEntryDecoder.java | 2 +- .../openssh/OpenSSHDSSPrivateKeyEntryDecoder.java | 11 +- .../OpenSSHECDSAPrivateKeyEntryDecoder.java | 7 +- .../openssh/OpenSSHRSAPrivateKeyDecoder.java | 14 +- .../sshd/common/file/util/BaseFileSystem.java | 2 +- .../org/apache/sshd/common/file/util/BasePath.java | 2 +- .../sshd/common/io/AbstractIoWriteFuture.java | 8 + .../AbstractResourceKeyPairProvider.java | 8 +- .../common/keyprovider/KeyIdentityProvider.java | 2 +- .../common/keyprovider/MappedKeyPairProvider.java | 4 +- .../java/org/apache/sshd/common/mac/BaseMac.java | 2 +- .../sshd/common/signature/AbstractSignature.java | 2 +- .../apache/sshd/common/signature/SignatureDSA.java | 2 +- .../apache/sshd/common/util/ExceptionUtils.java | 5 +- .../org/apache/sshd/common/util/GenericUtils.java | 6 +- .../org/apache/sshd/common/util/SelectorUtils.java | 14 -- .../org/apache/sshd/common/util/ValidateUtils.java | 20 +-- .../common/util/closeable/FuturesCloseable.java | 4 +- .../common/util/closeable/ParallelCloseable.java | 4 +- .../sshd/common/util/io/PathScanningMatcher.java | 2 +- .../sshd/common/util/security/SecurityUtils.java | 4 +- .../security/bouncycastle/BouncyCastleRandom.java | 2 +- .../security/eddsa/EdDSASecurityProviderUtils.java | 8 +- .../util/security/eddsa/SignatureEd25519.java | 2 +- .../sshd/common/util/threads/ThreadUtils.java | 28 ++-- .../AbstractGeneratorHostKeyProvider.java | 8 +- .../keys/BuiltinClientIdentitiesWatcherTest.java | 2 +- .../openssh/OpenSSHKeyPairResourceWriterTest.java | 4 - .../sshd/util/test/CommonTestSupportUtils.java | 4 +- .../throttle/ThrottlingChannelStreamWriter.java | 2 +- .../contrib/common/signature/LegacyDSASigner.java | 2 +- .../sshd/agent/common/AbstractAgentProxy.java | 2 +- .../apache/sshd/agent/local/AgentServerProxy.java | 6 +- .../org/apache/sshd/agent/unix/AgentServer.java | 2 +- .../apache/sshd/agent/unix/AgentServerProxy.java | 2 +- .../org/apache/sshd/agent/unix/AprLibrary.java | 8 +- .../sshd/agent/unix/ChannelAgentForwarding.java | 2 +- .../sshd/client/future/DefaultConnectFuture.java | 2 +- .../sshd/common/channel/AbstractChannel.java | 22 +-- .../common/channel/BufferedIoOutputStream.java | 16 +- .../common/channel/ChannelAsyncInputStream.java | 4 +- .../sshd/common/forward/DefaultForwarder.java | 173 +++++++-------------- .../io/BuiltinIoServiceFactoryFactories.java | 8 +- .../common/io/DefaultIoServiceFactoryFactory.java | 3 +- .../apache/sshd/common/io/nio2/Nio2Service.java | 6 +- .../sshd/common/kex/dh/AbstractDHKeyExchange.java | 4 +- .../session/helpers/AbstractConnectionService.java | 6 +- .../common/session/helpers/AbstractSession.java | 12 +- .../session/helpers/AbstractSessionIoHandler.java | 6 +- .../session/helpers/KeyExchangeMessageHandler.java | 6 +- .../java/org/apache/sshd/server/SshServer.java | 4 +- .../sshd/server/auth/AsyncAuthException.java | 2 +- .../apache/sshd/server/auth/gss/UserAuthGSS.java | 2 +- ...AuthorizedKeyEntriesPublickeyAuthenticator.java | 6 +- .../auth/pubkey/KeySetPublickeyAuthenticator.java | 4 +- .../sshd/server/channel/PuttyRequestHandler.java | 6 +- .../server/command/AbstractCommandSupport.java | 6 +- .../server/command/AbstractFileSystemCommand.java | 2 +- .../sshd/server/forward/DirectTcpipFactory.java | 2 +- .../sshd/server/forward/ForwardedTcpipFactory.java | 2 +- .../forward/StaticDecisionForwardingFilter.java | 2 +- .../sshd/server/forward/TcpipServerChannel.java | 15 +- .../sshd/server/session/ServerUserAuthService.java | 6 +- .../channel/ChannelPipedInputStreamTest.java | 2 +- .../org/apache/sshd/git/AbstractGitCommand.java | 2 - .../org/apache/sshd/git/pack/GitPackCommand.java | 4 +- .../org/apache/sshd/git/pgm/GitPgmCommand.java | 1 - .../sshd/openpgp/PGPAuthorizedEntriesTracker.java | 2 +- .../sshd/openpgp/PGPKeyPairResourceParser.java | 3 - .../sshd/scp/client/AbstractScpClientCreator.java | 2 +- .../java/org/apache/sshd/scp/common/ScpHelper.java | 4 +- .../helpers/LocalFileScpTargetStreamResolver.java | 10 +- .../apache/sshd/scp/common/helpers/ScpIoUtils.java | 12 +- .../apache/sshd/scp/server/InputStreamReader.java | 22 +-- .../helpers/AbstractSftpClientExtension.java | 2 +- .../sftp/client/fs/SftpClientDirectoryScanner.java | 2 +- .../apache/sshd/sftp/client/fs/SftpFileSystem.java | 2 +- .../sftp/client/fs/SftpFileSystemProvider.java | 4 +- .../sftp/client/fs/SftpPathDirectoryScanner.java | 2 +- .../sshd/sftp/client/impl/DefaultSftpClient.java | 2 +- .../sftp/client/impl/SftpDirEntryIterator.java | 2 +- .../sftp/client/impl/SftpInputStreamAsync.java | 4 +- .../sftp/client/impl/SftpOutputStreamAsync.java | 2 +- .../org/apache/sshd/sftp/common/SftpHelper.java | 8 +- .../server/AbstractSftpEventListenerAdapter.java | 76 ++++----- .../sftp/server/AbstractSftpSubsystemHelper.java | 50 +++--- .../org/apache/sshd/sftp/server/SftpSubsystem.java | 11 +- .../common/SftpUniversalOwnerAndGroupTest.java | 2 +- .../integration/ApacheSshdSftpSessionFactory.java | 37 ++--- 102 files changed, 351 insertions(+), 537 deletions(-)