This is an automated email from the ASF dual-hosted git repository.
cstamas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-shade-plugin.git
The following commit(s) were added to refs/heads/master by this push:
new 02fba3a Fix for Java16+
02fba3a is described below
commit 02fba3ab6712092076b9071b4c411826c7ebd53d
Author: Tamas Cservenak <ta...@cservenak.net>
AuthorDate: Fri May 21 10:38:15 2021 +0200
Fix for Java16+
The commit fa5e40dc59355163d89cd904fcf4c4724ba3d3d6
made build fail on Java16 due illegal reflective access.
The commit is wrong that is uses "aop" guice, that is
the culprit of illegal reflective access (on Java11
generates a warning on system out, but Java16
prevents it).
Solution: use the "no_aop" guice instead. Also,
there was a SLF4J warning about non existence of
backend in tests, fixed by adding simple backend
with test scope.
---
pom.xml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/pom.xml b/pom.xml
index c428afb..a043736 100644
--- a/pom.xml
+++ b/pom.xml
@@ -107,6 +107,7 @@
<groupId>org.sonatype.sisu</groupId>
<artifactId>sisu-guice</artifactId>
<version>3.2.6</version>
+ <classifier>no_aop</classifier>
</dependency>
</dependencies>
</dependencyManagement>
@@ -228,6 +229,7 @@
<dependency>
<groupId>org.sonatype.sisu</groupId>
<artifactId>sisu-guice</artifactId>
+ <classifier>no_aop</classifier>
<scope>test</scope>
</dependency>
<dependency>
@@ -254,6 +256,12 @@
<version>2.28.2</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-simple</artifactId>
+ <version>1.7.30</version>
+ <scope>test</scope>
+ </dependency>
</dependencies>
<build>
