This is an automated email from the ASF dual-hosted git repository. elharo pushed a commit to branch map in repository https://gitbox.apache.org/repos/asf/maven-shade-plugin.git
commit d07756dd395f33f8684c674187fdd55f06d46814 Author: Elliotte Rusty Harold <elh...@google.com> AuthorDate: Mon Nov 30 15:32:59 2020 -0500 use try with resources to close --- src/main/java/org/apache/maven/plugins/shade/DefaultShader.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java b/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java index 540eccd..71e2f79 100644 --- a/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java +++ b/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java @@ -101,10 +101,9 @@ public class DefaultShader // noinspection ResultOfMethodCallIgnored shadeRequest.getUberJar().getParentFile().mkdirs(); - JarOutputStream out = null; - try - { - out = new JarOutputStream( new BufferedOutputStream( new FileOutputStream( shadeRequest.getUberJar() ) ) ); + + try ( JarOutputStream out = new JarOutputStream( new BufferedOutputStream( new FileOutputStream( shadeRequest.getUberJar() ) ) ) ) + { goThroughAllJarEntriesForManifestTransformer( shadeRequest, resources, manifestTransformer, out ); // CHECKSTYLE_OFF: MagicNumber