This is an automated email from the ASF dual-hosted git repository. khmarbaise pushed a commit to branch MNG-6825 in repository https://gitbox.apache.org/repos/asf/maven.git
commit ce60deb94e990ffae905bacfe3f41ef9b8b99f13 Author: Karl Heinz Marbaise <khmarba...@apache.org> AuthorDate: Fri Dec 20 14:55:00 2019 +0100 WIP - Improved steps. --- maven-artifact/pom.xml | 5 +++-- .../src/main/java/org/apache/maven/artifact/DefaultArtifact.java | 2 +- .../org/apache/maven/profiles/activation/FileProfileActivator.java | 4 ++-- .../maven/profiles/activation/JdkPrefixProfileActivator.java | 2 +- .../maven/profiles/activation/OperatingSystemProfileActivator.java | 2 +- .../maven/profiles/activation/SystemPropertyProfileActivator.java | 3 ++- .../java/org/apache/maven/repository/DefaultMirrorSelector.java | 2 +- .../src/test/java/org/apache/maven/project/ModelUtilsTest.java | 7 +++---- maven-core/pom.xml | 4 ---- .../src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java | 5 +++-- .../maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java | 5 +++-- .../src/main/java/org/apache/maven/plugin/MojoExecution.java | 2 +- .../org/apache/maven/cli/logging/Slf4jConfigurationFactory.java | 4 ++-- maven-model-builder/pom.xml | 5 +++-- .../main/java/org/apache/maven/model/io/DefaultModelWriter.java | 3 +-- maven-plugin-api/pom.xml | 4 ++-- maven-settings-builder/pom.xml | 4 ++-- .../java/org/apache/maven/settings/merge/MavenSettingsMerger.java | 2 +- 18 files changed, 32 insertions(+), 33 deletions(-) diff --git a/maven-artifact/pom.xml b/maven-artifact/pom.xml index 9dd4fe9..e789d14 100644 --- a/maven-artifact/pom.xml +++ b/maven-artifact/pom.xml @@ -33,9 +33,10 @@ under the License. <name>Maven Artifact</name> <dependencies> + <dependency> - <groupId>org.codehaus.plexus</groupId> - <artifactId>plexus-utils</artifactId> + <groupId>org.apache.maven.shared</groupId> + <artifactId>maven-shared-utils</artifactId> </dependency> <dependency> <groupId>org.apache.maven</groupId> diff --git a/maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java b/maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java index d63d6c9..1742983 100644 --- a/maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java +++ b/maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java @@ -34,7 +34,7 @@ import org.apache.maven.artifact.versioning.ArtifactVersion; import org.apache.maven.artifact.versioning.DefaultArtifactVersion; import org.apache.maven.artifact.versioning.OverConstrainedVersionException; import org.apache.maven.artifact.versioning.VersionRange; -import org.codehaus.plexus.util.StringUtils; +import org.apache.maven.shared.utils.StringUtils; /** * @author Jason van Zyl diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/activation/FileProfileActivator.java b/maven-compat/src/main/java/org/apache/maven/profiles/activation/FileProfileActivator.java index e7044f5..893f841 100644 --- a/maven-compat/src/main/java/org/apache/maven/profiles/activation/FileProfileActivator.java +++ b/maven-compat/src/main/java/org/apache/maven/profiles/activation/FileProfileActivator.java @@ -24,14 +24,14 @@ import java.io.IOException; import org.apache.maven.model.Activation; import org.apache.maven.model.ActivationFile; import org.apache.maven.model.Profile; +import org.apache.maven.shared.utils.StringUtils; +import org.apache.maven.shared.utils.io.FileUtils; import org.codehaus.plexus.interpolation.EnvarBasedValueSource; import org.codehaus.plexus.interpolation.InterpolationException; import org.codehaus.plexus.interpolation.MapBasedValueSource; import org.codehaus.plexus.interpolation.RegexBasedInterpolator; import org.codehaus.plexus.logging.LogEnabled; import org.codehaus.plexus.logging.Logger; -import org.codehaus.plexus.util.FileUtils; -import org.codehaus.plexus.util.StringUtils; /** * FileProfileActivator diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/activation/JdkPrefixProfileActivator.java b/maven-compat/src/main/java/org/apache/maven/profiles/activation/JdkPrefixProfileActivator.java index 1c835f8..c979fe5 100644 --- a/maven-compat/src/main/java/org/apache/maven/profiles/activation/JdkPrefixProfileActivator.java +++ b/maven-compat/src/main/java/org/apache/maven/profiles/activation/JdkPrefixProfileActivator.java @@ -24,7 +24,7 @@ import org.apache.maven.artifact.versioning.InvalidVersionSpecificationException import org.apache.maven.artifact.versioning.VersionRange; import org.apache.maven.model.Activation; import org.apache.maven.model.Profile; -import org.codehaus.plexus.util.StringUtils; +import org.apache.maven.shared.utils.StringUtils; /** * JdkPrefixProfileActivator diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java b/maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java index 378c3c9..392435a 100644 --- a/maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java +++ b/maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java @@ -22,7 +22,7 @@ package org.apache.maven.profiles.activation; import org.apache.maven.model.Activation; import org.apache.maven.model.ActivationOS; import org.apache.maven.model.Profile; -import org.codehaus.plexus.util.Os; +import org.apache.maven.shared.utils.Os; /** * OperatingSystemProfileActivator diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/activation/SystemPropertyProfileActivator.java b/maven-compat/src/main/java/org/apache/maven/profiles/activation/SystemPropertyProfileActivator.java index d7e4003..440994c 100644 --- a/maven-compat/src/main/java/org/apache/maven/profiles/activation/SystemPropertyProfileActivator.java +++ b/maven-compat/src/main/java/org/apache/maven/profiles/activation/SystemPropertyProfileActivator.java @@ -20,13 +20,14 @@ package org.apache.maven.profiles.activation; */ import java.util.Properties; + import org.apache.maven.model.Activation; import org.apache.maven.model.ActivationProperty; import org.apache.maven.model.Profile; +import org.apache.maven.shared.utils.StringUtils; import org.codehaus.plexus.context.Context; import org.codehaus.plexus.context.ContextException; import org.codehaus.plexus.personality.plexus.lifecycle.phase.Contextualizable; -import org.codehaus.plexus.util.StringUtils; /** * SystemPropertyProfileActivator diff --git a/maven-compat/src/main/java/org/apache/maven/repository/DefaultMirrorSelector.java b/maven-compat/src/main/java/org/apache/maven/repository/DefaultMirrorSelector.java index 6fa2c55..cd934c4 100644 --- a/maven-compat/src/main/java/org/apache/maven/repository/DefaultMirrorSelector.java +++ b/maven-compat/src/main/java/org/apache/maven/repository/DefaultMirrorSelector.java @@ -26,8 +26,8 @@ import java.util.List; import org.apache.maven.RepositoryUtils; import org.apache.maven.artifact.repository.ArtifactRepository; import org.apache.maven.settings.Mirror; +import org.apache.maven.shared.utils.StringUtils; import org.codehaus.plexus.component.annotations.Component; -import org.codehaus.plexus.util.StringUtils; /** * DefaultMirrorSelector diff --git a/maven-compat/src/test/java/org/apache/maven/project/ModelUtilsTest.java b/maven-compat/src/test/java/org/apache/maven/project/ModelUtilsTest.java index 402ae74..6bf89c1 100644 --- a/maven-compat/src/test/java/org/apache/maven/project/ModelUtilsTest.java +++ b/maven-compat/src/test/java/org/apache/maven/project/ModelUtilsTest.java @@ -27,15 +27,14 @@ import java.util.List; import java.util.Map; import junit.framework.TestCase; - import org.apache.maven.model.Build; import org.apache.maven.model.Dependency; import org.apache.maven.model.Plugin; import org.apache.maven.model.PluginContainer; import org.apache.maven.model.PluginExecution; -import org.codehaus.plexus.util.xml.Xpp3Dom; -import org.codehaus.plexus.util.xml.Xpp3DomBuilder; -import org.codehaus.plexus.util.xml.pull.XmlPullParserException; +import org.apache.maven.shared.utils.xml.Xpp3Dom; +import org.apache.maven.shared.utils.xml.Xpp3DomBuilder; +import org.apache.maven.shared.utils.xml.pull.XmlPullParserException; public class ModelUtilsTest extends TestCase diff --git a/maven-core/pom.xml b/maven-core/pom.xml index 2d27f41..26ce514 100644 --- a/maven-core/pom.xml +++ b/maven-core/pom.xml @@ -116,10 +116,6 @@ under the License. <!-- Plexus --> <dependency> <groupId>org.codehaus.plexus</groupId> - <artifactId>plexus-utils</artifactId> - </dependency> - <dependency> - <groupId>org.codehaus.plexus</groupId> <artifactId>plexus-classworlds</artifactId> </dependency> <dependency> diff --git a/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java b/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java index 6d15230..2b9c60e 100644 --- a/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java +++ b/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java @@ -54,9 +54,10 @@ import org.apache.maven.project.ProjectBuilder; import org.apache.maven.project.ProjectBuildingException; import org.apache.maven.project.ProjectBuildingRequest; import org.apache.maven.project.ProjectBuildingResult; +import org.apache.maven.shared.utils.StringUtils; +import org.codehaus.plexus.component.annotations.Component; +import org.codehaus.plexus.component.annotations.Requirement; import org.codehaus.plexus.logging.Logger; -import org.codehaus.plexus.util.StringUtils; -import org.codehaus.plexus.util.dag.CycleDetectedException; /** * Builds the {@link ProjectDependencyGraph inter-dependencies graph} between projects in the reactor. diff --git a/maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java b/maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java index e650813..9e8bb61 100644 --- a/maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java +++ b/maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java @@ -29,8 +29,9 @@ import org.apache.maven.model.Plugin; import org.apache.maven.model.PluginExecution; import org.apache.maven.plugin.MojoExecution; import org.apache.maven.project.MavenProject; -import org.codehaus.plexus.util.StringUtils; -import org.codehaus.plexus.util.xml.Xpp3Dom; +import org.apache.maven.shared.utils.StringUtils; +import org.apache.maven.shared.utils.xml.Xpp3Dom; +import org.codehaus.plexus.component.annotations.Component; /** * @since 3.3.1, MNG-5753 diff --git a/maven-core/src/main/java/org/apache/maven/plugin/MojoExecution.java b/maven-core/src/main/java/org/apache/maven/plugin/MojoExecution.java index fa72c18..da07593 100644 --- a/maven-core/src/main/java/org/apache/maven/plugin/MojoExecution.java +++ b/maven-core/src/main/java/org/apache/maven/plugin/MojoExecution.java @@ -25,7 +25,7 @@ import java.util.Map; import org.apache.maven.model.Plugin; import org.apache.maven.plugin.descriptor.MojoDescriptor; -import org.codehaus.plexus.util.xml.Xpp3Dom; +import org.apache.maven.shared.utils.xml.Xpp3Dom; /** * MojoExecution diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfigurationFactory.java b/maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfigurationFactory.java index 1a68d76..1db6409 100644 --- a/maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfigurationFactory.java +++ b/maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfigurationFactory.java @@ -28,7 +28,7 @@ import java.util.Properties; import java.util.Set; import org.apache.maven.cli.logging.impl.UnsupportedSlf4jBindingConfiguration; -import org.codehaus.plexus.util.PropertyUtils; +import org.apache.maven.shared.utils.PropertyUtils; import org.slf4j.ILoggerFactory; /** @@ -57,7 +57,7 @@ public class Slf4jConfigurationFactory { URL resource = resources.nextElement(); - Properties conf = PropertyUtils.loadProperties( resource.openStream() ); + Properties conf = PropertyUtils.loadOptionalProperties( resource.openStream() ); String impl = conf.getProperty( slf4jBinding ); diff --git a/maven-model-builder/pom.xml b/maven-model-builder/pom.xml index 36e76ff..afa6d8d 100644 --- a/maven-model-builder/pom.xml +++ b/maven-model-builder/pom.xml @@ -34,9 +34,10 @@ under the License. <description>The effective model builder, with inheritance, profile activation, interpolation, ...</description> <dependencies> + <dependency> - <groupId>org.codehaus.plexus</groupId> - <artifactId>plexus-utils</artifactId> + <groupId>org.apache.maven.shared</groupId> + <artifactId>maven-shared-utils</artifactId> </dependency> <dependency> <groupId>org.codehaus.plexus</groupId> diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelWriter.java b/maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelWriter.java index 650ae95..0f3cefa 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelWriter.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelWriter.java @@ -29,10 +29,9 @@ import java.util.Objects; import javax.inject.Named; import javax.inject.Singleton; - import org.apache.maven.model.Model; import org.apache.maven.model.io.xpp3.MavenXpp3Writer; -import org.codehaus.plexus.util.WriterFactory; +import org.apache.maven.shared.utils.WriterFactory; /** * Handles serialization of a model into some kind of textual format like XML. diff --git a/maven-plugin-api/pom.xml b/maven-plugin-api/pom.xml index 579022e..1ba1efc 100644 --- a/maven-plugin-api/pom.xml +++ b/maven-plugin-api/pom.xml @@ -47,8 +47,8 @@ under the License. <artifactId>org.eclipse.sisu.plexus</artifactId> </dependency> <dependency> - <groupId>org.codehaus.plexus</groupId> - <artifactId>plexus-utils</artifactId> + <groupId>org.apache.maven.shared</groupId> + <artifactId>maven-shared-utils</artifactId> </dependency> <dependency> <groupId>org.codehaus.plexus</groupId> diff --git a/maven-settings-builder/pom.xml b/maven-settings-builder/pom.xml index aec3595..babaa0f 100644 --- a/maven-settings-builder/pom.xml +++ b/maven-settings-builder/pom.xml @@ -54,8 +54,8 @@ under the License. <artifactId>plexus-interpolation</artifactId> </dependency> <dependency> - <groupId>org.codehaus.plexus</groupId> - <artifactId>plexus-utils</artifactId> + <groupId>org.apache.maven.shared</groupId> + <artifactId>maven-shared-utils</artifactId> </dependency> <dependency> <groupId>org.apache.maven</groupId> diff --git a/maven-settings-builder/src/main/java/org/apache/maven/settings/merge/MavenSettingsMerger.java b/maven-settings-builder/src/main/java/org/apache/maven/settings/merge/MavenSettingsMerger.java index 8d9f67b..3288dd7 100644 --- a/maven-settings-builder/src/main/java/org/apache/maven/settings/merge/MavenSettingsMerger.java +++ b/maven-settings-builder/src/main/java/org/apache/maven/settings/merge/MavenSettingsMerger.java @@ -26,7 +26,7 @@ import java.util.Map; import org.apache.maven.settings.IdentifiableBase; import org.apache.maven.settings.Settings; -import org.codehaus.plexus.util.StringUtils; +import org.apache.maven.shared.utils.StringUtils; /** * @author <a href="mailto:vincent.sive...@gmail.com">Vincent Siveton</a>