[SUREFIRE-1488] Native library in Surefire1295AttributeJvmCrashesToTestsIT caused unstable test
Project: http://git-wip-us.apache.org/repos/asf/maven-surefire/repo Commit: http://git-wip-us.apache.org/repos/asf/maven-surefire/commit/3ddcd1f6 Tree: http://git-wip-us.apache.org/repos/asf/maven-surefire/tree/3ddcd1f6 Diff: http://git-wip-us.apache.org/repos/asf/maven-surefire/diff/3ddcd1f6 Branch: refs/heads/master Commit: 3ddcd1f6795c6fde703cbb848a1005694b7ee878 Parents: 7bd6194 Author: Tibor17 <tibordig...@apache.org> Authored: Sat Mar 3 04:05:20 2018 +0100 Committer: Tibor17 <tibordig...@apache.org> Committed: Sat Mar 3 04:05:20 2018 +0100 ---------------------------------------------------------------------- .../jiras/Surefire1295AttributeJvmCrashesToTestsIT.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/3ddcd1f6/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1295AttributeJvmCrashesToTestsIT.java ---------------------------------------------------------------------- diff --git a/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1295AttributeJvmCrashesToTestsIT.java b/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1295AttributeJvmCrashesToTestsIT.java index 96e6f41..f756816 100644 --- a/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1295AttributeJvmCrashesToTestsIT.java +++ b/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1295AttributeJvmCrashesToTestsIT.java @@ -66,9 +66,11 @@ public class Surefire1295AttributeJvmCrashesToTestsIT public static Iterable<Object[]> parameters() { return asList(new Object[][] { - { "exit", DEFAULT }, - { "exit", ONE_FORK_NO_REUSE }, - { "exit", ONE_FORK_REUSE }, +// unused, exit() does not stop all Threads immediately, +// see https://github.com/michaeltandy/crashjvm/issues/1 +// { "exit", DEFAULT }, +// { "exit", ONE_FORK_NO_REUSE }, +// { "exit", ONE_FORK_REUSE }, { "abort", DEFAULT }, { "abort", ONE_FORK_NO_REUSE }, { "abort", ONE_FORK_REUSE }, @@ -127,7 +129,7 @@ public class Surefire1295AttributeJvmCrashesToTestsIT // Waiting for the stream to become flushed on disk. SECONDS.sleep( 1L ); - for ( Iterator< String > it = validator.loadLogLines().iterator(); it.hasNext(); ) + for ( Iterator<String> it = validator.loadLogLines().iterator(); it.hasNext(); ) { String line = it.next(); if ( line.contains( "Crashed tests:" ) )
