Author: tchemit Date: Wed Jul 11 08:47:58 2012 New Revision: 1360065 URL: http://svn.apache.org/viewvc?rev=1360065&view=rev Log: [MACR-6] use maven-plugin-tools' java 5 annotations
Modified: maven/plugins/trunk/maven-acr-plugin/pom.xml maven/plugins/trunk/maven-acr-plugin/src/main/java/org/apache/maven/plugin/acr/AcrMojo.java Modified: maven/plugins/trunk/maven-acr-plugin/pom.xml URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-acr-plugin/pom.xml?rev=1360065&r1=1360064&r2=1360065&view=diff ============================================================================== --- maven/plugins/trunk/maven-acr-plugin/pom.xml (original) +++ maven/plugins/trunk/maven-acr-plugin/pom.xml Wed Jul 11 08:47:58 2012 @@ -25,7 +25,7 @@ under the License. <parent> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-plugins</artifactId> - <version>21</version> + <version>22</version> <relativePath>../maven-plugins/pom.xml</relativePath> </parent> @@ -83,6 +83,11 @@ under the License. </exclusions> </dependency> <dependency> + <groupId>org.apache.maven.plugin-tools</groupId> + <artifactId>maven-plugin-annotations</artifactId> + <version>3.1</version> + </dependency> + <dependency> <groupId>org.apache.maven.shared</groupId> <artifactId>maven-filtering</artifactId> <version>1.0</version> @@ -116,6 +121,34 @@ under the License. </dependency> </dependencies> + <build> + <pluginManagement> + <plugins> + <plugin> + <artifactId>maven-plugin-plugin</artifactId> + <version>3.1</version> + <configuration> + <skipErrorNoDescriptorsFound>true</skipErrorNoDescriptorsFound> + </configuration> + </plugin> + </plugins> + </pluginManagement> + + <plugins> + <plugin> + <artifactId>maven-plugin-plugin</artifactId> + <executions> + <execution> + <id>generate-descriptor</id> + <goals> + <goal>descriptor</goal> + </goals> + </execution> + </executions> + </plugin> + </plugins> + </build> + <profiles> <profile> <id>run-its</id> Modified: maven/plugins/trunk/maven-acr-plugin/src/main/java/org/apache/maven/plugin/acr/AcrMojo.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-acr-plugin/src/main/java/org/apache/maven/plugin/acr/AcrMojo.java?rev=1360065&r1=1360064&r2=1360065&view=diff ============================================================================== --- maven/plugins/trunk/maven-acr-plugin/src/main/java/org/apache/maven/plugin/acr/AcrMojo.java (original) +++ maven/plugins/trunk/maven-acr-plugin/src/main/java/org/apache/maven/plugin/acr/AcrMojo.java Wed Jul 11 08:47:58 2012 @@ -25,10 +25,16 @@ import org.apache.maven.artifact.Depende import org.apache.maven.execution.MavenSession; import org.apache.maven.plugin.AbstractMojo; import org.apache.maven.plugin.MojoExecutionException; +import org.apache.maven.plugins.annotations.Component; +import org.apache.maven.plugins.annotations.LifecyclePhase; +import org.apache.maven.plugins.annotations.Mojo; +import org.apache.maven.plugins.annotations.Parameter; +import org.apache.maven.plugins.annotations.ResolutionScope; import org.apache.maven.project.MavenProject; import org.apache.maven.shared.filtering.MavenFileFilter; import org.apache.maven.shared.filtering.MavenFilteringException; import org.apache.maven.shared.filtering.MavenResourcesExecution; +import org.codehaus.plexus.archiver.Archiver; import org.codehaus.plexus.archiver.ArchiverException; import org.codehaus.plexus.archiver.jar.JarArchiver; import org.codehaus.plexus.archiver.jar.ManifestException; @@ -45,11 +51,9 @@ import java.util.List; * @author <a href="pa...@anahata-it.com">Pablo Rodriguez</a> * @author <a href="snic...@apache.org">Stephane Nicoll</a> * @version $Id: - * @goal acr - * @requiresDependencyResolution runtime - * @threadSafe - * @phase package */ +@Mojo( name = "acr", requiresDependencyResolution = ResolutionScope.RUNTIME, threadSafe = true, + defaultPhase = LifecyclePhase.PACKAGE ) public class AcrMojo extends AbstractMojo { @@ -65,25 +69,20 @@ public class AcrMojo /** * The directory for the generated jar. - * - * @parameter default-value="${project.build.directory}" - * @required - * @readonly */ + @Parameter( defaultValue = "${project.build.directory}", required = true, readonly = true ) private File basedir; /** * Directory that resources are copied to during the build. - * - * @parameter default-value="${project.build.outputDirectory}" expression="${outputDirectory}" */ + @Parameter( property = "outputDirectory", defaultValue = "${project.build.outputDirectory}" ) private File outputDirectory; /** * The name of the Application client JAR file to generate. - * - * @parameter default-value="${project.build.finalName}" expression="${jarName}" */ + @Parameter( property = "jarName", defaultValue = "${project.build.finalName}" ) private String jarName; /** @@ -95,76 +94,63 @@ public class AcrMojo * </excludes> * </pre> * <br/>Default exclusions: META-INF/application-client.xml, - * - * @parameter */ + @Parameter private List excludes; /** * The Maven project. - * - * @parameter default-value="${project}" - * @required - * @readonly */ + @Component private MavenProject project; /** * The Jar archiver. - * - * @component role="org.codehaus.plexus.archiver.Archiver" roleHint="jar" */ + @Component( role = Archiver.class, hint = "jar" ) private JarArchiver jarArchiver; /** * The archive configuration to use. * See <a href="http://maven.apache.org/shared/maven-archiver/index.html">Maven Archiver Reference</a>. - * - * @parameter */ + @Parameter private MavenArchiveConfiguration archive = new MavenArchiveConfiguration(); /** * To escape interpolated value with windows path. * c:\foo\bar will be replaced with c:\\foo\\bar. - * - * @parameter default-value="false" expression="${acr.escapeBackslashesInFilePath}" */ + @Parameter( property = "acr.escapeBackslashesInFilePath", defaultValue = "false" ) private boolean escapeBackslashesInFilePath; /** * An expression preceded with this String won't be interpolated. * \${foo} will be replaced with ${foo}. - * - * @parameter expression="${acr.escapeString}" */ + @Parameter( property = "acr.escapeString" ) protected String escapeString; /** * To filter the deployment descriptor. - * - * @parameter default-value="false" expression="${acr.filterDeploymentDescriptor}" */ + @Parameter( property = "acr.filterDeploymentDescriptor", defaultValue = "false" ) private boolean filterDeploymentDescriptor; /** * Filters (properties files) to include during the interpolation of the deployment descriptor. - * - * @parameter */ + @Parameter private List filters; /** - * @component role="org.apache.maven.shared.filtering.MavenFileFilter" role-hint="default" - * @required */ + @Component( role = MavenFileFilter.class, hint = "default" ) private MavenFileFilter mavenFileFilter; /** - * @parameter expression="${session}" - * @readonly - * @required */ + @Component private MavenSession session; /**