Author: olamy Date: Tue May 22 21:42:04 2012 New Revision: 1341650 URL: http://svn.apache.org/viewvc?rev=1341650&view=rev Log: use hint rather than roleHint
Modified: maven/plugin-tools/trunk/maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Component.java maven/plugin-tools/trunk/maven-plugin-plugin/src/it/annotation-with-inheritance-reactor/module-abstract-mojo/src/main/java/org/apache/maven/plugins/AbstractFirstMojo.java maven/plugin-tools/trunk/maven-plugin-plugin/src/it/annotation-with-inheritance/src/main/java/org/apache/maven/plugin/coreit/AbstractFirstMojo.java maven/plugin-tools/trunk/maven-plugin-plugin/src/it/java-basic-annotations/src/main/java/org/apache/maven/plugin/coreit/FirstMojo.java maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/JavaAnnotationsMojoDescriptorExtractor.java maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/datamodel/ComponentAnnotationContent.java maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/test/java/org/apache/maven/tools/plugin/annotations/FooMojo.java Modified: maven/plugin-tools/trunk/maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Component.java URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Component.java?rev=1341650&r1=1341649&r2=1341650&view=diff ============================================================================== --- maven/plugin-tools/trunk/maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Component.java (original) +++ maven/plugin-tools/trunk/maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Component.java Tue May 22 21:42:04 2012 @@ -45,8 +45,8 @@ public @interface Component Class<?> role() default Object.class; /** - * role-hint of the component to inject. - * @return the role-hint + * hint of the component to inject. + * @return the hint */ - String roleHint() default ""; + String hint() default ""; } Modified: maven/plugin-tools/trunk/maven-plugin-plugin/src/it/annotation-with-inheritance-reactor/module-abstract-mojo/src/main/java/org/apache/maven/plugins/AbstractFirstMojo.java URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-plugin/src/it/annotation-with-inheritance-reactor/module-abstract-mojo/src/main/java/org/apache/maven/plugins/AbstractFirstMojo.java?rev=1341650&r1=1341649&r2=1341650&view=diff ============================================================================== --- maven/plugin-tools/trunk/maven-plugin-plugin/src/it/annotation-with-inheritance-reactor/module-abstract-mojo/src/main/java/org/apache/maven/plugins/AbstractFirstMojo.java (original) +++ maven/plugin-tools/trunk/maven-plugin-plugin/src/it/annotation-with-inheritance-reactor/module-abstract-mojo/src/main/java/org/apache/maven/plugins/AbstractFirstMojo.java Tue May 22 21:42:04 2012 @@ -58,7 +58,7 @@ public abstract class AbstractFirstMojo /** * */ - @Component( role = ArtifactMetadataSource.class, roleHint = "maven" ) + @Component( role = ArtifactMetadataSource.class, hint = "maven" ) protected ArtifactMetadataSource artifactMetadataSource; } Modified: maven/plugin-tools/trunk/maven-plugin-plugin/src/it/annotation-with-inheritance/src/main/java/org/apache/maven/plugin/coreit/AbstractFirstMojo.java URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-plugin/src/it/annotation-with-inheritance/src/main/java/org/apache/maven/plugin/coreit/AbstractFirstMojo.java?rev=1341650&r1=1341649&r2=1341650&view=diff ============================================================================== --- maven/plugin-tools/trunk/maven-plugin-plugin/src/it/annotation-with-inheritance/src/main/java/org/apache/maven/plugin/coreit/AbstractFirstMojo.java (original) +++ maven/plugin-tools/trunk/maven-plugin-plugin/src/it/annotation-with-inheritance/src/main/java/org/apache/maven/plugin/coreit/AbstractFirstMojo.java Tue May 22 21:42:04 2012 @@ -58,7 +58,7 @@ public abstract class AbstractFirstMojo /** * */ - @Component( role = ArtifactMetadataSource.class, roleHint = "maven" ) + @Component( role = ArtifactMetadataSource.class, hint = "maven" ) protected ArtifactMetadataSource artifactMetadataSource; } Modified: maven/plugin-tools/trunk/maven-plugin-plugin/src/it/java-basic-annotations/src/main/java/org/apache/maven/plugin/coreit/FirstMojo.java URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-plugin/src/it/java-basic-annotations/src/main/java/org/apache/maven/plugin/coreit/FirstMojo.java?rev=1341650&r1=1341649&r2=1341650&view=diff ============================================================================== --- maven/plugin-tools/trunk/maven-plugin-plugin/src/it/java-basic-annotations/src/main/java/org/apache/maven/plugin/coreit/FirstMojo.java (original) +++ maven/plugin-tools/trunk/maven-plugin-plugin/src/it/java-basic-annotations/src/main/java/org/apache/maven/plugin/coreit/FirstMojo.java Tue May 22 21:42:04 2012 @@ -60,7 +60,7 @@ public class FirstMojo @Parameter( alias = "alias" ) private String aliasedParam; - @Component( role = MavenProjectHelper.class, roleHint = "test" ) + @Component( role = MavenProjectHelper.class, hint = "test" ) private Object projectHelper; public void execute() Modified: maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/JavaAnnotationsMojoDescriptorExtractor.java URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/JavaAnnotationsMojoDescriptorExtractor.java?rev=1341650&r1=1341649&r2=1341650&view=diff ============================================================================== --- maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/JavaAnnotationsMojoDescriptorExtractor.java (original) +++ maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/JavaAnnotationsMojoDescriptorExtractor.java Tue May 22 21:42:04 2012 @@ -546,7 +546,7 @@ public class JavaAnnotationsMojoDescript new org.apache.maven.plugin.descriptor.Parameter(); parameter.setName( componentAnnotationContent.getFieldName() ); parameter.setRequirement( new Requirement( componentAnnotationContent.getRoleClassName(), - componentAnnotationContent.roleHint() ) ); + componentAnnotationContent.hint() ) ); parameter.setDeprecated( componentAnnotationContent.getDeprecated() ); parameter.setSince( componentAnnotationContent.getSince() ); Modified: maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/datamodel/ComponentAnnotationContent.java URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/datamodel/ComponentAnnotationContent.java?rev=1341650&r1=1341649&r2=1341650&view=diff ============================================================================== --- maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/datamodel/ComponentAnnotationContent.java (original) +++ maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/annotations/datamodel/ComponentAnnotationContent.java Tue May 22 21:42:04 2012 @@ -33,18 +33,18 @@ public class ComponentAnnotationContent { private String roleClassName; - private String roleHint; + private String hint; public ComponentAnnotationContent( String fieldName ) { super( fieldName ); } - public ComponentAnnotationContent( String fieldName, String role, String roleHint ) + public ComponentAnnotationContent( String fieldName, String role, String hint ) { this( fieldName ); this.roleClassName = role; - this.roleHint = roleHint; + this.hint = hint; } public Class<?> role() @@ -63,14 +63,14 @@ public class ComponentAnnotationContent return roleClassName; } - public String roleHint() + public String hint() { - return roleHint == null ? "" : roleHint; + return hint == null ? "" : hint; } - public void roleHint( String roleHint ) + public void hint( String hint ) { - this.roleHint = roleHint; + this.hint = hint; } public Class<? extends Annotation> annotationType() @@ -85,7 +85,7 @@ public class ComponentAnnotationContent sb.append( super.toString() ); sb.append( "ComponentAnnotationContent" ); sb.append( "{role='" ).append( roleClassName ).append( '\'' ); - sb.append( ", roleHint='" ).append( roleHint ).append( '\'' ); + sb.append( ", hint='" ).append( hint ).append( '\'' ); sb.append( '}' ); return sb.toString(); } Modified: maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/test/java/org/apache/maven/tools/plugin/annotations/FooMojo.java URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/test/java/org/apache/maven/tools/plugin/annotations/FooMojo.java?rev=1341650&r1=1341649&r2=1341650&view=diff ============================================================================== --- maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/test/java/org/apache/maven/tools/plugin/annotations/FooMojo.java (original) +++ maven/plugin-tools/trunk/maven-plugin-tools-annotations/src/test/java/org/apache/maven/tools/plugin/annotations/FooMojo.java Tue May 22 21:42:04 2012 @@ -61,7 +61,7 @@ public class FooMojo /** * */ - @Component( role = ArtifactMetadataSource.class, roleHint = "maven" ) + @Component( role = ArtifactMetadataSource.class, hint = "maven" ) protected ArtifactMetadataSource artifactMetadataSource; public void execute()