svn commit: r1202059 - in /maven/surefire/trunk/surefire-api/src: main/java/org/apache/maven/surefire/booter/ForkingRunListener.java test/java/org/apache/maven/surefire/booter/ test/java/org/apache/maven/surefire/booter/ForkingRunListenerTest.java

[krosenvold]

Author: krosenvold
Date: Tue Nov 15 06:42:03 2011
New Revision: 1202059

URL: http://svn.apache.org/viewvc?rev=1202059&view=rev
Log:
[SUREFIRE-775] ForkingRunListener throws ArrayIndexOutOfBoundsException

Fixed with unit test

Added:
    
maven/surefire/trunk/surefire-api/src/test/java/org/apache/maven/surefire/booter/
    
maven/surefire/trunk/surefire-api/src/test/java/org/apache/maven/surefire/booter/ForkingRunListenerTest.java
   (with props)
Modified:
    
maven/surefire/trunk/surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java

Modified: 
maven/surefire/trunk/surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java
URL: 
http://svn.apache.org/viewvc/maven/surefire/trunk/surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java?rev=1202059&r1=1202058&r2=1202059&view=diff
==============================================================================
--- 
maven/surefire/trunk/surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java
 (original)
+++ 
maven/surefire/trunk/surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java
 Tue Nov 15 06:42:03 2011
@@ -212,7 +212,7 @@ public class ForkingRunListener
     public void info( String message )
     {
         byte[] buf = message.getBytes();
-        ByteBuffer byteBuffer = new ByteBuffer( buf.length * 6 );
+        ByteBuffer byteBuffer = new ByteBuffer( 7 + buf.length * 6 ); // 7 => 
Allow 3 digit testSetChannelId
         byteBuffer.append( BOOTERCODE_CONSOLE );
         byteBuffer.comma();
         byteBuffer.append( testSetChannelId );

Added: 
maven/surefire/trunk/surefire-api/src/test/java/org/apache/maven/surefire/booter/ForkingRunListenerTest.java
URL: 
http://svn.apache.org/viewvc/maven/surefire/trunk/surefire-api/src/test/java/org/apache/maven/surefire/booter/ForkingRunListenerTest.java?rev=1202059&view=auto
==============================================================================
--- 
maven/surefire/trunk/surefire-api/src/test/java/org/apache/maven/surefire/booter/ForkingRunListenerTest.java
 (added)
+++ 
maven/surefire/trunk/surefire-api/src/test/java/org/apache/maven/surefire/booter/ForkingRunListenerTest.java
 Tue Nov 15 06:42:03 2011
@@ -0,0 +1,20 @@
+package org.apache.maven.surefire.booter;
+
+import junit.framework.TestCase;
+
+import java.io.ByteArrayOutputStream;
+import java.io.PrintStream;
+
+/**
+ * @author <a href="mailto:kristian.rosenv...@gmail.com";>Kristian Rosenvold</a>
+ */
+public class ForkingRunListenerTest extends TestCase {
+    public void testInfo() throws Exception {
+        ByteArrayOutputStream byteArrayOutputStream = new 
ByteArrayOutputStream();
+        PrintStream target = new PrintStream(byteArrayOutputStream);
+        ForkingRunListener forkingRunListener = new ForkingRunListener(target, 
1, true);
+        forkingRunListener.info(new String(new byte[]{65}));
+        forkingRunListener.info(new String(new byte[]{}));
+
+    }
+}

Propchange: 
maven/surefire/trunk/surefire-api/src/test/java/org/apache/maven/surefire/booter/ForkingRunListenerTest.java
------------------------------------------------------------------------------
    svn:eol-style = native