Author: dkulp
Date: Wed Jun 2 20:23:49 2010
New Revision: 950747
URL: http://svn.apache.org/viewvc?rev=950747&view=rev
Log:
Since the DefaultCheckstyleExecutor contains an object (ResourceManager)
that holds onto state and must be per-lookup, the DefaultCheckstyleExecutor
must also be per-lookup to be thread safe.
Modified:
maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java
Modified:
maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java
URL:
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java?rev=950747&r1=950746&r2=950747&view=diff
==============================================================================
---
maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java
(original)
+++
maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java
Wed Jun 2 20:23:49 2010
@@ -52,7 +52,7 @@ import com.puppycrawl.tools.checkstyle.f
/**
* @author <a href="mailto:ol...@apache.org";>olamy</a>
- * @plexus.component
role="org.apache.maven.plugin.checkstyle.CheckstyleExecutor" role-hint="default"
+ * @plexus.component
role="org.apache.maven.plugin.checkstyle.CheckstyleExecutor"
role-hint="default" instantiation-strategy="per-lookup"
* @since 2.5
* @version $Id$
*/
@@ -464,7 +464,6 @@ public class DefaultCheckstyleExecutor
locator.addSearchPath( "url", "" );
File configFile = locator.getResourceAsFile(
request.getConfigLocation(), "checkstyle-checker.xml" );
-
if ( configFile == null )
{
throw new CheckstyleExecutorException( "Unable to process
config location: "
