svn commit: r803828 - in /maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin: changes/ChangesReportGenerator.java jira/JiraReportGenerator.java trac/TracReportGenerator.java

[vsiveton]

Author: vsiveton
Date: Thu Aug 13 10:11:17 2009
New Revision: 803828

URL: http://svn.apache.org/viewvc?rev=803828&view=rev
Log:
MCHANGES-170: Review the Doxia Sink calls

o added missing sink calls for Doxia 1.0

Modified:
    
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesReportGenerator.java
    
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraReportGenerator.java
    
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/trac/TracReportGenerator.java

Modified: 
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesReportGenerator.java
URL: 
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesReportGenerator.java?rev=803828&r1=803827&r2=803828&view=diff
==============================================================================
--- 
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesReportGenerator.java
 (original)
+++ 
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesReportGenerator.java
 Thu Aug 13 10:11:17 2009
@@ -134,7 +134,7 @@
 
     /**
      * Checks whether links to the issues can be generated.
-     * 
+     *
      * @return <code>true</code> if issue links can be generated, 
<code>false</code> otherwise.
      */
     public boolean canGenerateIssueLinks( String system )
@@ -452,19 +452,21 @@
     private void sinkSectionTitle1Anchor( Sink sink, String text, String 
anchor )
     {
         sink.sectionTitle1();
-        sink.anchor( anchor );
-        sink.anchor_();
         sink.text( text );
         sink.sectionTitle1_();
+
+        sink.anchor( anchor );
+        sink.anchor_();
     }
 
     private void sinkSectionTitle2Anchor( Sink sink, String text, String 
anchor )
     {
         sink.sectionTitle2();
-        sink.anchor( anchor );
-        sink.anchor_();
         sink.text( text );
         sink.sectionTitle2_();
+
+        sink.anchor( anchor );
+        sink.anchor_();
     }
 
     private void sinkShowTypeIcon( Sink sink, String type )

Modified: 
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraReportGenerator.java
URL: 
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraReportGenerator.java?rev=803828&r1=803827&r2=803828&view=diff
==============================================================================
--- 
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraReportGenerator.java
 (original)
+++ 
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/JiraReportGenerator.java
 Thu Aug 13 10:11:17 2009
@@ -123,8 +123,12 @@
     {
         sinkBeginReport( sink, bundle );
 
+        sink.paragraph();
+
         sink.text( bundle.getString( "report.jira.error" ) );
 
+        sink.paragraph_();
+
         sinkEndReport( sink );
     }
 
@@ -306,12 +310,15 @@
 
         sink.body();
 
-        sinkSectionTitle1( sink, bundle.getString( "report.jira.header" ) );
+        sink.section1();
 
+        sinkSectionTitle1( sink, bundle.getString( "report.jira.header" ) );
     }
 
     private void sinkEndReport( Sink sink )
     {
+        sink.section1_();
+
         sink.body_();
 
         sink.flush();

Modified: 
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/trac/TracReportGenerator.java
URL: 
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/trac/TracReportGenerator.java?rev=803828&r1=803827&r2=803828&view=diff
==============================================================================
--- 
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/trac/TracReportGenerator.java
 (original)
+++ 
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/trac/TracReportGenerator.java
 Thu Aug 13 10:11:17 2009
@@ -28,7 +28,7 @@
 
 /**
  * Generates a Trac report.
- * 
+ *
  * @author Noriko Kinugasa
  * @version $Id$
  */
@@ -44,8 +44,12 @@
     {
         sinkBeginReport( sink, bundle );
 
+        sink.paragraph();
+
         sink.text( bundle.getString( "report.trac.error" ) );
 
+        sink.paragraph_();
+
         sinkEndReport( sink );
     }
 
@@ -154,12 +158,16 @@
 
         sink.body();
 
+        sink.section1();
+
         sinkSectionTitle1( sink, bundle.getString( "report.trac.header" ) );
 
     }
 
     private void sinkEndReport( Sink sink )
     {
+        sink.section1_();
+
         sink.body_();
 
         sink.flush();