svn commit: r764552 - /maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java

[pgier]

Author: pgier
Date: Mon Apr 13 18:35:55 2009
New Revision: 764552

URL: http://svn.apache.org/viewvc?rev=764552&view=rev
Log:
[MNG-3834] Improve missing version error message.

Modified:
    
maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java

Modified: 
maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java
URL: 
http://svn.apache.org/viewvc/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java?rev=764552&r1=764551&r2=764552&view=diff
==============================================================================
--- 
maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java
 (original)
+++ 
maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java
 Mon Apr 13 18:35:55 2009
@@ -85,10 +85,10 @@
 
             validateId( "dependencies.dependency.groupId", result, 
d.getGroupId() );
 
-            validateStringNotEmpty( "dependencies.dependency.type", result, 
d.getType(), dependencySourceHint( d ) );
+            validateStringNotEmpty( "dependencies.dependency.type", result, 
d.getType(), d.getManagementKey() );
 
             validateStringNotEmpty( "dependencies.dependency.version", result, 
d.getVersion(),
-                                    dependencySourceHint( d ) );
+                                    d.getManagementKey() );
 
             if ( Artifact.SCOPE_SYSTEM.equals( d.getScope() ) )
             {
@@ -263,19 +263,6 @@
     // Field validation
     // ----------------------------------------------------------------------
 
-    /**
-     * Create a hint string consisting of the groupId and artifactId for user 
validation
-     * messages. For example when the version or type information is missing 
from a
-     * dependency.
-     *
-     * @param d The dependency from which to make the hint.
-     * @return String of the form g:a.
-     */
-    private String dependencySourceHint( Dependency d )
-    {
-        return d.getGroupId() + ":" + d.getArtifactId();
-    }
-
     private boolean validateStringNotEmpty( String fieldName, 
ModelValidationResult result, String string )
     {
         return validateStringNotEmpty( fieldName, result, string, null );