Author: vsiveton
Date: Wed Sep 3 15:38:59 2008
New Revision: 691811
URL: http://svn.apache.org/viewvc?rev=691811&view=rev
Log:
SCM-411: Performance: logger calls are not optimal
o improved all logging call (debug, error, warn and info)
Modified:
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/add/SvnAddCommand.java
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/checkin/SvnCheckInCommand.java
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/checkout/SvnCheckOutCommand.java
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/diff/SvnDiffCommand.java
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/remove/SvnRemoveCommand.java
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/status/SvnStatusCommand.java
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/tag/SvnTagCommand.java
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/update/SvnUpdateCommand.java
Modified:
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/add/SvnAddCommand.java
URL:
http://svn.apache.org/viewvc/maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/add/SvnAddCommand.java?rev=691811&r1=691810&r2=691811&view=diff
==============================================================================
---
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/add/SvnAddCommand.java
(original)
+++
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/add/SvnAddCommand.java
Wed Sep 3 15:38:59 2008
@@ -91,7 +91,10 @@
{
File fileToAdd = new File( fileSet.getBasedir(),
files[i].toString() );
- getLogger().debug( "SVN adding file: " +
fileToAdd.getAbsolutePath() );
+ if ( getLogger().isDebugEnabled() )
+ {
+ getLogger().debug( "SVN adding file: " +
fileToAdd.getAbsolutePath() );
+ }
SvnJavaUtil.add( clientManager, fileToAdd, false );
}
Modified:
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/checkin/SvnCheckInCommand.java
URL:
http://svn.apache.org/viewvc/maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/checkin/SvnCheckInCommand.java?rev=691811&r1=691810&r2=691811&view=diff
==============================================================================
---
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/checkin/SvnCheckInCommand.java
(original)
+++
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/checkin/SvnCheckInCommand.java
Wed Sep 3 15:38:59 2008
@@ -53,7 +53,10 @@
String message,
ScmVersion tag )
throws ScmException
{
- getLogger().info( "SVN commit directory: " +
fileSet.getBasedir().getAbsolutePath() );
+ if ( getLogger().isInfoEnabled() )
+ {
+ getLogger().info( "SVN commit directory: " +
fileSet.getBasedir().getAbsolutePath() );
+ }
SvnJavaScmProviderRepository javaRepo = (SvnJavaScmProviderRepository)
repo;
Modified:
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/checkout/SvnCheckOutCommand.java
URL:
http://svn.apache.org/viewvc/maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/checkout/SvnCheckOutCommand.java?rev=691811&r1=691810&r2=691811&view=diff
==============================================================================
---
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/checkout/SvnCheckOutCommand.java
(original)
+++
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/checkout/SvnCheckOutCommand.java
Wed Sep 3 15:38:59 2008
@@ -50,7 +50,10 @@
ScmVersion tag,
boolean recursive )
throws ScmException
{
- getLogger().info( "SVN checkout directory: " +
fileSet.getBasedir().getAbsolutePath() );
+ if ( getLogger().isInfoEnabled() )
+ {
+ getLogger().info( "SVN checkout directory: " +
fileSet.getBasedir().getAbsolutePath() );
+ }
SvnScmProviderRepository repository = (SvnScmProviderRepository) repo;
Modified:
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/diff/SvnDiffCommand.java
URL:
http://svn.apache.org/viewvc/maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/diff/SvnDiffCommand.java?rev=691811&r1=691810&r2=691811&view=diff
==============================================================================
---
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/diff/SvnDiffCommand.java
(original)
+++
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/diff/SvnDiffCommand.java
Wed Sep 3 15:38:59 2008
@@ -53,7 +53,10 @@
ScmVersion startRevision,
ScmVersion endRevision )
throws ScmException
{
- getLogger().info( "SVN diff directory: " +
fileSet.getBasedir().getAbsolutePath() );
+ if ( getLogger().isInfoEnabled() )
+ {
+ getLogger().info( "SVN diff directory: " +
fileSet.getBasedir().getAbsolutePath() );
+ }
SvnJavaScmProviderRepository javaRepo = (SvnJavaScmProviderRepository)
repo;
Modified:
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/remove/SvnRemoveCommand.java
URL:
http://svn.apache.org/viewvc/maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/remove/SvnRemoveCommand.java?rev=691811&r1=691810&r2=691811&view=diff
==============================================================================
---
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/remove/SvnRemoveCommand.java
(original)
+++
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/remove/SvnRemoveCommand.java
Wed Sep 3 15:38:59 2008
@@ -49,7 +49,10 @@
throw new ScmException( "You must provide at least one
file/directory to remove" );
}
- getLogger().info( "SVN remove working directory: " +
fileSet.getBasedir().getAbsolutePath() );
+ if ( getLogger().isInfoEnabled() )
+ {
+ getLogger().info( "SVN remove working directory: " +
fileSet.getBasedir().getAbsolutePath() );
+ }
SvnJavaScmProviderRepository javaRepo = (SvnJavaScmProviderRepository)
repo;
Modified:
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/status/SvnStatusCommand.java
URL:
http://svn.apache.org/viewvc/maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/status/SvnStatusCommand.java?rev=691811&r1=691810&r2=691811&view=diff
==============================================================================
---
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/status/SvnStatusCommand.java
(original)
+++
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/status/SvnStatusCommand.java
Wed Sep 3 15:38:59 2008
@@ -43,7 +43,10 @@
protected StatusScmResult executeStatusCommand( ScmProviderRepository
repo, ScmFileSet fileSet )
throws ScmException
{
- getLogger().info( "SVN status directory: " +
fileSet.getBasedir().getAbsolutePath() );
+ if ( getLogger().isInfoEnabled() )
+ {
+ getLogger().info( "SVN status directory: " +
fileSet.getBasedir().getAbsolutePath() );
+ }
SvnJavaScmProviderRepository javaRepo = (SvnJavaScmProviderRepository)
repo;
Modified:
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/tag/SvnTagCommand.java
URL:
http://svn.apache.org/viewvc/maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/tag/SvnTagCommand.java?rev=691811&r1=691810&r2=691811&view=diff
==============================================================================
---
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/tag/SvnTagCommand.java
(original)
+++
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/tag/SvnTagCommand.java
Wed Sep 3 15:38:59 2008
@@ -69,7 +69,10 @@
throw new ScmException( "This provider doesn't support tagging
subsets of a directory" );
}
- getLogger().info( "SVN checkout directory: " +
fileSet.getBasedir().getAbsolutePath() );
+ if ( getLogger().isInfoEnabled() )
+ {
+ getLogger().info( "SVN checkout directory: " +
fileSet.getBasedir().getAbsolutePath() );
+ }
SvnScmProviderRepository repository = (SvnScmProviderRepository) repo;
Modified:
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/update/SvnUpdateCommand.java
URL:
http://svn.apache.org/viewvc/maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/update/SvnUpdateCommand.java?rev=691811&r1=691810&r2=691811&view=diff
==============================================================================
---
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/update/SvnUpdateCommand.java
(original)
+++
maven/sandbox/trunk/scm/maven-scm-provider-svnjava/src/main/java/org/apache/maven/scm/provider/svn/svnjava/command/update/SvnUpdateCommand.java
Wed Sep 3 15:38:59 2008
@@ -53,7 +53,10 @@
{
SvnScmProviderRepository repository = (SvnScmProviderRepository) repo;
- getLogger().info( "SVN update directory: " +
fileSet.getBasedir().getAbsolutePath() );
+ if ( getLogger().isInfoEnabled() )
+ {
+ getLogger().info( "SVN update directory: " +
fileSet.getBasedir().getAbsolutePath() );
+ }
SvnJavaScmProviderRepository javaRepo = (SvnJavaScmProviderRepository)
repo;
