Author: janb Date: Tue Aug 12 23:56:52 2008 New Revision: 685467 URL: http://svn.apache.org/viewvc?rev=685467&view=rev Log: Ensure streams are closed when request is finished.
Modified: maven/sandbox/trunk/mercury/mercury-transport/mercury-transport-http/src/main/java/org/apache/maven/mercury/spi/http/client/deploy/FilePutExchange.java maven/sandbox/trunk/mercury/mercury-transport/mercury-transport-http/src/main/java/org/apache/maven/mercury/spi/http/client/retrieve/FileGetExchange.java Modified: maven/sandbox/trunk/mercury/mercury-transport/mercury-transport-http/src/main/java/org/apache/maven/mercury/spi/http/client/deploy/FilePutExchange.java URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/mercury/mercury-transport/mercury-transport-http/src/main/java/org/apache/maven/mercury/spi/http/client/deploy/FilePutExchange.java?rev=685467&r1=685466&r2=685467&view=diff ============================================================================== --- maven/sandbox/trunk/mercury/mercury-transport/mercury-transport-http/src/main/java/org/apache/maven/mercury/spi/http/client/deploy/FilePutExchange.java (original) +++ maven/sandbox/trunk/mercury/mercury-transport/mercury-transport-http/src/main/java/org/apache/maven/mercury/spi/http/client/deploy/FilePutExchange.java Tue Aug 12 23:56:52 2008 @@ -35,6 +35,7 @@ import org.apache.maven.mercury.spi.http.client.HttpClientException; import org.apache.maven.mercury.spi.http.client.ObservableInputStream; import org.apache.maven.mercury.transport.api.Binding; +import org.apache.maven.mercury.transport.api.Server; import org.mortbay.io.Buffer; import org.mortbay.jetty.HttpMethods; import org.mortbay.jetty.client.HttpClient; @@ -117,6 +118,9 @@ { try { + if (_inputStream != null) + _inputStream.close(); + if ( _status != HttpServletResponse.SC_OK && _status != HttpServletResponse.SC_CREATED && _status != HttpServletResponse.SC_NO_CONTENT ) { onFileError( _url, new HttpClientException( _binding, "Http status code=" + _status ) ); Modified: maven/sandbox/trunk/mercury/mercury-transport/mercury-transport-http/src/main/java/org/apache/maven/mercury/spi/http/client/retrieve/FileGetExchange.java URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/mercury/mercury-transport/mercury-transport-http/src/main/java/org/apache/maven/mercury/spi/http/client/retrieve/FileGetExchange.java?rev=685467&r1=685466&r2=685467&view=diff ============================================================================== --- maven/sandbox/trunk/mercury/mercury-transport/mercury-transport-http/src/main/java/org/apache/maven/mercury/spi/http/client/retrieve/FileGetExchange.java (original) +++ maven/sandbox/trunk/mercury/mercury-transport/mercury-transport-http/src/main/java/org/apache/maven/mercury/spi/http/client/retrieve/FileGetExchange.java Tue Aug 12 23:56:52 2008 @@ -35,6 +35,7 @@ import org.apache.maven.mercury.spi.http.client.HttpClientException; import org.apache.maven.mercury.spi.http.client.ObservableOutputStream; import org.apache.maven.mercury.transport.api.Binding; +import org.apache.maven.mercury.transport.api.Server; import org.mortbay.io.Buffer; import org.mortbay.jetty.HttpMethods; import org.mortbay.jetty.client.HttpClient; @@ -82,6 +83,9 @@ //All bytes of file have been received try { + if (_outputStream != null) + _outputStream.close(); + if ( _status == HttpServletResponse.SC_NOT_FOUND ) { onFileError( _url, new FileNotFoundException( "File not found on remote server" ) );