Author: bentmann Date: Fri Apr 18 09:38:25 2008 New Revision: 649601 URL: http://svn.apache.org/viewvc?rev=649601&view=rev Log: [MPMD-70] Move hard-coded strings to resource bundle
Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java maven/plugins/trunk/maven-pmd-plugin/src/main/resources/cpd-report.properties maven/plugins/trunk/maven-pmd-plugin/src/main/resources/pmd-report.properties Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java?rev=649601&r1=649600&r2=649601&view=diff ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java Fri Apr 18 09:38:25 2008 @@ -27,7 +27,6 @@ import java.io.OutputStreamWriter; import java.io.UnsupportedEncodingException; import java.io.Writer; -import java.nio.charset.Charset; import java.util.Iterator; import java.util.Locale; import java.util.Map; @@ -158,7 +157,7 @@ { targetDirectory.mkdirs(); FileOutputStream tStream = new FileOutputStream( new File( targetDirectory, "cpd." + format ) ); - Writer writer = new OutputStreamWriter( tStream, Charset.forName( "UTF-8" ) ); + Writer writer = new OutputStreamWriter( tStream, "UTF-8" ); writer.write( buffer, 0, buffer.length() ); writer.close(); Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java?rev=649601&r1=649600&r2=649601&view=diff ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java Fri Apr 18 09:38:25 2008 @@ -113,7 +113,7 @@ if ( !matches.hasNext() ) { - sink.text( "CPD found no problems in your source code." ); + sink.text( bundle.getString( "report.cpd.noProblems" ) ); } while ( matches.hasNext() ) Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java?rev=649601&r1=649600&r2=649601&view=diff ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java Fri Apr 18 09:38:25 2008 @@ -281,7 +281,7 @@ { if ( fileCount == 0 ) { - sink.text( "PMD found no problems in your source code." ); + sink.text( bundle.getString( "report.pmd.noProblems" ) ); } sink.section1_(); Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/resources/cpd-report.properties URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/resources/cpd-report.properties?rev=649601&r1=649600&r2=649601&view=diff ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/main/resources/cpd-report.properties (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/main/resources/cpd-report.properties Fri Apr 18 09:38:25 2008 @@ -23,3 +23,4 @@ report.cpd.column.line=Line report.cpd.cpdlink=The following document contains the results of PMD's report.cpd.dupes=Duplications +report.cpd.noProblems=CPD found no problems in your source code. Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/resources/pmd-report.properties URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/resources/pmd-report.properties?rev=649601&r1=649600&r2=649601&view=diff ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/main/resources/pmd-report.properties (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/main/resources/pmd-report.properties Fri Apr 18 09:38:25 2008 @@ -22,3 +22,4 @@ report.pmd.column.line=Line report.pmd.pmdlink=The following document contains the results of report.pmd.files=Files +report.pmd.noProblems=PMD found no problems in your source code.