This is an automated email from the ASF dual-hosted git repository.

elharo pushed a commit to branch fix/xmlencode-control-chars
in repository https://gitbox.apache.org/repos/asf/maven-shared-utils.git

commit 8d4f17b28134e6f07f8bf56e212600584bc6773f
Author: Elliotte Rusty Harold <[email protected]>
AuthorDate: Wed Jul 1 08:51:26 2026 -0400

    Add failing tests: XMLEncode illegal control chars
---
 .../shared/utils/xml/PrettyPrintXmlWriterTest.java   | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git 
a/src/test/java/org/apache/maven/shared/utils/xml/PrettyPrintXmlWriterTest.java 
b/src/test/java/org/apache/maven/shared/utils/xml/PrettyPrintXmlWriterTest.java
index ee210cb..e88c695 100644
--- 
a/src/test/java/org/apache/maven/shared/utils/xml/PrettyPrintXmlWriterTest.java
+++ 
b/src/test/java/org/apache/maven/shared/utils/xml/PrettyPrintXmlWriterTest.java
@@ -93,6 +93,26 @@ public class PrettyPrintXmlWriterTest {
         assertEquals(expectedResult("    "), w.toString());
     }
 
+    @Test
+    public void testEncodeIllegalControlCharsInText() throws IOException {
+        StringWriter sw = new StringWriter();
+        PrettyPrintXMLWriter w = new PrettyPrintXMLWriter(sw);
+        w.startElement("div");
+        w.writeText("hello\u0001world");
+        w.endElement();
+        assertEquals("<div>hello&#x1;world</div>", sw.toString());
+    }
+
+    @Test
+    public void testEncodeIllegalControlCharsInAttribute() throws IOException {
+        StringWriter sw = new StringWriter();
+        PrettyPrintXMLWriter w = new PrettyPrintXMLWriter(sw);
+        w.startElement("div");
+        w.addAttribute("title", "hello\u0001world");
+        w.endElement();
+        assertEquals("<div title=\"hello&#x1;world\"/>", sw.toString());
+    }
+
     @Test
     public void testEscapeXmlAttributeWindows() throws IOException {
         // Windows

Reply via email to