This is an automated email from the ASF dual-hosted git repository.
hboutemy pushed a commit to branch v4
in repository https://gitbox.apache.org/repos/asf/maven-gh-actions-shared.git
The following commit(s) were added to refs/heads/v4 by this push:
new 405f247 Apply maven-args to the Set up Maven step
405f247 is described below
commit 405f2472bee9594b4ebe1a937021b8f1700e3fc7
Author: Gerd Aschemann <[email protected]>
AuthorDate: Sat Jun 27 10:42:58 2026 +0200
Apply maven-args to the Set up Maven step
The "Set up Maven" step bootstraps the Maven wrapper by running the
runner's system mvn against maven-wrapper-plugin:wrapper. Running any
goal in a project directory forces Maven to read the project model,
which includes resolving the parent POM -- but this step did not pass
${{ inputs.maven-args }}, unlike the later "Build with Maven" /
"Build Maven Site" steps.
A caller that injects a custom settings file via maven-args (for
example -s .github/settings.xml to reach a staged Apache parent POM
during a simultaneous parent vote) therefore could not influence parent
resolution in this first step, so the bootstrap failed with a
Non-resolvable parent POM error before the actual build ran.
Pass ${{ inputs.maven-args }} to the wrapper bootstrap in both the
fail-fast-build and verify jobs. The default value is benign, so this
is a no-op for callers that do not set maven-args.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
---
.github/workflows/maven-verify.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/maven-verify.yml
b/.github/workflows/maven-verify.yml
index 1673d26..cd242f2 100644
--- a/.github/workflows/maven-verify.yml
+++ b/.github/workflows/maven-verify.yml
@@ -317,7 +317,7 @@ jobs:
- name: Set up Maven
run:
- mvn --errors --batch-mode --show-version
org.apache.maven.plugins:maven-wrapper-plugin:3.3.4:wrapper "-Dmaven=${{
needs.setup-maven-version.outputs.version }}"
+ mvn --errors --batch-mode --show-version
org.apache.maven.plugins:maven-wrapper-plugin:3.3.4:wrapper ${{
inputs.maven-args }} "-Dmaven=${{ needs.setup-maven-version.outputs.version }}"
- name: Build with Maven
run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven-args
}} ${{ inputs.ff-goal }}
@@ -443,7 +443,7 @@ jobs:
- name: Set up Maven
if: steps.should-run.conclusion == 'success'
- run: mvn --errors --batch-mode --show-version
org.apache.maven.plugins:maven-wrapper-plugin:3.3.4:wrapper "-Dmaven=${{
matrix.maven }}"
+ run: mvn --errors --batch-mode --show-version
org.apache.maven.plugins:maven-wrapper-plugin:3.3.4:wrapper ${{
inputs.maven-args }} "-Dmaven=${{ matrix.maven }}"
- name: Build with Maven
if: steps.should-run.conclusion == 'success'
