This is an automated email from the ASF dual-hosted git repository.

gnodet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git

commit 42339126041d3050407648587f12557009093c70
Author: Guillaume Nodet <[email protected]>
AuthorDate: Sun Jun 7 07:00:53 2026 +0000

    Fix CompositeNamedLock — remove redundant double unlockAll
    
    F-31: Return false immediately after unlockAll() on lock failure
    instead of breaking out of the loop and calling unlockAll() again
    on the already-empty deque.
---
 .../org/eclipse/aether/named/support/CompositeNamedLock.java   | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git 
a/maven-resolver-named-locks/src/main/java/org/eclipse/aether/named/support/CompositeNamedLock.java
 
b/maven-resolver-named-locks/src/main/java/org/eclipse/aether/named/support/CompositeNamedLock.java
index e260d7970..583d19583 100644
--- 
a/maven-resolver-named-locks/src/main/java/org/eclipse/aether/named/support/CompositeNamedLock.java
+++ 
b/maven-resolver-named-locks/src/main/java/org/eclipse/aether/named/support/CompositeNamedLock.java
@@ -85,17 +85,13 @@ public final class CompositeNamedLock extends 
NamedLockSupport {
                         timeStr);
 
                 unlockAll(step);
-                break;
+                return false;
             } else {
                 step.push(namedLock);
             }
         }
-        if (step.size() == locks.size()) {
-            steps.push(step);
-            return true;
-        }
-        unlockAll(step);
-        return false;
+        steps.push(step);
+        return true;
     }
 
     @Override

Reply via email to