This is an automated email from the ASF dual-hosted git repository.

cstamas pushed a commit to branch maven-resolver-1.9.x
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git


The following commit(s) were added to refs/heads/maven-resolver-1.9.x by this 
push:
     new 3af2e421b Bugfix: Java 25 broke test (#1657)
3af2e421b is described below

commit 3af2e421b596b5a70c469fca5b78feb8a525c417
Author: Tamas Cservenak <[email protected]>
AuthorDate: Fri Nov 14 18:18:17 2025 +0100

    Bugfix: Java 25 broke test (#1657)
    
    As test was naively using `new File("")` assuming its method `file.list()` 
will return `null` on cleanup in `teardown()` method.
    
    But, it turns out it was an old Java bug fixed in
    Java 25, and once GH matrix got Java 25 introduced, it broke the build.
    
    Refs:
    * https://bugs.openjdk.org/browse/JDK-8024695
    * https://inside.java/2025/11/03/quality-heads-up/
    
    Thanks to @sormuras
---
 .github/workflows/maven-verify.yml                                 | 7 ++++---
 .../eclipse/aether/internal/impl/DefaultArtifactResolverTest.java  | 4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/maven-verify.yml 
b/.github/workflows/maven-verify.yml
index e9e5c9ea1..d6fd5a8f8 100644
--- a/.github/workflows/maven-verify.yml
+++ b/.github/workflows/maven-verify.yml
@@ -26,7 +26,8 @@ jobs:
     name: Verify
     uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v4
     with:
+      ff-run: false
       ff-site-run: false
-      maven-matrix: '[ "3.9.9" ]'
-
-
+      maven4-enabled: true
+      verify-fail-fast: false
+      
diff --git 
a/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultArtifactResolverTest.java
 
b/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultArtifactResolverTest.java
index 3982807d9..024d6bf0e 100644
--- 
a/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultArtifactResolverTest.java
+++ 
b/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultArtifactResolverTest.java
@@ -761,7 +761,7 @@ public class DefaultArtifactResolverTest {
         session.setLocalRepositoryManager(new LocalRepositoryManager() {
 
             public LocalRepository getRepository() {
-                return new LocalRepository(new File(""));
+                return new LocalRepository(lrm.getRepository().getBasedir());
             }
 
             public String getPathForRemoteMetadata(Metadata metadata, 
RemoteRepository repository, String context) {
@@ -828,7 +828,7 @@ public class DefaultArtifactResolverTest {
         session.setLocalRepositoryManager(new LocalRepositoryManager() {
 
             public LocalRepository getRepository() {
-                return new LocalRepository(new File(""));
+                return new LocalRepository(lrm.getRepository().getBasedir());
             }
 
             public String getPathForRemoteMetadata(Metadata metadata, 
RemoteRepository repository, String context) {

Reply via email to