This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-dependency-analyzer.git
The following commit(s) were added to refs/heads/master by this push:
new c2ca295 Handle corrupt constant pools (#242)
c2ca295 is described below
commit c2ca2952a1881da9a4d09cba466080f1b287bc04
Author: Elliotte Rusty Harold <elh...@users.noreply.github.com>
AuthorDate: Wed Jul 16 13:35:38 2025 +0000
Handle corrupt constant pools (#242)
* Handle corrupt constant pools
* Introduce UnknownConstantPoolTypeException
---
.../analyzer/asm/ConstantPoolParser.java | 7 +++--
.../analyzer/asm/DependencyClassFileVisitor.java | 2 +-
.../asm/UnknownConstantPoolTypeException.java | 32 ++++++++++++++++++++++
3 files changed, 37 insertions(+), 4 deletions(-)
diff --git
a/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java
b/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java
index 1b9da80..208f41a 100644
---
a/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java
+++
b/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java
@@ -104,11 +104,12 @@ public class ConstantPoolParser {
private static final int OX3F = 0x3F;
- static Set<String> getConstantPoolClassReferences(byte[] b) {
+ static Set<String> getConstantPoolClassReferences(byte[] b) throws
UnknownConstantPoolTypeException {
return parseConstantPoolClassReferences(ByteBuffer.wrap(b));
}
- private static Set<String> parseConstantPoolClassReferences(ByteBuffer
buf) {
+ private static Set<String> parseConstantPoolClassReferences(ByteBuffer buf)
+ throws UnknownConstantPoolTypeException {
if (buf.order(ByteOrder.BIG_ENDIAN).getInt() != HEAD) {
return Collections.emptySet();
}
@@ -171,7 +172,7 @@ public class ConstantPoolParser {
consumePackage(buf);
break;
default:
- throw new RuntimeException("Unknown constant pool type '"
+ tag + "'");
+ throw new UnknownConstantPoolTypeException("Unknown
constant pool type '" + tag + "'");
}
}
diff --git
a/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyClassFileVisitor.java
b/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyClassFileVisitor.java
index 3d16943..f8930b8 100644
---
a/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyClassFileVisitor.java
+++
b/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyClassFileVisitor.java
@@ -95,7 +95,7 @@ public class DependencyClassFileVisitor implements
ClassFileVisitor {
// some bug inside ASM causes an IOB exception.
// this happens when the class isn't valid.
throw new VisitClassException("Unable to process: " + className,
e);
- } catch (IllegalArgumentException e) {
+ } catch (UnknownConstantPoolTypeException | IllegalArgumentException
e) {
throw new VisitClassException("Byte code of '" + className + "' is
corrupt", e);
}
}
diff --git
a/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/UnknownConstantPoolTypeException.java
b/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/UnknownConstantPoolTypeException.java
new file mode 100644
index 0000000..acc71c4
--- /dev/null
+++
b/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/UnknownConstantPoolTypeException.java
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.shared.dependency.analyzer.asm;
+
+/**
+ * Exception thrown when an unknown constant pool type is encountered.
+ * This most likely indicates that a .class file is corrupt. There's
+ * also a small possibility that a newer version of Java has introduced
+ * a new constant type that this library does not yet support.
+ */
+class UnknownConstantPoolTypeException extends Exception {
+
+ UnknownConstantPoolTypeException(String message) {
+ super(message);
+ }
+}
