This is an automated email from the ASF dual-hosted git repository.
sjaranowski pushed a commit to branch maven-resolver-1.9.x
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git
The following commit(s) were added to refs/heads/maven-resolver-1.9.x by this
push:
new d60e7c83 Remove suppressions for checkstyle MagicNumber
d60e7c83 is described below
commit d60e7c8316c0f0c778601aacab1e67f9f09dbce5
Author: Slawomir Jaranowski <s.jaranow...@gmail.com>
AuthorDate: Thu May 1 12:33:04 2025 +0200
Remove suppressions for checkstyle MagicNumber
---
.../main/java/org/eclipse/aether/DefaultRepositorySystemSession.java | 1 -
.../main/java/org/eclipse/aether/repository/AuthenticationDigest.java | 2 --
.../apache/maven/resolver/examples/util/ConsoleTransferListener.java | 1 -
.../org/eclipse/aether/internal/impl/DefaultTrackingFileManager.java | 1 -
.../org/eclipse/aether/internal/impl/DefaultUpdatePolicyAnalyzer.java | 2 --
.../java/org/eclipse/aether/internal/impl/collect/df/NodeStack.java | 3 ---
.../src/main/java/org/eclipse/aether/transport/http/GlobalState.java | 1 -
.../main/java/org/eclipse/aether/transport/http/HttpTransporter.java | 3 ---
.../main/java/org/eclipse/aether/transport/http/SharingAuthCache.java | 1 -
.../src/main/java/org/eclipse/aether/util/ChecksumUtils.java | 2 --
.../src/main/java/org/eclipse/aether/util/graph/visitor/Stack.java | 2 --
.../java/org/eclipse/aether/util/repository/SecretAuthentication.java | 1 -
.../main/java/org/eclipse/aether/util/version/UnionVersionRange.java | 1 -
13 files changed, 21 deletions(-)
diff --git
a/maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
b/maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
index a6e24fd5..d31c8ae8 100644
---
a/maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
+++
b/maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
@@ -382,7 +382,6 @@ public final class DefaultRepositorySystemSession
implements RepositorySystemSes
return this;
}
- @SuppressWarnings("checkstyle:magicnumber")
private <T> Map<String, T> copySafe(Map<?, ?> table, Class<T> valueType) {
Map<String, T> map;
if (table == null || table.isEmpty()) {
diff --git
a/maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationDigest.java
b/maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationDigest.java
index ec95fcba..64d5d5d3 100644
---
a/maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationDigest.java
+++
b/maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationDigest.java
@@ -146,7 +146,6 @@ public final class AuthenticationDigest {
*
* @param chars The characters to update the digest with, may be {@code
null}.
*/
- @SuppressWarnings("checkstyle:magicnumber")
public void update(char... chars) {
if (chars != null) {
for (char c : chars) {
@@ -167,7 +166,6 @@ public final class AuthenticationDigest {
}
}
- @SuppressWarnings("checkstyle:magicnumber")
private String digest() {
byte[] bytes = digest.digest();
StringBuilder buffer = new StringBuilder(bytes.length * 2);
diff --git
a/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ConsoleTransferListener.java
b/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ConsoleTransferListener.java
index e25839d7..15dfb6a0 100644
---
a/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ConsoleTransferListener.java
+++
b/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ConsoleTransferListener.java
@@ -154,7 +154,6 @@ public class ConsoleTransferListener extends
AbstractTransferListener {
event.getException().printStackTrace(out);
}
- @SuppressWarnings("checkstyle:magicnumber")
protected long toKB(long bytes) {
return (bytes + 1023) / 1024;
}
diff --git
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTrackingFileManager.java
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTrackingFileManager.java
index 8bef789a..8f41f7d2 100644
---
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTrackingFileManager.java
+++
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTrackingFileManager.java
@@ -132,7 +132,6 @@ public final class DefaultTrackingFileManager implements
TrackingFileManager {
}
}
- @SuppressWarnings({"checkstyle:magicnumber"})
private FileLock fileLock(FileChannel channel, long size, boolean shared)
throws IOException {
FileLock lock = null;
for (int attempts = 8; attempts >= 0; attempts--) {
diff --git
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdatePolicyAnalyzer.java
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdatePolicyAnalyzer.java
index 3e3df2ba..8f3d2837 100644
---
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdatePolicyAnalyzer.java
+++
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdatePolicyAnalyzer.java
@@ -48,7 +48,6 @@ public class DefaultUpdatePolicyAnalyzer implements
UpdatePolicyAnalyzer {
return ordinalOfUpdatePolicy(policy1) < ordinalOfUpdatePolicy(policy2)
? policy1 : policy2;
}
- @SuppressWarnings({"checkstyle:magicnumber"})
private int ordinalOfUpdatePolicy(String policy) {
if (RepositoryPolicy.UPDATE_POLICY_DAILY.equals(policy)) {
return 1440;
@@ -102,7 +101,6 @@ public class DefaultUpdatePolicyAnalyzer implements
UpdatePolicyAnalyzer {
return checkForUpdates;
}
- @SuppressWarnings({"checkstyle:magicnumber"})
private int getMinutes(String policy) {
int minutes;
try {
diff --git
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/df/NodeStack.java
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/df/NodeStack.java
index 18e1a01c..e2f24a70 100644
---
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/df/NodeStack.java
+++
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/df/NodeStack.java
@@ -30,10 +30,7 @@ import org.eclipse.aether.graph.DependencyNode;
*/
final class NodeStack {
- @SuppressWarnings({"checkstyle:magicnumber"})
- // CHECKSTYLE_OFF: MagicNumber
ArrayList<DependencyNode> nodes = new ArrayList<>(96);
- // CHECKSTYLE_ON: MagicNumber
public DependencyNode top() {
if (nodes.isEmpty()) {
diff --git
a/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/GlobalState.java
b/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/GlobalState.java
index 2fdc8029..3ac06619 100644
---
a/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/GlobalState.java
+++
b/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/GlobalState.java
@@ -145,7 +145,6 @@ final class GlobalState implements Closeable {
return connectionManagers.computeIfAbsent(config,
GlobalState::newConnectionManager);
}
- @SuppressWarnings("checkstyle:magicnumber")
public static HttpClientConnectionManager
newConnectionManager(ConnMgrConfig connMgrConfig) {
RegistryBuilder<ConnectionSocketFactory> registryBuilder =
RegistryBuilder.<ConnectionSocketFactory>create()
.register("http",
PlainConnectionSocketFactory.getSocketFactory());
diff --git
a/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java
b/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java
index bfd6abc0..3057199d 100644
---
a/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java
+++
b/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java
@@ -537,7 +537,6 @@ final class HttpTransporter extends AbstractTransporter {
}
}
- @SuppressWarnings("checkstyle:magicnumber")
private void mkdirs(URI uri, SharingHttpContext context) {
List<URI> dirs = UriUtils.getDirectories(baseUri, uri);
int index = 0;
@@ -614,7 +613,6 @@ final class HttpTransporter extends AbstractTransporter {
return request;
}
- @SuppressWarnings("checkstyle:magicnumber")
private <T extends HttpUriRequest> void resume(T request, GetTask task) {
long resumeOffset = task.getResumeOffset();
if (resumeOffset > 0L && task.getDataFile() != null) {
@@ -626,7 +624,6 @@ final class HttpTransporter extends AbstractTransporter {
}
}
- @SuppressWarnings("checkstyle:magicnumber")
private void handleStatus(CloseableHttpResponse response) throws
HttpResponseException {
int status = response.getStatusLine().getStatusCode();
if (status >= 300) {
diff --git
a/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/SharingAuthCache.java
b/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/SharingAuthCache.java
index 57bd9b4b..f55b822a 100644
---
a/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/SharingAuthCache.java
+++
b/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/SharingAuthCache.java
@@ -40,7 +40,6 @@ final class SharingAuthCache implements AuthCache {
authSchemes = new HashMap<>();
}
- @SuppressWarnings("checkstyle:magicnumber")
private static HttpHost toKey(HttpHost host) {
if (host.getPort() <= 0) {
int port = host.getSchemeName().equalsIgnoreCase("https") ? 443 :
80;
diff --git
a/maven-resolver-util/src/main/java/org/eclipse/aether/util/ChecksumUtils.java
b/maven-resolver-util/src/main/java/org/eclipse/aether/util/ChecksumUtils.java
index 90c007e7..adc1737f 100644
---
a/maven-resolver-util/src/main/java/org/eclipse/aether/util/ChecksumUtils.java
+++
b/maven-resolver-util/src/main/java/org/eclipse/aether/util/ChecksumUtils.java
@@ -145,7 +145,6 @@ public final class ChecksumUtils {
* @param bytes The bytes to represent in hex notation, may be be {@code
null}.
* @return The hexadecimal representation of the input or {@code null} if
the input was {@code null}.
*/
- @SuppressWarnings("checkstyle:magicnumber")
public static String toHexString(byte[] bytes) {
if (bytes == null) {
return null;
@@ -172,7 +171,6 @@ public final class ChecksumUtils {
* @return The byte array of the input or {@code null} if the input was
{@code null}.
* @since 1.8.0
*/
- @SuppressWarnings("checkstyle:magicnumber")
public static byte[] fromHexString(String hexString) {
if (hexString == null) {
return null;
diff --git
a/maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/Stack.java
b/maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/Stack.java
index 0f443951..26f86a9c 100644
---
a/maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/Stack.java
+++
b/maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/Stack.java
@@ -29,9 +29,7 @@ import java.util.RandomAccess;
class Stack<E> extends AbstractList<E> implements RandomAccess {
@SuppressWarnings("unchecked")
- // CHECKSTYLE_OFF: MagicNumber
private E[] elements = (E[]) new Object[96];
- // CHECKSTYLE_ON: MagicNumber
private int size;
diff --git
a/maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/SecretAuthentication.java
b/maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/SecretAuthentication.java
index 2510fdaf..6a13915d 100644
---
a/maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/SecretAuthentication.java
+++
b/maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/SecretAuthentication.java
@@ -71,7 +71,6 @@ final class SecretAuthentication implements Authentication {
return (chars != null) ? chars.clone() : null;
}
- @SuppressWarnings("checkstyle:magicnumber")
private char[] xor(char[] chars) {
if (chars != null) {
int mask = System.identityHashCode(this);
diff --git
a/maven-resolver-util/src/main/java/org/eclipse/aether/util/version/UnionVersionRange.java
b/maven-resolver-util/src/main/java/org/eclipse/aether/util/version/UnionVersionRange.java
index 27356d7d..9b544e56 100644
---
a/maven-resolver-util/src/main/java/org/eclipse/aether/util/version/UnionVersionRange.java
+++
b/maven-resolver-util/src/main/java/org/eclipse/aether/util/version/UnionVersionRange.java
@@ -137,7 +137,6 @@ public final class UnionVersionRange implements
VersionRange {
return ranges.equals(that.ranges);
}
- @SuppressWarnings("checkstyle:magicnumber")
@Override
public int hashCode() {
return 97 * ranges.hashCode();
