This is an automated email from the ASF dual-hosted git repository.

bmarwell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-jlink-plugin.git

commit c5e8ffdfafa00011ec5f80c0ad5fff58517509d2
Author: Ndacyayisenga-droid <ndacyayin...@gmail.com>
AuthorDate: Wed Apr 2 02:42:57 2025 +0300

    Fix test to use DefaultArtifact
---
 .../apache/maven/plugins/jlink/JLinkMojoTest.java  | 34 +++++++++++++++++-----
 1 file changed, 26 insertions(+), 8 deletions(-)

diff --git a/src/test/java/org/apache/maven/plugins/jlink/JLinkMojoTest.java 
b/src/test/java/org/apache/maven/plugins/jlink/JLinkMojoTest.java
index 576ef76..822fcf5 100644
--- a/src/test/java/org/apache/maven/plugins/jlink/JLinkMojoTest.java
+++ b/src/test/java/org/apache/maven/plugins/jlink/JLinkMojoTest.java
@@ -24,6 +24,9 @@ import java.util.List;
 import java.util.Set;
 
 import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.DefaultArtifact;
+import org.apache.maven.artifact.handler.DefaultArtifactHandler;
+import org.apache.maven.artifact.versioning.VersionRange;
 import org.apache.maven.project.MavenProject;
 import org.apache.maven.shared.utils.cli.Commandline;
 import org.junit.jupiter.api.BeforeEach;
@@ -84,22 +87,37 @@ public class JLinkMojoTest {
     }
 
     @Test
-    void getCompileClasspathElements() throws Exception {
+    void getCompileClasspathElements_shouldSkipPomTypeArtifacts() throws 
Exception {
         // Given
         MavenProject project = Mockito.mock(MavenProject.class);
 
-        Artifact pomArtifact = Mockito.mock(Artifact.class);
-        when(pomArtifact.getType()).thenReturn("pom");
-
-        Artifact jarArtifact = Mockito.mock(Artifact.class);
-        when(jarArtifact.getType()).thenReturn("jar");
-        when(jarArtifact.getFile()).thenReturn(new File("some.jar"));
+        Artifact pomArtifact = new DefaultArtifact(
+                "group",
+                "artifact-pom",
+                VersionRange.createFromVersion("1.0"),
+                "compile",
+                "pom",
+                null,
+                new DefaultArtifactHandler("pom"));
+
+        Artifact jarArtifact = new DefaultArtifact(
+                "group",
+                "artifact-jar",
+                VersionRange.createFromVersion("1.0"),
+                "compile",
+                "jar",
+                null,
+                new DefaultArtifactHandler("jar"));
+
+        File jarFile = new File("some.jar");
+        jarArtifact.setFile(jarFile);
 
         when(project.getArtifacts()).thenReturn(Set.of(pomArtifact, 
jarArtifact));
 
+        // When
         List<File> classpathElements = 
mojo.getCompileClasspathElements(project);
 
         // Then
-        assertThat(classpathElements).containsExactly(new File("some.jar"));
+        
assertThat(classpathElements).containsExactly(jarFile).doesNotContainNull();
     }
 }

Reply via email to