(maven-dependency-analyzer) branch master updated: Remove redundant code (#144)

[elharo]

This is an automated email from the ASF dual-hosted git repository.

elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-dependency-analyzer.git


The following commit(s) were added to refs/heads/master by this push:
     new 71c0554  Remove redundant code (#144)
71c0554 is described below

commit 71c0554ec346c175e7d5f2874a7b0de4bf504041
Author: Elliotte Rusty Harold <elh...@users.noreply.github.com>
AuthorDate: Fri Apr 18 21:07:09 2025 +0000

    Remove redundant code (#144)
    
    * Remove redundant code
---
 .../shared/dependency/analyzer/ProjectDependencyAnalysis.java     | 6 +++---
 .../maven/shared/dependency/analyzer/asm/ConstantPoolParser.java  | 8 ++++----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git 
a/src/main/java/org/apache/maven/shared/dependency/analyzer/ProjectDependencyAnalysis.java
 
b/src/main/java/org/apache/maven/shared/dependency/analyzer/ProjectDependencyAnalysis.java
index 71e2496..5d0141a 100644
--- 
a/src/main/java/org/apache/maven/shared/dependency/analyzer/ProjectDependencyAnalysis.java
+++ 
b/src/main/java/org/apache/maven/shared/dependency/analyzer/ProjectDependencyAnalysis.java
@@ -65,11 +65,11 @@ public class ProjectDependencyAnalysis {
             Set<Artifact> usedDeclaredArtifacts,
             Set<Artifact> usedUndeclaredArtifacts,
             Set<Artifact> unusedDeclaredArtifacts) {
-        this(usedDeclaredArtifacts, usedUndeclaredArtifacts, 
unusedDeclaredArtifacts, Collections.<Artifact>emptySet());
+        this(usedDeclaredArtifacts, usedUndeclaredArtifacts, 
unusedDeclaredArtifacts, Collections.emptySet());
     }
 
     /**
-     * <p>Constructor for ProjectDependencyAnalysis.</p>
+     * Constructor for ProjectDependencyAnalysis.
      *
      * @param usedDeclaredArtifacts artifacts both used and declared
      * @param usedUndeclaredArtifacts artifacts used but not declared
@@ -343,7 +343,7 @@ public class ProjectDependencyAnalysis {
         Map<Artifact, Set<DependencyUsage>> map = new LinkedHashMap<>();
 
         for (Artifact k : keys) {
-            map.put(k, Collections.<DependencyUsage>emptySet());
+            map.put(k, Collections.emptySet());
         }
 
         return map;
diff --git 
a/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java
 
b/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java
index 0381efd..1b9da80 100644
--- 
a/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java
+++ 
b/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java
@@ -33,7 +33,7 @@ import org.objectweb.asm.Type;
  * A small parser to read the constant pool directly, in case it contains 
references
  * ASM does not support.
  *
- * Adapted from http://stackoverflow.com/a/32278587/23691
+ * Adapted from <a 
href="https://stackoverflow.com/questions/32255023/how-would-i-go-about-parsing-the-java-class-file-constant-pool/32278587#32278587";>Stack
 Overflow</a>
  *
  * Constant pool types:
  *
@@ -108,7 +108,7 @@ public class ConstantPoolParser {
         return parseConstantPoolClassReferences(ByteBuffer.wrap(b));
     }
 
-    static Set<String> parseConstantPoolClassReferences(ByteBuffer buf) {
+    private static Set<String> parseConstantPoolClassReferences(ByteBuffer 
buf) {
         if (buf.order(ByteOrder.BIG_ENDIAN).getInt() != HEAD) {
             return Collections.emptySet();
         }
@@ -203,11 +203,11 @@ public class ConstantPoolParser {
         }
     }
 
+    @SuppressWarnings("RedundantCast")
     private static String decodeString(ByteBuffer buf) {
         int size = buf.getChar();
+        int oldLimit = buf.limit();
         // Explicit cast for compatibility with covariant return type on JDK 
9's ByteBuffer
-        @SuppressWarnings("RedundantCast")
-        int oldLimit = ((Buffer) buf).limit();
         ((Buffer) buf).limit(buf.position() + size);
         StringBuilder sb = new StringBuilder(size + (size >> 1) + 16);
         while (buf.hasRemaining()) {