This is an automated email from the ASF dual-hosted git repository.
mbuenger pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-jmod-plugin.git
The following commit(s) were added to refs/heads/master by this push:
new f83d4c7 Enable GitHub Issue
f83d4c7 is described below
commit f83d4c7b84e1d6f6cc2810a4facb233d112e1977
Author: Matthias Bünger <buk...@users.noreply.github.com>
AuthorDate: Mon Apr 7 21:40:05 2025 +0200
Enable GitHub Issue
---
.asf.yaml | 3 ++
.asf.yaml => .github/ISSUE_TEMPLATE/BUG.yml | 59 +++++++++++++++----------
.asf.yaml => .github/ISSUE_TEMPLATE/FEATURE.yml | 46 +++++++++----------
.asf.yaml => .github/ISSUE_TEMPLATE/config.yml | 41 +++++++----------
.github/workflows/pr-automation.yml | 27 +++++++++++
.github/workflows/stale.yml | 28 ++++++++++++
README.md | 25 +++--------
pom.xml | 4 +-
8 files changed, 139 insertions(+), 94 deletions(-)
diff --git a/.asf.yaml b/.asf.yaml
index f73325e..f612cd6 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -30,6 +30,9 @@ github:
rebase: true
autolink_jira:
- MJMOD
+ del_branch_on_merge: true
+ features:
+ issues: true
notifications:
commits: commits@maven.apache.org
issues: iss...@maven.apache.org
diff --git a/.asf.yaml b/.github/ISSUE_TEMPLATE/BUG.yml
similarity index 53%
copy from .asf.yaml
copy to .github/ISSUE_TEMPLATE/BUG.yml
index f73325e..d49e4ce 100644
--- a/.asf.yaml
+++ b/.github/ISSUE_TEMPLATE/BUG.yml
@@ -1,37 +1,48 @@
-#
+#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
-#
+#
# http://www.apache.org/licenses/LICENSE-2.0
-#
+#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
-# see https://s.apache.org/asfyaml
-github:
- description: "Apache Maven JMod Plugin"
- homepage: https://maven.apache.org/plugins/maven-jmod-plugin/
- labels:
- - java
- - build-management
- - maven-plugins
- - maven-jmod-plugin
- - maven
- enabled_merge_buttons:
- squash: true
- merge: false
- rebase: true
- autolink_jira:
- - MJMOD
-notifications:
- commits: commits@maven.apache.org
- issues: iss...@maven.apache.org
- pullrequests: iss...@maven.apache.org
- jira_options: link label comment
+
+#
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema
+
+name: Bug Report
+description: File a bug report
+labels: ["bug"]
+
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to fill out this bug report.
+
+ Simple fixes in single PRs do not require issues.
+
+ **Do you use the latest project version?**
+
+ - type: input
+ id: version
+ attributes:
+ label: Affected version
+ validations:
+ required: true
+
+ - type: textarea
+ id: massage
+ attributes:
+ label: Bug description
+ validations:
+ required: true
+
+
diff --git a/.asf.yaml b/.github/ISSUE_TEMPLATE/FEATURE.yml
similarity index 60%
copy from .asf.yaml
copy to .github/ISSUE_TEMPLATE/FEATURE.yml
index f73325e..343183d 100644
--- a/.asf.yaml
+++ b/.github/ISSUE_TEMPLATE/FEATURE.yml
@@ -1,37 +1,35 @@
-#
+#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
-#
+#
# http://www.apache.org/licenses/LICENSE-2.0
-#
+#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
-# see https://s.apache.org/asfyaml
-github:
- description: "Apache Maven JMod Plugin"
- homepage: https://maven.apache.org/plugins/maven-jmod-plugin/
- labels:
- - java
- - build-management
- - maven-plugins
- - maven-jmod-plugin
- - maven
- enabled_merge_buttons:
- squash: true
- merge: false
- rebase: true
- autolink_jira:
- - MJMOD
-notifications:
- commits: commits@maven.apache.org
- issues: iss...@maven.apache.org
- pullrequests: iss...@maven.apache.org
- jira_options: link label comment
+
+#
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema
+
+name: Feature request
+description: File a proposal for new feature, improvement
+labels: ["enhancement"]
+
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to fill out this new feature, improvement
proposal.
+
+ - type: textarea
+ id: massage
+ attributes:
+ label: New feature, improvement proposal
+ validations:
+ required: true
diff --git a/.asf.yaml b/.github/ISSUE_TEMPLATE/config.yml
similarity index 60%
copy from .asf.yaml
copy to .github/ISSUE_TEMPLATE/config.yml
index f73325e..d028f95 100644
--- a/.asf.yaml
+++ b/.github/ISSUE_TEMPLATE/config.yml
@@ -1,37 +1,30 @@
-#
+#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
-#
+#
# http://www.apache.org/licenses/LICENSE-2.0
-#
+#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
-# see https://s.apache.org/asfyaml
-github:
- description: "Apache Maven JMod Plugin"
- homepage: https://maven.apache.org/plugins/maven-jmod-plugin/
- labels:
- - java
- - build-management
- - maven-plugins
- - maven-jmod-plugin
- - maven
- enabled_merge_buttons:
- squash: true
- merge: false
- rebase: true
- autolink_jira:
- - MJMOD
-notifications:
- commits: commits@maven.apache.org
- issues: iss...@maven.apache.org
- pullrequests: iss...@maven.apache.org
- jira_options: link label comment
+
+#
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser
+
+blank_issues_enabled: false
+
+contact_links:
+
+ - name: Project Mailing Lists
+ url: https://maven.apache.org/mailing-lists.html
+ about: Please ask a question or discuss here
+
+ - name: Old JIRA Issues
+ url: https://issues.apache.org/jira/projects/MJMOD
+ about: Please search old JIRA issues
diff --git a/.github/workflows/pr-automation.yml
b/.github/workflows/pr-automation.yml
new file mode 100644
index 0000000..5307595
--- /dev/null
+++ b/.github/workflows/pr-automation.yml
@@ -0,0 +1,27 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PR Automation
+on:
+ pull_request_target:
+ types:
+ - closed
+
+jobs:
+ pr-automation:
+ name: PR Automation
+ uses: apache/maven-gh-actions-shared/.github/workflows/pr-automation.yml@v4
diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml
new file mode 100644
index 0000000..69f057c
--- /dev/null
+++ b/.github/workflows/stale.yml
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Stale
+
+on:
+ schedule:
+ - cron: '11 3 * * *'
+ issue_comment:
+ types: [ 'created' ]
+
+jobs:
+ stale:
+ uses: 'apache/maven-gh-actions-shared/.github/workflows/stale.yml@v4'
diff --git a/README.md b/README.md
index 216ed08..6d3f17e 100644
--- a/README.md
+++ b/README.md
@@ -17,7 +17,6 @@
Contributing to [Apache Maven JMod
Plugin](https://maven.apache.org/plugins/maven-jmod-plugin/)
======================
-[][jira]
[][license]
[](https://search.maven.org/artifact/org.apache.maven.plugins/maven-jmod-plugin)
[](https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/maven/plugins/maven-jmod-plugin/README.md)
@@ -25,7 +24,7 @@ Contributing to [Apache Maven JMod
Plugin](https://maven.apache.org/plugins/mave
[][test-results]
-You have found a bug or you have an idea for a cool new feature? Contributing
+You have found a bug, or you have an idea for a cool new feature? Contributing
code is a great way to give something back to the open source community. Before
you dig right into the code, there are a few guidelines that we need
contributors to follow so that we can have a chance of keeping on top of
@@ -35,7 +34,6 @@ things.
Getting Started
---------------
-+ Make sure you have a [JIRA account](https://issues.apache.org/jira/).
+ Make sure you have a [GitHub account](https://github.com/signup/free).
+ If you're planning to implement a new feature, it makes sense to discuss
your changes
on the [dev list][ml-list] first.
@@ -61,11 +59,6 @@ There are some guidelines which will make applying PRs
easier for us:
+ Create minimal diffs - disable on save actions like reformat source code
or organize imports.
If you feel the source code should be reformatted, create a separate PR
for this change.
+ Check for unnecessary whitespace with `git diff --check` before
committing.
-+ Make sure your commit messages are in the proper format. Your commit message
should contain the key of the JIRA issue.
-```
-[MJMOD-XXX] - Subject of the JIRA Ticket
- Optional supplemental description.
-```
+ Make sure you have added the necessary tests (JUnit/IT) for your changes.
+ Run all the tests with `mvn -Prun-its verify` to assure nothing else was
accidentally broken.
+ Submit a pull request to the repository in the Apache organization.
@@ -73,25 +66,17 @@ There are some guidelines which will make applying PRs
easier for us:
If you plan to contribute on a regular basis, please consider filing a
[contributor license agreement][cla].
-Making Trivial Changes
-----------------------
-
-For changes of a trivial nature to comments and documentation, it is not always
-necessary to create a new ticket in JIRA. In this case, it is appropriate to
-start the first line of a commit with '(doc)' instead of a ticket number.
-
Additional Resources
--------------------
+ [Contributing
patches](https://maven.apache.org/guides/development/guide-maven-development.html#Creating_and_submitting_a_patch)
-+ [Apache Maven JMOD Plugin JIRA project page][jira]
+ [Contributor License Agreement][cla]
+ [General GitHub documentation](https://help.github.com/)
+ [GitHub pull request
documentation](https://help.github.com/send-pull-requests/)
-+ [Apache Maven Twitter Account](https://twitter.com/ASFMavenProject)
-+ #Maven IRC channel on freenode.org
++ [Apache Maven X Account](https://x.com/ASFMavenProject)
++ [Apache Maven Bluesky Account](https://bsky.app/profile/maven.apache.org)
++ [Apache Maven Mastodon
Account](https://mastodon.social/deck/@asfmavenproj...@fosstodon.org)
-[jira]: https://issues.apache.org/jira/projects/MJMOD/
[license]: https://www.apache.org/licenses/LICENSE-2.0
[ml-list]: https://maven.apache.org/mailing-lists.html
[code-style]: https://maven.apache.org/developers/conventions/code.html
@@ -111,5 +96,5 @@ mvn clean verify -Prun-its -Dinvoker.javaHome=JDK9JAVAHOME
```
The reason behind this is simply cause Maven JMod Plugin will call `jmod` tool
-of the JDK which is needed to be found. Otherwise none of the
+of the JDK which is needed to be found. Otherwise, none of the
integration tests can work.
diff --git a/pom.xml b/pom.xml
index d554a6c..0e5d627 100644
--- a/pom.xml
+++ b/pom.xml
@@ -46,8 +46,8 @@
<url>https://github.com/apache/maven-jmod-plugin/tree/${project.scm.tag}</url>
</scm>
<issueManagement>
- <system>jira</system>
- <url>https://issues.apache.org/jira/browse/MJMOD</url>
+ <system>GitHub</system>
+ <url>https://github.com/apache/maven-jmod-plugin/issues/</url>
</issueManagement>
<ciManagement>
<system>Jenkins</system>
