This is an automated email from the ASF dual-hosted git repository.

cstamas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-mvnd.git


The following commit(s) were added to refs/heads/master by this push:
     new 0bdeee9d [MMG-8600] Adopt to Maven changes (#1277)
0bdeee9d is described below

commit 0bdeee9dcb0b8a8f9e648648c9ba037f8ef91315
Author: Tamas Cservenak <ta...@cservenak.net>
AuthorDate: Fri Feb 28 14:51:59 2025 +0100

    [MMG-8600] Adopt to Maven changes (#1277)
    
    Adopt to https://github.com/apache/maven/pull/2134
    
    Goal is to be able to perform required customizations to Terminal, but also 
"raw streams" (as Maven acts on false, while mvnd on true).
---
 .../org/apache/maven/cli/DaemonMavenInvoker.java   | 39 ++++++++--------------
 1 file changed, 14 insertions(+), 25 deletions(-)

diff --git a/daemon/src/main/java/org/apache/maven/cli/DaemonMavenInvoker.java 
b/daemon/src/main/java/org/apache/maven/cli/DaemonMavenInvoker.java
index 53773d11..86055bfc 100644
--- a/daemon/src/main/java/org/apache/maven/cli/DaemonMavenInvoker.java
+++ b/daemon/src/main/java/org/apache/maven/cli/DaemonMavenInvoker.java
@@ -33,7 +33,6 @@ import org.apache.maven.execution.MavenExecutionRequest;
 import org.apache.maven.jline.MessageUtils;
 import org.apache.maven.logging.BuildEventListener;
 import org.apache.maven.logging.LoggingOutputStream;
-import org.jline.terminal.Terminal;
 import org.jline.terminal.TerminalBuilder;
 import org.mvndaemon.mvnd.common.Environment;
 
@@ -43,33 +42,23 @@ public class DaemonMavenInvoker extends 
ResidentMavenInvoker {
     }
 
     @Override
-    protected void createTerminal(MavenContext context) {
-        MessageUtils.systemInstall(
-                builder -> {
-                    builder.streams(
-                            context.invokerRequest.stdIn().orElseThrow(),
-                            context.invokerRequest.stdOut().orElseThrow());
-                    
builder.systemOutput(TerminalBuilder.SystemOutput.ForcedSysOut);
-                    builder.provider(TerminalBuilder.PROP_PROVIDER_EXEC);
-                    if (context.coloredOutput != null) {
-                        builder.color(context.coloredOutput);
-                    }
-                    // we do want to pause input
-                    builder.paused(true);
-                },
-                terminal -> doConfigureWithTerminal(context, terminal));
-        context.terminal = MessageUtils.getTerminal();
-        context.closeables.add(MessageUtils::systemUninstall);
-        MessageUtils.registerShutdownHook();
+    protected void doCreateTerminal(MavenContext context, TerminalBuilder 
builder) {
+        builder.streams(
+                context.invokerRequest.stdIn().orElseThrow(),
+                context.invokerRequest.stdOut().orElseThrow());
+        builder.systemOutput(TerminalBuilder.SystemOutput.ForcedSysOut);
+        builder.provider(TerminalBuilder.PROP_PROVIDER_EXEC);
+        if (context.coloredOutput != null) {
+            builder.color(context.coloredOutput);
+        }
+        // we do want to pause input
+        builder.paused(true);
     }
 
     @Override
-    protected void doConfigureWithTerminal(MavenContext context, Terminal 
terminal) {
-        super.doConfigureWithTerminal(context, terminal);
-        if (context.invokerRequest.options().rawStreams().orElse(false)) {
-            
System.setOut(printStream(context.invokerRequest.stdOut().orElseThrow()));
-            
System.setErr(printStream(context.invokerRequest.stdErr().orElseThrow()));
-        }
+    protected void doConfigureWithTerminalWithRawStreamsEnabled(MavenContext 
context) {
+        
System.setOut(printStream(context.invokerRequest.stdOut().orElseThrow()));
+        
System.setErr(printStream(context.invokerRequest.stdErr().orElseThrow()));
     }
 
     private PrintStream printStream(OutputStream outputStream) {

Reply via email to